adulau/aha
1
0
Fork 0
mirror of https://github.com/adulau/aha.git synced 2025-01-03 22:53:18 +00:00
Code Issues Projects Releases Packages Wiki Activity

USB: pxa27x_udc: typo fixes and code cleanups

Browse source 
This patch is a merge of patches :
 - fix function doc and debug
 - cleanup loop count
 - optimize code to remove local variable and extra check
 - init 'req' before use
 - add missing iounmap call

[dbrownell@users.sourceforge.net: capitalize IN/OUT directions in doc]

Signed-off-by: Vernon Sauder <vsauder@inhand.com>
[folded by Robert Jarzmik <robert.jarzmik@free.fr>
Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Vernon Sauder 2009-03-20 01:44:50 -07:00 committed by Greg Kroah-Hartman
parent ab943a2e12
commit 4c24b6d045
1 changed files with 24 additions and 30 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

54
drivers/usb/gadget/pxa27x_udc.c
View file

@ -748,13 +748,13 @@ static void req_done(struct pxa_ep *ep, struct pxa27x_request *req, int status)
} }
/** /**
* ep_end_out_req - Ends control endpoint in request * ep_end_out_req - Ends endpoint OUT request
* @ep: physical endpoint * @ep: physical endpoint
* @req: pxa request * @req: pxa request
* *
* Context: ep->lock held * Context: ep->lock held
* *
* Ends endpoint in request (completes usb request). * Ends endpoint OUT request (completes usb request).
*/ */
static void ep_end_out_req(struct pxa_ep *ep, struct pxa27x_request *req) static void ep_end_out_req(struct pxa_ep *ep, struct pxa27x_request *req)
{ {
@ -763,13 +763,13 @@ static void ep_end_out_req(struct pxa_ep *ep, struct pxa27x_request *req)
} }
/** /**
* ep0_end_out_req - Ends control endpoint in request (ends data stage) * ep0_end_out_req - Ends control endpoint OUT request (ends data stage)
* @ep: physical endpoint * @ep: physical endpoint
* @req: pxa request * @req: pxa request
* *
* Context: ep->lock held * Context: ep->lock held
* *
* Ends control endpoint in request (completes usb request), and puts * Ends control endpoint OUT request (completes usb request), and puts
* control endpoint into idle state * control endpoint into idle state
*/ */
static void ep0_end_out_req(struct pxa_ep *ep, struct pxa27x_request *req) static void ep0_end_out_req(struct pxa_ep *ep, struct pxa27x_request *req)
@ -780,13 +780,13 @@ static void ep0_end_out_req(struct pxa_ep *ep, struct pxa27x_request *req)
} }
/** /**
* ep_end_in_req - Ends endpoint out request * ep_end_in_req - Ends endpoint IN request
* @ep: physical endpoint * @ep: physical endpoint
* @req: pxa request * @req: pxa request
* *
* Context: ep->lock held * Context: ep->lock held
* *
* Ends endpoint out request (completes usb request). * Ends endpoint IN request (completes usb request).
*/ */
static void ep_end_in_req(struct pxa_ep *ep, struct pxa27x_request *req) static void ep_end_in_req(struct pxa_ep *ep, struct pxa27x_request *req)
{ {
@ -795,20 +795,18 @@ static void ep_end_in_req(struct pxa_ep *ep, struct pxa27x_request *req)
} }
/** /**
* ep0_end_in_req - Ends control endpoint out request (ends data stage) * ep0_end_in_req - Ends control endpoint IN request (ends data stage)
* @ep: physical endpoint * @ep: physical endpoint
* @req: pxa request * @req: pxa request
* *
* Context: ep->lock held * Context: ep->lock held
* *
* Ends control endpoint out request (completes usb request), and puts * Ends control endpoint IN request (completes usb request), and puts
* control endpoint into status state * control endpoint into status state
*/ */
static void ep0_end_in_req(struct pxa_ep *ep, struct pxa27x_request *req) static void ep0_end_in_req(struct pxa_ep *ep, struct pxa27x_request *req)
{ {
struct pxa_udc *udc = ep->dev; set_ep0state(ep->dev, IN_STATUS_STAGE);
set_ep0state(udc, IN_STATUS_STAGE);
ep_end_in_req(ep, req); ep_end_in_req(ep, req);
} }
@ -1168,7 +1166,7 @@ static int pxa_ep_queue(struct usb_ep *_ep, struct usb_request *_req,
ep_end_in_req(ep, req); ep_end_in_req(ep, req);
} else { } else {
ep_err(ep, "got a request of %d bytes while" ep_err(ep, "got a request of %d bytes while"
"in state WATI_ACK_SET_CONF_INTERF\n", "in state WAIT_ACK_SET_CONF_INTERF\n",
length); length);
ep_del_request(ep, req); ep_del_request(ep, req);
rc = -EL2HLT; rc = -EL2HLT;
@ -1214,30 +1212,26 @@ static int pxa_ep_dequeue(struct usb_ep *_ep, struct usb_request *_req)
struct udc_usb_ep *udc_usb_ep; struct udc_usb_ep *udc_usb_ep;
struct pxa27x_request *req; struct pxa27x_request *req;
unsigned long flags; unsigned long flags;
int rc; int rc = -EINVAL;
if (!_ep) if (!_ep)
return -EINVAL; return rc;
udc_usb_ep = container_of(_ep, struct udc_usb_ep, usb_ep); udc_usb_ep = container_of(_ep, struct udc_usb_ep, usb_ep);
ep = udc_usb_ep->pxa_ep; ep = udc_usb_ep->pxa_ep;
if (!ep || is_ep0(ep)) if (!ep || is_ep0(ep))
return -EINVAL; return rc;
spin_lock_irqsave(&ep->lock, flags); spin_lock_irqsave(&ep->lock, flags);
/* make sure it's actually queued on this endpoint */ /* make sure it's actually queued on this endpoint */
list_for_each_entry(req, &ep->queue, queue) { list_for_each_entry(req, &ep->queue, queue) {
if (&req->req == _req) if (&req->req == _req) {
req_done(ep, req, -ECONNRESET);
rc = 0;
break; break;
}
} }
rc = -EINVAL;
if (&req->req != _req)
goto out;
rc = 0;
req_done(ep, req, -ECONNRESET);
out:
spin_unlock_irqrestore(&ep->lock, flags); spin_unlock_irqrestore(&ep->lock, flags);
return rc; return rc;
} }
@ -1706,10 +1700,9 @@ static __init void udc_init_data(struct pxa_udc *dev)
} }
/* USB endpoints init */ /* USB endpoints init */
for (i = 0; i < NR_USB_ENDPOINTS; i++) for (i = 1; i < NR_USB_ENDPOINTS; i++)
if (i != 0) list_add_tail(&dev->udc_usb_ep[i].usb_ep.ep_list,
list_add_tail(&dev->udc_usb_ep[i].usb_ep.ep_list, &dev->gadget.ep_list);
&dev->gadget.ep_list);
} }
/** /**
@ -1994,14 +1987,14 @@ static void handle_ep0(struct pxa_udc *udc, int fifo_irq, int opc_irq)
struct pxa27x_request *req = NULL; struct pxa27x_request *req = NULL;
int completed = 0; int completed = 0;
if (!list_empty(&ep->queue))
req = list_entry(ep->queue.next, struct pxa27x_request, queue);
udccsr0 = udc_ep_readl(ep, UDCCSR); udccsr0 = udc_ep_readl(ep, UDCCSR);
ep_dbg(ep, "state=%s, req=%p, udccsr0=0x%03x, udcbcr=%d, irq_msk=%x\n", ep_dbg(ep, "state=%s, req=%p, udccsr0=0x%03x, udcbcr=%d, irq_msk=%x\n",
EP0_STNAME(udc), req, udccsr0, udc_ep_readl(ep, UDCBCR), EP0_STNAME(udc), req, udccsr0, udc_ep_readl(ep, UDCBCR),
(fifo_irq << 1 | opc_irq)); (fifo_irq << 1 | opc_irq));
if (!list_empty(&ep->queue))
req = list_entry(ep->queue.next, struct pxa27x_request, queue);
if (udccsr0 & UDCCSR0_SST) { if (udccsr0 & UDCCSR0_SST) {
ep_dbg(ep, "clearing stall status\n"); ep_dbg(ep, "clearing stall status\n");
nuke(ep, -EPIPE); nuke(ep, -EPIPE);
@ -2473,6 +2466,7 @@ static int __exit pxa_udc_remove(struct platform_device *_dev)
platform_set_drvdata(_dev, NULL); platform_set_drvdata(_dev, NULL);
the_controller = NULL; the_controller = NULL;
clk_put(udc->clk); clk_put(udc->clk);
iounmap(udc->regs);
return 0; return 0;
} }