adulau/aha
1
0
Fork 0
mirror of https://github.com/adulau/aha.git synced 2024-12-28 11:46:19 +00:00
Code Issues Projects Releases Packages Wiki Activity

[PATCH] fs/*: trivial vsnprintf() conversion

Browse source 
It would very lame to get buffer overflow via one of the following.

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Dave Kleikamp <shaggy@austin.ibm.com>
Cc: Mark Fasheh <mark.fasheh@oracle.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
This commit is contained in:
Alexey Dobriyan 2006-12-06 20:37:04 -08:00 committed by Linus Torvalds
parent e0980dafa3
commit 4a6e617a4b
6 changed files with 11 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
fs/adfs/super.c
View file

@ -36,7 +36,7 @@ void __adfs_error(struct super_block *sb, const char *function, const char *fmt,
va_list args; va_list args;
va_start(args, fmt); va_start(args, fmt);
vsprintf(error_buf, fmt, args); vsnprintf(error_buf, sizeof(error_buf), fmt, args);
va_end(args); va_end(args);
printk(KERN_CRIT "ADFS-fs error (device %s)%s%s: %s\n", printk(KERN_CRIT "ADFS-fs error (device %s)%s%s: %s\n",

4
fs/affs/amigaffs.c
View file

@ -445,7 +445,7 @@ affs_error(struct super_block *sb, const char *function, const char *fmt, ...)
va_list args; va_list args;
va_start(args,fmt); va_start(args,fmt);
vsprintf(ErrorBuffer,fmt,args); vsnprintf(ErrorBuffer,sizeof(ErrorBuffer),fmt,args);
va_end(args); va_end(args);
printk(KERN_CRIT "AFFS error (device %s): %s(): %s\n", sb->s_id, printk(KERN_CRIT "AFFS error (device %s): %s(): %s\n", sb->s_id,
@ -461,7 +461,7 @@ affs_warning(struct super_block *sb, const char *function, const char *fmt, ...)
va_list args; va_list args;
va_start(args,fmt); va_start(args,fmt);
vsprintf(ErrorBuffer,fmt,args); vsnprintf(ErrorBuffer,sizeof(ErrorBuffer),fmt,args);
va_end(args); va_end(args);
printk(KERN_WARNING "AFFS warning (device %s): %s(): %s\n", sb->s_id, printk(KERN_WARNING "AFFS warning (device %s): %s(): %s\n", sb->s_id,

2
fs/jfs/super.c
View file

@ -93,7 +93,7 @@ void jfs_error(struct super_block *sb, const char * function, ...)
va_list args; va_list args;
va_start(args, function); va_start(args, function);
vsprintf(error_buf, function, args); vsnprintf(error_buf, sizeof(error_buf), function, args);
va_end(args); va_end(args);
printk(KERN_ERR "ERROR: (device %s): %s\n", sb->s_id, error_buf); printk(KERN_ERR "ERROR: (device %s): %s\n", sb->s_id, error_buf);

4
fs/ocfs2/super.c
View file

@ -1674,7 +1674,7 @@ void __ocfs2_error(struct super_block *sb,
va_list args; va_list args;
va_start(args, fmt); va_start(args, fmt);
vsprintf(error_buf, fmt, args); vsnprintf(error_buf, sizeof(error_buf), fmt, args);
va_end(args); va_end(args);
/* Not using mlog here because we want to show the actual /* Not using mlog here because we want to show the actual
@ -1695,7 +1695,7 @@ void __ocfs2_abort(struct super_block* sb,
va_list args; va_list args;
va_start(args, fmt); va_start(args, fmt);
vsprintf(error_buf, fmt, args); vsnprintf(error_buf, sizeof(error_buf), fmt, args);
va_end(args); va_end(args);
printk(KERN_CRIT "OCFS2: abort (device %s): %s: %s\n", printk(KERN_CRIT "OCFS2: abort (device %s): %s: %s\n",

4
fs/udf/super.c
View file

@ -1709,7 +1709,7 @@ void udf_error(struct super_block *sb, const char *function,
sb->s_dirt = 1; sb->s_dirt = 1;
} }
va_start(args, fmt); va_start(args, fmt);
vsprintf(error_buf, fmt, args); vsnprintf(error_buf, sizeof(error_buf), fmt, args);
va_end(args); va_end(args);
printk (KERN_CRIT "UDF-fs error (device %s): %s: %s\n", printk (KERN_CRIT "UDF-fs error (device %s): %s: %s\n",
sb->s_id, function, error_buf); sb->s_id, function, error_buf);
@ -1721,7 +1721,7 @@ void udf_warning(struct super_block *sb, const char *function,
va_list args; va_list args;
va_start (args, fmt); va_start (args, fmt);
vsprintf(error_buf, fmt, args); vsnprintf(error_buf, sizeof(error_buf), fmt, args);
va_end(args); va_end(args);
printk(KERN_WARNING "UDF-fs warning (device %s): %s: %s\n", printk(KERN_WARNING "UDF-fs warning (device %s): %s: %s\n",
sb->s_id, function, error_buf); sb->s_id, function, error_buf);

6
fs/ufs/super.c
View file

@ -224,7 +224,7 @@ void ufs_error (struct super_block * sb, const char * function,
sb->s_flags |= MS_RDONLY; sb->s_flags |= MS_RDONLY;
} }
va_start (args, fmt); va_start (args, fmt);
vsprintf (error_buf, fmt, args); vsnprintf (error_buf, sizeof(error_buf), fmt, args);
va_end (args); va_end (args);
switch (UFS_SB(sb)->s_mount_opt & UFS_MOUNT_ONERROR) { switch (UFS_SB(sb)->s_mount_opt & UFS_MOUNT_ONERROR) {
case UFS_MOUNT_ONERROR_PANIC: case UFS_MOUNT_ONERROR_PANIC:
@ -255,7 +255,7 @@ void ufs_panic (struct super_block * sb, const char * function,
sb->s_dirt = 1; sb->s_dirt = 1;
} }
va_start (args, fmt); va_start (args, fmt);
vsprintf (error_buf, fmt, args); vsnprintf (error_buf, sizeof(error_buf), fmt, args);
va_end (args); va_end (args);
sb->s_flags |= MS_RDONLY; sb->s_flags |= MS_RDONLY;
printk (KERN_CRIT "UFS-fs panic (device %s): %s: %s\n", printk (KERN_CRIT "UFS-fs panic (device %s): %s: %s\n",
@ -268,7 +268,7 @@ void ufs_warning (struct super_block * sb, const char * function,
va_list args; va_list args;
va_start (args, fmt); va_start (args, fmt);
vsprintf (error_buf, fmt, args); vsnprintf (error_buf, sizeof(error_buf), fmt, args);
va_end (args); va_end (args);
printk (KERN_WARNING "UFS-fs warning (device %s): %s: %s\n", printk (KERN_WARNING "UFS-fs warning (device %s): %s: %s\n",
sb->s_id, function, error_buf); sb->s_id, function, error_buf);