adulau/aha
1
0
Fork 0
mirror of https://github.com/adulau/aha.git synced 2024-12-28 11:46:19 +00:00
Code Issues Projects Releases Packages Wiki Activity

hp-wmi: fix error path in hp_wmi_bios_setup()

Browse source 
The error-path code can call rfkill_unregister() with a pointer which does
not contain the result of a call to rfkill_register().  It goes BUG().

Addresses http://bugzilla.kernel.org/show_bug.cgi?id=12560.

Cc: Frans Pop <elendil@planet.nl>
Cc: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Len Brown <lenb@kernel.org>
Acked-by: Matthew Garrett <mjg@redhat.com>
Reported-by: Helge Deller <deller@gmx.de>
Testted-by: Helge Deller <deller@gmx.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Andrew Morton 2009-02-04 15:12:07 -08:00 committed by Linus Torvalds
parent 60fd760fb9
commit 44f0606d52
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
drivers/platform/x86/hp-wmi.c
View file

@ -463,9 +463,11 @@ static int __init hp_wmi_bios_setup(struct platform_device *device)
return 0; return 0;
register_wwan_err: register_wwan_err:
rfkill_unregister(bluetooth_rfkill); if (bluetooth_rfkill)
rfkill_unregister(bluetooth_rfkill);
register_bluetooth_error: register_bluetooth_error:
rfkill_unregister(wifi_rfkill); if (wifi_rfkill)
rfkill_unregister(wifi_rfkill);
add_sysfs_error: add_sysfs_error:
cleanup_sysfs(device); cleanup_sysfs(device);
return err; return err;