mirror of
https://github.com/adulau/aha.git
synced 2024-12-28 03:36:19 +00:00
RDS: Fix panic on unload
Remove explicit destruction of passive connection when destroying active end of the connection. The passive end is also on the device's connection list, and will thus be cleaned up properly. Panic was caused by trying to clean it up twice. Signed-off-by: Andy Grover <andy.grover@oracle.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
86357b19bc
commit
433d308dd8
2 changed files with 2 additions and 8 deletions
|
@ -187,11 +187,8 @@ void __rds_ib_destroy_conns(struct list_head *list, spinlock_t *list_lock)
|
|||
INIT_LIST_HEAD(list);
|
||||
spin_unlock_irq(list_lock);
|
||||
|
||||
list_for_each_entry_safe(ic, _ic, &tmp_list, ib_node) {
|
||||
if (ic->conn->c_passive)
|
||||
rds_conn_destroy(ic->conn->c_passive);
|
||||
list_for_each_entry_safe(ic, _ic, &tmp_list, ib_node)
|
||||
rds_conn_destroy(ic->conn);
|
||||
}
|
||||
}
|
||||
|
||||
struct rds_ib_mr_pool *rds_ib_create_mr_pool(struct rds_ib_device *rds_ibdev)
|
||||
|
|
|
@ -245,11 +245,8 @@ void __rds_iw_destroy_conns(struct list_head *list, spinlock_t *list_lock)
|
|||
INIT_LIST_HEAD(list);
|
||||
spin_unlock_irq(list_lock);
|
||||
|
||||
list_for_each_entry_safe(ic, _ic, &tmp_list, iw_node) {
|
||||
if (ic->conn->c_passive)
|
||||
rds_conn_destroy(ic->conn->c_passive);
|
||||
list_for_each_entry_safe(ic, _ic, &tmp_list, iw_node)
|
||||
rds_conn_destroy(ic->conn);
|
||||
}
|
||||
}
|
||||
|
||||
static void rds_iw_set_scatterlist(struct rds_iw_scatterlist *sg,
|
||||
|
|
Loading…
Reference in a new issue