adulau/aha
1
0
Fork 0
mirror of https://github.com/adulau/aha.git synced 2024-12-27 11:16:11 +00:00
Code Issues Projects Releases Packages Wiki Activity

USB: Fix a bug on appledisplay.c regarding signedness

Browse source 
brightness status is reported by the Apple Cinema Displays as an
'unsigned char' (u8) value, but the code used 'char' instead.

Note that he driver was developed on the PowerPC architecture,
where the two types are synonymous, which is not always the case.

Fixed that.  Otherwise the driver will interpret brightness
levels > 127 as negative, and fail to load.

Signed-off-by: pancho horrillo <pancho@pancho.name>
Cc: stable <stable@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
pancho horrillo 2009-12-23 11:09:13 +01:00 committed by Greg Kroah-Hartman
parent c983202bd0
commit 37e9066b2f
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
drivers/usb/misc/appledisplay.c
View file

@ -73,8 +73,8 @@ struct appledisplay {
struct usb_device *udev; /* usb device */ struct usb_device *udev; /* usb device */
struct urb *urb; /* usb request block */ struct urb *urb; /* usb request block */
struct backlight_device *bd; /* backlight device */ struct backlight_device *bd; /* backlight device */
char *urbdata; /* interrupt URB data buffer */ u8 *urbdata; /* interrupt URB data buffer */
char *msgdata; /* control message data buffer */ u8 *msgdata; /* control message data buffer */
struct delayed_work work; struct delayed_work work;
int button_pressed; int button_pressed;