adulau/aha
1
0
Fork 0
mirror of https://github.com/adulau/aha.git synced 2024-12-29 04:06:22 +00:00
Code Issues Projects Releases Packages Wiki Activity

Staging: pohmelfs: fix kconfig dependencies

Browse source 
pohmelfs wants to use CONNECTOR, so it selects CONNECTOR,
but when CONFIG_NET is not enabled, connector.c will not build,
since select does not follow the dependency chain.
Selecting NET is not a good idea, since that would build lots
of code that someone seemingly didn't want to build/store
and kconfig shouldn't do that behind someone's back.

pohmelfs should depend on NET since it uses network interfaces.

pohmelfs also uses CRYTPO and selects 2 cipher symbols, but
it should also select the top-level CRYPTO symbol since
kconfig dependency chains are not followed.
(found by inspection)
This allows the POHMELFS_CRYPTO option to depend only on
POHMELFS and makes the kconfig menu align properly.

Also fix minor typos & line lengths in kconfig help text.
Drop CONFIG_* in kconfig symbols in Kconfig file.


connector.c:(.text+0x46003): undefined reference to `kfree_skb'
connector.c:(.text+0x460a6): undefined reference to `kfree_skb'
connector.c:(.text+0x4612b): undefined reference to `kfree_skb'
(.text+0x4624f): undefined reference to `netlink_has_listeners'
(.text+0x4629b): undefined reference to `__alloc_skb'
(.text+0x462ea): undefined reference to `kfree_skb'
(.text+0x46308): undefined reference to `skb_put'
(.text+0x46385): undefined reference to `netlink_broadcast'
(.text+0x7b574): undefined reference to `sock_release'
(.text+0x7b8dd): undefined reference to `sock_create'
(.text+0x7b984): undefined reference to `kernel_connect'
(.text+0x7ba4c): undefined reference to `sock_release'
net.c:(.text+0x7bda4): undefined reference to `kernel_recvmsg'
(.text+0x7ef42): undefined reference to `kernel_sendmsg'
(.text+0x7f057): undefined reference to `kernel_sendpage'
(.text+0x7f1e8): undefined reference to `kernel_sendmsg'
connector.c:(.devinit.text+0x5b): undefined reference to `init_net'
connector.c:(.devinit.text+0x60): undefined reference to `netlink_kernel_create'
connector.c:(.devinit.text+0xc9): undefined reference to `netlink_kernel_release'
connector.c:(.devexit.text+0x2c): undefined reference to `netlink_kernel_release'

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Evgeniy Polyakov <zbr@ioremap.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Randy Dunlap 2009-02-18 13:01:34 -08:00 committed by Greg Kroah-Hartman
parent a6bab77c71
commit 36ec4ab8c4
1 changed files with 10 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
drivers/staging/pohmelfs/Kconfig
View file

@ -1,13 +1,14 @@
config POHMELFS config POHMELFS
tristate "POHMELFS filesystem support" tristate "POHMELFS filesystem support"
depends on NET
select CONNECTOR select CONNECTOR
select CRYPTO select CRYPTO
select CRYPTO_BLKCIPHER select CRYPTO_BLKCIPHER
select CRYPTO_HMAC select CRYPTO_HMAC
help help
POHMELFS stands for Parallel Optimized Host Message Exchange Layered File System. POHMELFS stands for Parallel Optimized Host Message Exchange Layered
This is a network filesystem which supports coherent caching of data and metadata File System. This is a network filesystem which supports coherent
on clients. caching of data and metadata on clients.
config POHMELFS_DEBUG config POHMELFS_DEBUG
bool "POHMELFS debugging" bool "POHMELFS debugging"
@ -15,12 +16,13 @@ config POHMELFS_DEBUG
default n default n
help help
Turns on excessive POHMELFS debugging facilities. Turns on excessive POHMELFS debugging facilities.
You usually do not want to slow things down noticebly and get really lots of kernel You usually do not want to slow things down noticeably and get really
messages in syslog. lots of kernel messages in syslog.
config POHMELFS_CRYPTO config POHMELFS_CRYPTO
bool "POHMELFS crypto support" bool "POHMELFS crypto support"
depends on CONFIG_CRYPTO_BLKCIPHER && CONFIG_CRYPTO_HASH depends on POHMELFS
help help
This option allows to encrypt and/or protect with strong cryptographic hash all dataflow This option allows to encrypt and/or protect with strong
between server and clients. Each config group can have own keys. cryptographic hash all dataflow between server and clients.
Each config group can have its own keys.