mirror of
https://github.com/adulau/aha.git
synced 2024-12-28 03:36:19 +00:00
netfilter: xtables: mark initial tables constant
The inputted table is never modified, so should be considered const. Signed-off-by: Jan Engelhardt <jengelh@medozas.de> Signed-off-by: Patrick McHardy <kaber@trash.net>
This commit is contained in:
parent
dc05a564ab
commit
35aad0ffdf
22 changed files with 42 additions and 37 deletions
|
@ -407,7 +407,7 @@ extern int xt_check_target(struct xt_tgchk_param *,
|
|||
unsigned int size, u_int8_t proto, bool inv_proto);
|
||||
|
||||
extern struct xt_table *xt_register_table(struct net *net,
|
||||
struct xt_table *table,
|
||||
const struct xt_table *table,
|
||||
struct xt_table_info *bootstrap,
|
||||
struct xt_table_info *newinfo);
|
||||
extern void *xt_unregister_table(struct xt_table *table);
|
||||
|
|
|
@ -265,7 +265,7 @@ struct arpt_error
|
|||
}
|
||||
|
||||
extern struct xt_table *arpt_register_table(struct net *net,
|
||||
struct xt_table *table,
|
||||
const struct xt_table *table,
|
||||
const struct arpt_replace *repl);
|
||||
extern void arpt_unregister_table(struct xt_table *table);
|
||||
extern unsigned int arpt_do_table(struct sk_buff *skb,
|
||||
|
|
|
@ -301,7 +301,7 @@ struct ebt_table
|
|||
#define EBT_ALIGN(s) (((s) + (__alignof__(struct ebt_replace)-1)) & \
|
||||
~(__alignof__(struct ebt_replace)-1))
|
||||
extern struct ebt_table *ebt_register_table(struct net *net,
|
||||
struct ebt_table *table);
|
||||
const struct ebt_table *table);
|
||||
extern void ebt_unregister_table(struct ebt_table *table);
|
||||
extern unsigned int ebt_do_table(unsigned int hook, struct sk_buff *skb,
|
||||
const struct net_device *in, const struct net_device *out,
|
||||
|
|
|
@ -245,7 +245,7 @@ ipt_get_target(struct ipt_entry *e)
|
|||
extern void ipt_init(void) __init;
|
||||
|
||||
extern struct xt_table *ipt_register_table(struct net *net,
|
||||
struct xt_table *table,
|
||||
const struct xt_table *table,
|
||||
const struct ipt_replace *repl);
|
||||
extern void ipt_unregister_table(struct xt_table *table);
|
||||
|
||||
|
|
|
@ -306,7 +306,7 @@ ip6t_get_target(struct ip6t_entry *e)
|
|||
extern void ip6t_init(void) __init;
|
||||
|
||||
extern struct xt_table *ip6t_register_table(struct net *net,
|
||||
struct xt_table *table,
|
||||
const struct xt_table *table,
|
||||
const struct ip6t_replace *repl);
|
||||
extern void ip6t_unregister_table(struct xt_table *table);
|
||||
extern unsigned int ip6t_do_table(struct sk_buff *skb,
|
||||
|
|
|
@ -41,7 +41,7 @@ static int check(const struct ebt_table_info *info, unsigned int valid_hooks)
|
|||
return 0;
|
||||
}
|
||||
|
||||
static struct ebt_table broute_table =
|
||||
static const struct ebt_table broute_table =
|
||||
{
|
||||
.name = "broute",
|
||||
.table = &initial_table,
|
||||
|
|
|
@ -50,7 +50,7 @@ static int check(const struct ebt_table_info *info, unsigned int valid_hooks)
|
|||
return 0;
|
||||
}
|
||||
|
||||
static struct ebt_table frame_filter =
|
||||
static const struct ebt_table frame_filter =
|
||||
{
|
||||
.name = "filter",
|
||||
.table = &initial_table,
|
||||
|
|
|
@ -1103,23 +1103,24 @@ free_newinfo:
|
|||
return ret;
|
||||
}
|
||||
|
||||
struct ebt_table *ebt_register_table(struct net *net, struct ebt_table *table)
|
||||
struct ebt_table *
|
||||
ebt_register_table(struct net *net, const struct ebt_table *input_table)
|
||||
{
|
||||
struct ebt_table_info *newinfo;
|
||||
struct ebt_table *t;
|
||||
struct ebt_table *t, *table;
|
||||
struct ebt_replace_kernel *repl;
|
||||
int ret, i, countersize;
|
||||
void *p;
|
||||
|
||||
if (!table || !(repl = table->table) || !repl->entries ||
|
||||
repl->entries_size == 0 ||
|
||||
repl->counters || table->private) {
|
||||
if (input_table == NULL || (repl = input_table->table) == NULL ||
|
||||
repl->entries == 0 || repl->entries_size == 0 ||
|
||||
repl->counters != NULL || input_table->private != NULL) {
|
||||
BUGPRINT("Bad table data for ebt_register_table!!!\n");
|
||||
return ERR_PTR(-EINVAL);
|
||||
}
|
||||
|
||||
/* Don't add one table to multiple lists. */
|
||||
table = kmemdup(table, sizeof(struct ebt_table), GFP_KERNEL);
|
||||
table = kmemdup(input_table, sizeof(struct ebt_table), GFP_KERNEL);
|
||||
if (!table) {
|
||||
ret = -ENOMEM;
|
||||
goto out;
|
||||
|
|
|
@ -1778,7 +1778,8 @@ static int do_arpt_get_ctl(struct sock *sk, int cmd, void __user *user, int *len
|
|||
return ret;
|
||||
}
|
||||
|
||||
struct xt_table *arpt_register_table(struct net *net, struct xt_table *table,
|
||||
struct xt_table *arpt_register_table(struct net *net,
|
||||
const struct xt_table *table,
|
||||
const struct arpt_replace *repl)
|
||||
{
|
||||
int ret;
|
||||
|
|
|
@ -15,7 +15,7 @@ MODULE_DESCRIPTION("arptables filter table");
|
|||
#define FILTER_VALID_HOOKS ((1 << NF_ARP_IN) | (1 << NF_ARP_OUT) | \
|
||||
(1 << NF_ARP_FORWARD))
|
||||
|
||||
static struct
|
||||
static const struct
|
||||
{
|
||||
struct arpt_replace repl;
|
||||
struct arpt_standard entries[3];
|
||||
|
@ -45,7 +45,7 @@ static struct
|
|||
.term = ARPT_ERROR_INIT,
|
||||
};
|
||||
|
||||
static struct xt_table packet_filter = {
|
||||
static const struct xt_table packet_filter = {
|
||||
.name = "filter",
|
||||
.valid_hooks = FILTER_VALID_HOOKS,
|
||||
.me = THIS_MODULE,
|
||||
|
|
|
@ -2065,7 +2065,8 @@ do_ipt_get_ctl(struct sock *sk, int cmd, void __user *user, int *len)
|
|||
return ret;
|
||||
}
|
||||
|
||||
struct xt_table *ipt_register_table(struct net *net, struct xt_table *table,
|
||||
struct xt_table *ipt_register_table(struct net *net,
|
||||
const struct xt_table *table,
|
||||
const struct ipt_replace *repl)
|
||||
{
|
||||
int ret;
|
||||
|
|
|
@ -53,7 +53,7 @@ static struct
|
|||
.term = IPT_ERROR_INIT, /* ERROR */
|
||||
};
|
||||
|
||||
static struct xt_table packet_filter = {
|
||||
static const struct xt_table packet_filter = {
|
||||
.name = "filter",
|
||||
.valid_hooks = FILTER_VALID_HOOKS,
|
||||
.me = THIS_MODULE,
|
||||
|
|
|
@ -28,7 +28,7 @@ MODULE_DESCRIPTION("iptables mangle table");
|
|||
(1 << NF_INET_POST_ROUTING))
|
||||
|
||||
/* Ouch - five different hooks? Maybe this should be a config option..... -- BC */
|
||||
static struct
|
||||
static const struct
|
||||
{
|
||||
struct ipt_replace repl;
|
||||
struct ipt_standard entries[5];
|
||||
|
@ -64,7 +64,7 @@ static struct
|
|||
.term = IPT_ERROR_INIT, /* ERROR */
|
||||
};
|
||||
|
||||
static struct xt_table packet_mangler = {
|
||||
static const struct xt_table packet_mangler = {
|
||||
.name = "mangle",
|
||||
.valid_hooks = MANGLE_VALID_HOOKS,
|
||||
.me = THIS_MODULE,
|
||||
|
|
|
@ -9,7 +9,7 @@
|
|||
|
||||
#define RAW_VALID_HOOKS ((1 << NF_INET_PRE_ROUTING) | (1 << NF_INET_LOCAL_OUT))
|
||||
|
||||
static struct
|
||||
static const struct
|
||||
{
|
||||
struct ipt_replace repl;
|
||||
struct ipt_standard entries[2];
|
||||
|
@ -36,7 +36,7 @@ static struct
|
|||
.term = IPT_ERROR_INIT, /* ERROR */
|
||||
};
|
||||
|
||||
static struct xt_table packet_raw = {
|
||||
static const struct xt_table packet_raw = {
|
||||
.name = "raw",
|
||||
.valid_hooks = RAW_VALID_HOOKS,
|
||||
.me = THIS_MODULE,
|
||||
|
|
|
@ -27,7 +27,7 @@ MODULE_DESCRIPTION("iptables security table, for MAC rules");
|
|||
(1 << NF_INET_FORWARD) | \
|
||||
(1 << NF_INET_LOCAL_OUT)
|
||||
|
||||
static struct
|
||||
static const struct
|
||||
{
|
||||
struct ipt_replace repl;
|
||||
struct ipt_standard entries[3];
|
||||
|
@ -57,7 +57,7 @@ static struct
|
|||
.term = IPT_ERROR_INIT, /* ERROR */
|
||||
};
|
||||
|
||||
static struct xt_table security_table = {
|
||||
static const struct xt_table security_table = {
|
||||
.name = "security",
|
||||
.valid_hooks = SECURITY_VALID_HOOKS,
|
||||
.me = THIS_MODULE,
|
||||
|
|
|
@ -28,7 +28,7 @@
|
|||
(1 << NF_INET_POST_ROUTING) | \
|
||||
(1 << NF_INET_LOCAL_OUT))
|
||||
|
||||
static struct
|
||||
static const struct
|
||||
{
|
||||
struct ipt_replace repl;
|
||||
struct ipt_standard entries[3];
|
||||
|
@ -58,7 +58,7 @@ static struct
|
|||
.term = IPT_ERROR_INIT, /* ERROR */
|
||||
};
|
||||
|
||||
static struct xt_table nat_table = {
|
||||
static const struct xt_table nat_table = {
|
||||
.name = "nat",
|
||||
.valid_hooks = NAT_VALID_HOOKS,
|
||||
.me = THIS_MODULE,
|
||||
|
|
|
@ -2100,7 +2100,8 @@ do_ip6t_get_ctl(struct sock *sk, int cmd, void __user *user, int *len)
|
|||
return ret;
|
||||
}
|
||||
|
||||
struct xt_table *ip6t_register_table(struct net *net, struct xt_table *table,
|
||||
struct xt_table *ip6t_register_table(struct net *net,
|
||||
const struct xt_table *table,
|
||||
const struct ip6t_replace *repl)
|
||||
{
|
||||
int ret;
|
||||
|
|
|
@ -51,7 +51,7 @@ static struct
|
|||
.term = IP6T_ERROR_INIT, /* ERROR */
|
||||
};
|
||||
|
||||
static struct xt_table packet_filter = {
|
||||
static const struct xt_table packet_filter = {
|
||||
.name = "filter",
|
||||
.valid_hooks = FILTER_VALID_HOOKS,
|
||||
.me = THIS_MODULE,
|
||||
|
|
|
@ -21,7 +21,7 @@ MODULE_DESCRIPTION("ip6tables mangle table");
|
|||
(1 << NF_INET_LOCAL_OUT) | \
|
||||
(1 << NF_INET_POST_ROUTING))
|
||||
|
||||
static struct
|
||||
static const struct
|
||||
{
|
||||
struct ip6t_replace repl;
|
||||
struct ip6t_standard entries[5];
|
||||
|
@ -57,7 +57,7 @@ static struct
|
|||
.term = IP6T_ERROR_INIT, /* ERROR */
|
||||
};
|
||||
|
||||
static struct xt_table packet_mangler = {
|
||||
static const struct xt_table packet_mangler = {
|
||||
.name = "mangle",
|
||||
.valid_hooks = MANGLE_VALID_HOOKS,
|
||||
.me = THIS_MODULE,
|
||||
|
|
|
@ -8,7 +8,7 @@
|
|||
|
||||
#define RAW_VALID_HOOKS ((1 << NF_INET_PRE_ROUTING) | (1 << NF_INET_LOCAL_OUT))
|
||||
|
||||
static struct
|
||||
static const struct
|
||||
{
|
||||
struct ip6t_replace repl;
|
||||
struct ip6t_standard entries[2];
|
||||
|
@ -35,7 +35,7 @@ static struct
|
|||
.term = IP6T_ERROR_INIT, /* ERROR */
|
||||
};
|
||||
|
||||
static struct xt_table packet_raw = {
|
||||
static const struct xt_table packet_raw = {
|
||||
.name = "raw",
|
||||
.valid_hooks = RAW_VALID_HOOKS,
|
||||
.me = THIS_MODULE,
|
||||
|
|
|
@ -26,7 +26,7 @@ MODULE_DESCRIPTION("ip6tables security table, for MAC rules");
|
|||
(1 << NF_INET_FORWARD) | \
|
||||
(1 << NF_INET_LOCAL_OUT)
|
||||
|
||||
static struct
|
||||
static const struct
|
||||
{
|
||||
struct ip6t_replace repl;
|
||||
struct ip6t_standard entries[3];
|
||||
|
@ -56,7 +56,7 @@ static struct
|
|||
.term = IP6T_ERROR_INIT, /* ERROR */
|
||||
};
|
||||
|
||||
static struct xt_table security_table = {
|
||||
static const struct xt_table security_table = {
|
||||
.name = "security",
|
||||
.valid_hooks = SECURITY_VALID_HOOKS,
|
||||
.me = THIS_MODULE,
|
||||
|
|
|
@ -736,16 +736,17 @@ xt_replace_table(struct xt_table *table,
|
|||
}
|
||||
EXPORT_SYMBOL_GPL(xt_replace_table);
|
||||
|
||||
struct xt_table *xt_register_table(struct net *net, struct xt_table *table,
|
||||
struct xt_table *xt_register_table(struct net *net,
|
||||
const struct xt_table *input_table,
|
||||
struct xt_table_info *bootstrap,
|
||||
struct xt_table_info *newinfo)
|
||||
{
|
||||
int ret;
|
||||
struct xt_table_info *private;
|
||||
struct xt_table *t;
|
||||
struct xt_table *t, *table;
|
||||
|
||||
/* Don't add one object to multiple lists. */
|
||||
table = kmemdup(table, sizeof(struct xt_table), GFP_KERNEL);
|
||||
table = kmemdup(input_table, sizeof(struct xt_table), GFP_KERNEL);
|
||||
if (!table) {
|
||||
ret = -ENOMEM;
|
||||
goto out;
|
||||
|
|
Loading…
Reference in a new issue