adulau/aha
1
0
Fork 0
mirror of https://github.com/adulau/aha.git synced 2024-12-28 11:46:19 +00:00
Code Issues Projects Releases Packages Wiki Activity

gdrom: dequeue in-flight request

Browse source 
gdrom already dequeues and fully completes requests on normal path and
the error paths can be easily converted to do so too.  Clean it up and
dequeue requests on error paths too.

While at it remove superflous blk_fs_request() && !blk_rq_sectors()
condition check.

[ Impact: dequeue in-flight request, cleanup ]

Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Adrian McMenamin <adrian@mcmen.demon.co.uk>
Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
This commit is contained in:
Tejun Heo 2009-05-08 11:54:14 +09:00 committed by Jens Axboe
parent 296b2f6ae6
commit 2343046826
1 changed files with 13 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

28
drivers/cdrom/gdrom.c
View file

@ -638,33 +638,31 @@ static void gdrom_readdisk_dma(struct work_struct *work)
kfree(read_command); kfree(read_command);
} }
static void gdrom_request_handler_dma(struct request *req)
{
/* dequeue, add to list of deferred work
* and then schedule workqueue */
blkdev_dequeue_request(req);
list_add_tail(&req->queuelist, &gdrom_deferred);
schedule_work(&work);
}
static void gdrom_request(struct request_queue *rq) static void gdrom_request(struct request_queue *rq)
{ {
struct request *req; struct request *req;
while ((req = elv_next_request(rq)) != NULL) { while ((req = elv_next_request(rq)) != NULL) {
blkdev_dequeue_request(req);
if (!blk_fs_request(req)) { if (!blk_fs_request(req)) {
printk(KERN_DEBUG "GDROM: Non-fs request ignored\n"); printk(KERN_DEBUG "GDROM: Non-fs request ignored\n");
__blk_end_request_cur(req, -EIO); __blk_end_request_all(req, -EIO);
continue;
} }
if (rq_data_dir(req) != READ) { if (rq_data_dir(req) != READ) {
printk(KERN_NOTICE "GDROM: Read only device -"); printk(KERN_NOTICE "GDROM: Read only device -");
printk(" write request ignored\n"); printk(" write request ignored\n");
__blk_end_request_cur(req, -EIO); __blk_end_request_all(req, -EIO);
continue;
} }
if (blk_rq_sectors(req))
gdrom_request_handler_dma(req); /*
else * Add to list of deferred work and then schedule
__blk_end_request_cur(req, -EIO); * workqueue.
*/
list_add_tail(&req->queuelist, &gdrom_deferred);
schedule_work(&work);
} }
} }