adulau/aha
1
0
Fork 0
mirror of https://github.com/adulau/aha.git synced 2024-12-28 11:46:19 +00:00
Code Issues Projects Releases Packages Wiki Activity

V4L/DVB (13656): tw9910: tw9910_set_hsync clean up

Browse source 
tw9910_set_hsync should use tw9910_mask_set to set bits 2-0

Signed-off-by: Kuninori Morimoto <morimoto.kuninori@renesas.com>
Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
This commit is contained in:
Kuninori Morimoto 2009-12-11 11:34:51 -03:00 committed by Mauro Carvalho Chehab
parent 607e5ad8d5
commit 2079708381
1 changed files with 16 additions and 21 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

37
drivers/media/video/tw9910.c
View file

@ -371,6 +371,19 @@ static struct tw9910_priv *to_tw9910(const struct i2c_client *client)
subdev); subdev);
} }
static int tw9910_mask_set(struct i2c_client *client, u8 command,
u8 mask, u8 set)
{
s32 val = i2c_smbus_read_byte_data(client, command);
if (val < 0)
return val;
val &= ~mask;
val |= set & mask;
return i2c_smbus_write_byte_data(client, command, val);
}
static int tw9910_set_scale(struct i2c_client *client, static int tw9910_set_scale(struct i2c_client *client,
const struct tw9910_scale_ctrl *scale) const struct tw9910_scale_ctrl *scale)
{ {
@ -445,14 +458,9 @@ static int tw9910_set_hsync(struct i2c_client *client,
return ret; return ret;
/* bit 2 - 0 */ /* bit 2 - 0 */
ret = i2c_smbus_read_byte_data(client, HSLOWCTL); ret = tw9910_mask_set(client, HSLOWCTL, 0x77,
if (ret < 0) (hsync->start & 0x0007) << 4 |
return ret; (hsync->end & 0x0007));
ret = i2c_smbus_write_byte_data(client, HSLOWCTL,
(ret & 0x88) |
(hsync->start & 0x0007) << 4 |
(hsync->end & 0x0007));
return ret; return ret;
} }
@ -471,19 +479,6 @@ static int tw9910_write_array(struct i2c_client *client,
return 0; return 0;
} }
static int tw9910_mask_set(struct i2c_client *client, u8 command,
u8 mask, u8 set)
{
s32 val = i2c_smbus_read_byte_data(client, command);
if (val < 0)
return val;
val &= ~mask;
val |= set & mask;
return i2c_smbus_write_byte_data(client, command, val);
}
static void tw9910_reset(struct i2c_client *client) static void tw9910_reset(struct i2c_client *client)
{ {
tw9910_mask_set(client, ACNTL1, SRESET, SRESET); tw9910_mask_set(client, ACNTL1, SRESET, SRESET);