adulau/aha
1
0
Fork 0
mirror of https://github.com/adulau/aha.git synced 2024-12-29 04:06:22 +00:00
Code Issues Projects Releases Packages Wiki Activity

[TCP]: Use BUILD_BUG_ON for tcp_skb_cb size checking

Browse source 
The sizeof(struct tcp_skb_cb) should not be less than the
sizeof(skb->cb). This is checked in net/ipv4/tcp.c, but
this check can be made more gracefully.

Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Pavel Emelyanov 2007-12-11 02:12:04 -08:00 committed by David S. Miller
parent ea72912c88
commit 1f9e636ea2
1 changed files with 1 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
net/ipv4/tcp.c
View file

@ -2563,7 +2563,6 @@ void tcp_done(struct sock *sk)
} }
EXPORT_SYMBOL_GPL(tcp_done); EXPORT_SYMBOL_GPL(tcp_done);
extern void __skb_cb_too_small_for_tcp(int, int);
extern struct tcp_congestion_ops tcp_reno; extern struct tcp_congestion_ops tcp_reno;
static __initdata unsigned long thash_entries; static __initdata unsigned long thash_entries;
@ -2582,9 +2581,7 @@ void __init tcp_init(void)
unsigned long limit; unsigned long limit;
int order, i, max_share; int order, i, max_share;
if (sizeof(struct tcp_skb_cb) > sizeof(skb->cb)) BUILD_BUG_ON(sizeof(struct tcp_skb_cb) > sizeof(skb->cb));
__skb_cb_too_small_for_tcp(sizeof(struct tcp_skb_cb),
sizeof(skb->cb));
tcp_hashinfo.bind_bucket_cachep = tcp_hashinfo.bind_bucket_cachep =
kmem_cache_create("tcp_bind_bucket", kmem_cache_create("tcp_bind_bucket",