adulau/aha
1
0
Fork 0
mirror of https://github.com/adulau/aha.git synced 2024-12-28 11:46:19 +00:00
Code Issues Projects Releases Packages Wiki Activity

writeback: fix possible bdi writeback refcounting problem

Browse source 
wb_clear_pending AFAIKS should not be called after the item has been
put on the list, except by the worker threads. It could lead to the
situation where the refcount is decremented below 0 and cause lots of
problems.

Presumably the !wb_has_dirty_io case is not a common one, so it can
be discovered when the thread wakes up to check?

Also add a comment in bdi_work_clear.

Signed-off-by: Nick Piggin <npiggin@suse.de>
Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
This commit is contained in:
Nick Piggin 2009-09-15 21:37:55 +02:00 committed by Jens Axboe
parent 77b9d059cb
commit 1ef7d9aa32
1 changed files with 6 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
fs/fs-writeback.c
View file

@ -97,6 +97,11 @@ static void bdi_work_clear(struct bdi_work *work)
{ {
clear_bit(WS_USED_B, &work->state); clear_bit(WS_USED_B, &work->state);
smp_mb__after_clear_bit(); smp_mb__after_clear_bit();
/*
* work can have disappeared at this point. bit waitq functions
* should be able to tolerate this, provided bdi_sched_wait does
* not dereference it's pointer argument.
*/
wake_up_bit(&work->state, WS_USED_B); wake_up_bit(&work->state, WS_USED_B);
} }
@ -169,13 +174,7 @@ static void bdi_queue_work(struct backing_dev_info *bdi, struct bdi_work *work)
else { else {
struct bdi_writeback *wb = &bdi->wb; struct bdi_writeback *wb = &bdi->wb;
/* if (wb->task)
* End work now if this wb has no dirty IO pending. Otherwise
* wakeup the handling thread
*/
if (!wb_has_dirty_io(wb))
wb_clear_pending(wb, work);
else if (wb->task)
wake_up_process(wb->task); wake_up_process(wb->task);
} }
} }