adulau/aha
1
0
Fork 0
mirror of https://github.com/adulau/aha.git synced 2024-12-28 03:36:19 +00:00
Code Issues Projects Releases Packages Wiki Activity

signals: check ->group_stop_count after tracehook_get_signal()

Browse source 
Move the call to do_signal_stop() down, after tracehook call.  This makes
->group_stop_count condition visible to tracers before do_signal_stop()
will participate in this group-stop.

Currently the patch has no effect, tracehook_get_signal() always returns 0.

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Roland McGrath <roland@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Oleg Nesterov 2009-12-15 16:47:26 -08:00 committed by Linus Torvalds
parent ad09750b51
commit 1be53963b0
1 changed files with 4 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
kernel/signal.c
View file

@ -1840,11 +1840,6 @@ relock:
for (;;) { for (;;) {
struct k_sigaction *ka; struct k_sigaction *ka;
if (unlikely(signal->group_stop_count > 0) &&
do_signal_stop(0))
goto relock;
/* /*
* Tracing can induce an artifical signal and choose sigaction. * Tracing can induce an artifical signal and choose sigaction.
* The return value in @signr determines the default action, * The return value in @signr determines the default action,
@ -1856,6 +1851,10 @@ relock:
if (unlikely(signr != 0)) if (unlikely(signr != 0))
ka = return_ka; ka = return_ka;
else { else {
if (unlikely(signal->group_stop_count > 0) &&
do_signal_stop(0))
goto relock;
signr = dequeue_signal(current, &current->blocked, signr = dequeue_signal(current, &current->blocked,
info); info);