adulau/aha
1
0
Fork 0
mirror of https://github.com/adulau/aha.git synced 2024-12-28 19:56:18 +00:00
Code Issues Projects Releases Packages Wiki Activity

[PATCH] pid: Properly detect orphaned process groups in exit_notify

Browse source 
In commit 0475ac0845 when converting the
orphaned process group handling to use struct pid I made a small
mistake.  I accidentally replaced an == with a !=.

Besides just being a dumb thing to do apparently this has a bad side
effect.  The improper orphaned process group detection causes kwin to
die after a suspend/resume cycle.

I'm amazed this patch has been around as long as it has without anyone
else noticing something funny going on.

And the following people deserve credit for spotting and helping
to reproduce this.

Thanks to: Sid Boyce <g3vbv@blueyonder.co.uk>
Thanks to: "Michael Wu"

Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Eric W. Biederman 2007-03-28 23:38:16 -06:00 committed by Linus Torvalds
parent c97beb4710
commit 14e9d5730a
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
kernel/exit.c
View file

@ -790,7 +790,7 @@ static void exit_notify(struct task_struct *tsk)
pgrp = task_pgrp(tsk); pgrp = task_pgrp(tsk);
if ((task_pgrp(t) != pgrp) && if ((task_pgrp(t) != pgrp) &&
(task_session(t) != task_session(tsk)) && (task_session(t) == task_session(tsk)) &&
will_become_orphaned_pgrp(pgrp, tsk) && will_become_orphaned_pgrp(pgrp, tsk) &&
has_stopped_jobs(pgrp)) { has_stopped_jobs(pgrp)) {
__kill_pgrp_info(SIGHUP, SEND_SIG_PRIV, pgrp); __kill_pgrp_info(SIGHUP, SEND_SIG_PRIV, pgrp);