adulau/aha
1
0
Fork 0
mirror of https://github.com/adulau/aha.git synced 2024-12-27 19:26:25 +00:00
Code Issues Projects Releases Packages Wiki Activity

[PATCH] autofs3: Make sure all dentries refs are released before calling kill_anon_super()

Browse source 
Make sure all dentries refs are released before calling kill_anon_super()
so that the assumption that generic_shutdown_super() can completely destroy
the dentry tree for there will be no external references holds true.

What was being done in the put_super() superblock op, is now done in the
kill_sb() filesystem op instead, prior to calling kill_anon_super().

The call to shrink_dcache_sb() is removed as it is redundant since
shrink_dcache_for_umount() will now be called after the cleanup routine.

Signed-off-by: David Howells <dhowells@redhat.com>
Acked-by: Ian Kent <raven@themaw.net>
Cc: Andi Kleen <ak@suse.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
This commit is contained in:
David Howells 2006-10-19 23:28:36 -07:00 committed by Linus Torvalds
parent f2fbc6c2da
commit 0e7d73824e
4 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
fs/autofs/autofs_i.h
View file

@ -149,6 +149,7 @@ extern const struct file_operations autofs_root_operations;
/* Initializing function */ /* Initializing function */
int autofs_fill_super(struct super_block *, void *, int); int autofs_fill_super(struct super_block *, void *, int);
void autofs_kill_sb(struct super_block *sb);
/* Queue management functions */ /* Queue management functions */

1
fs/autofs/dirhash.c
View file

@ -246,5 +246,4 @@ void autofs_hash_nuke(struct autofs_sb_info *sbi)
kfree(ent); kfree(ent);
} }
} }
shrink_dcache_sb(sbi->sb);
} }

2
fs/autofs/init.c
View file

@ -24,7 +24,7 @@ static struct file_system_type autofs_fs_type = {
.owner = THIS_MODULE, .owner = THIS_MODULE,
.name = "autofs", .name = "autofs",
.get_sb = autofs_get_sb, .get_sb = autofs_get_sb,
.kill_sb = kill_anon_super, .kill_sb = autofs_kill_sb,
}; };
static int __init init_autofs_fs(void) static int __init init_autofs_fs(void)

4
fs/autofs/inode.c
View file

@ -20,7 +20,7 @@
#include "autofs_i.h" #include "autofs_i.h"
#include <linux/module.h> #include <linux/module.h>
static void autofs_put_super(struct super_block *sb) void autofs_kill_sb(struct super_block *sb)
{ {
struct autofs_sb_info *sbi = autofs_sbi(sb); struct autofs_sb_info *sbi = autofs_sbi(sb);
unsigned int n; unsigned int n;
@ -37,13 +37,13 @@ static void autofs_put_super(struct super_block *sb)
kfree(sb->s_fs_info); kfree(sb->s_fs_info);
DPRINTK(("autofs: shutting down\n")); DPRINTK(("autofs: shutting down\n"));
kill_anon_super(sb);
} }
static void autofs_read_inode(struct inode *inode); static void autofs_read_inode(struct inode *inode);
static struct super_operations autofs_sops = { static struct super_operations autofs_sops = {
.read_inode = autofs_read_inode, .read_inode = autofs_read_inode,
.put_super = autofs_put_super,
.statfs = simple_statfs, .statfs = simple_statfs,
}; };