adulau/aha
1
0
Fork 0
mirror of https://github.com/adulau/aha.git synced 2025-01-04 23:23:18 +00:00
Code Issues Projects Releases Packages Wiki Activity

s390: fix Oops when unloading module netiucv

Browse source 
don't remove an entry from iucv_connection_list in netiucv_exit().
netiucv_free_netdevice is called anyway, which takes care of entry
removal.

Signed-off-by: Ursula Braun <braunu@de.ibm.com>
Signed-off-by: Frank Pavlic <fpavlic@de.ibm.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
This commit is contained in:
Ursula Braun 2007-05-02 15:18:44 +02:00 committed by Jeff Garzik
parent 1f8bdae9ef
commit 0be4acec82
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
drivers/s390/net/netiucv.c
View file

@ -1862,12 +1862,14 @@ static void netiucv_remove_connection(struct iucv_connection *conn)
write_lock_bh(&iucv_connection_rwlock); write_lock_bh(&iucv_connection_rwlock);
list_del_init(&conn->list); list_del_init(&conn->list);
write_unlock_bh(&iucv_connection_rwlock); write_unlock_bh(&iucv_connection_rwlock);
fsm_deltimer(&conn->timer);
netiucv_purge_skb_queue(&conn->collect_queue);
if (conn->path) { if (conn->path) {
iucv_path_sever(conn->path, iucvMagic); iucv_path_sever(conn->path, iucvMagic);
kfree(conn->path); kfree(conn->path);
conn->path = NULL; conn->path = NULL;
} }
fsm_deltimer(&conn->timer); netiucv_purge_skb_queue(&conn->commit_queue);
kfree_fsm(conn->fsm); kfree_fsm(conn->fsm);
kfree_skb(conn->rx_buff); kfree_skb(conn->rx_buff);
kfree_skb(conn->tx_buff); kfree_skb(conn->tx_buff);
@ -2115,7 +2117,6 @@ static void __exit netiucv_exit(void)
while (!list_empty(&iucv_connection_list)) { while (!list_empty(&iucv_connection_list)) {
cp = list_entry(iucv_connection_list.next, cp = list_entry(iucv_connection_list.next,
struct iucv_connection, list); struct iucv_connection, list);
list_del(&cp->list);
ndev = cp->netdev; ndev = cp->netdev;
priv = netdev_priv(ndev); priv = netdev_priv(ndev);
dev = priv->dev; dev = priv->dev;