adulau/aha
1
0
Fork 0
mirror of https://github.com/adulau/aha.git synced 2024-12-28 03:36:19 +00:00
Code Issues Projects Releases Packages Wiki Activity

JFS: Remove defconfig ptr comparison to 0

Browse source 
Remove sparse warning: Using plain integer as NULL pointer

Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Dave Kleikamp <shaggy@linux.vnet.ibm.com>
This commit is contained in:
Joe Perches 2007-11-13 22:16:08 -06:00 committed by Dave Kleikamp
parent a7fe0ba7ee
commit 09aaa749f6
5 changed files with 15 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
fs/jfs/jfs_dtree.c
View file

@ -284,11 +284,11 @@ static struct dir_table_slot *find_index(struct inode *ip, u32 index,
release_metapage(*mp); release_metapage(*mp);
*mp = NULL; *mp = NULL;
} }
if (*mp == 0) { if (!(*mp)) {
*lblock = blkno; *lblock = blkno;
*mp = read_index_page(ip, blkno); *mp = read_index_page(ip, blkno);
} }
if (*mp == 0) { if (!(*mp)) {
jfs_err("free_index: error reading directory table"); jfs_err("free_index: error reading directory table");
return NULL; return NULL;
} }
@ -413,7 +413,8 @@ static u32 add_index(tid_t tid, struct inode *ip, s64 bn, int slot)
} }
ip->i_size = PSIZE; ip->i_size = PSIZE;
if ((mp = get_index_page(ip, 0)) == 0) { mp = get_index_page(ip, 0);
if (!mp) {
jfs_err("add_index: get_metapage failed!"); jfs_err("add_index: get_metapage failed!");
xtTruncate(tid, ip, 0, COMMIT_PWMAP); xtTruncate(tid, ip, 0, COMMIT_PWMAP);
memcpy(&jfs_ip->i_dirtable, temp_table, memcpy(&jfs_ip->i_dirtable, temp_table,
@ -461,7 +462,7 @@ static u32 add_index(tid_t tid, struct inode *ip, s64 bn, int slot)
} else } else
mp = read_index_page(ip, blkno); mp = read_index_page(ip, blkno);
if (mp == 0) { if (!mp) {
jfs_err("add_index: get/read_metapage failed!"); jfs_err("add_index: get/read_metapage failed!");
goto clean_up; goto clean_up;
} }
@ -499,7 +500,7 @@ static void free_index(tid_t tid, struct inode *ip, u32 index, u32 next)
dirtab_slot = find_index(ip, index, &mp, &lblock); dirtab_slot = find_index(ip, index, &mp, &lblock);
if (dirtab_slot == 0) if (!dirtab_slot)
return; return;
dirtab_slot->flag = DIR_INDEX_FREE; dirtab_slot->flag = DIR_INDEX_FREE;
@ -526,7 +527,7 @@ static void modify_index(tid_t tid, struct inode *ip, u32 index, s64 bn,
dirtab_slot = find_index(ip, index, mp, lblock); dirtab_slot = find_index(ip, index, mp, lblock);
if (dirtab_slot == 0) if (!dirtab_slot)
return; return;
DTSaddress(dirtab_slot, bn); DTSaddress(dirtab_slot, bn);
@ -552,7 +553,7 @@ static int read_index(struct inode *ip, u32 index,
struct dir_table_slot *slot; struct dir_table_slot *slot;
slot = find_index(ip, index, &mp, &lblock); slot = find_index(ip, index, &mp, &lblock);
if (slot == 0) { if (!slot) {
return -EIO; return -EIO;
} }
@ -593,7 +594,7 @@ int dtSearch(struct inode *ip, struct component_name * key, ino_t * data,
struct super_block *sb = ip->i_sb; struct super_block *sb = ip->i_sb;
ciKey.name = kmalloc((JFS_NAME_MAX + 1) * sizeof(wchar_t), GFP_NOFS); ciKey.name = kmalloc((JFS_NAME_MAX + 1) * sizeof(wchar_t), GFP_NOFS);
if (ciKey.name == 0) { if (!ciKey.name) {
rc = -ENOMEM; rc = -ENOMEM;
goto dtSearch_Exit2; goto dtSearch_Exit2;
} }
@ -956,7 +957,7 @@ static int dtSplitUp(tid_t tid,
sp = DT_PAGE(ip, smp); sp = DT_PAGE(ip, smp);
key.name = kmalloc((JFS_NAME_MAX + 2) * sizeof(wchar_t), GFP_NOFS); key.name = kmalloc((JFS_NAME_MAX + 2) * sizeof(wchar_t), GFP_NOFS);
if (key.name == 0) { if (!key.name) {
DT_PUTPAGE(smp); DT_PUTPAGE(smp);
rc = -ENOMEM; rc = -ENOMEM;
goto dtSplitUp_Exit; goto dtSplitUp_Exit;

4
fs/jfs/jfs_imap.c
View file

@ -381,7 +381,7 @@ int diRead(struct inode *ip)
/* read the page of disk inode */ /* read the page of disk inode */
mp = read_metapage(ipimap, pageno << sbi->l2nbperpage, PSIZE, 1); mp = read_metapage(ipimap, pageno << sbi->l2nbperpage, PSIZE, 1);
if (mp == 0) { if (!mp) {
jfs_err("diRead: read_metapage failed"); jfs_err("diRead: read_metapage failed");
return -EIO; return -EIO;
} }
@ -654,7 +654,7 @@ int diWrite(tid_t tid, struct inode *ip)
/* read the page of disk inode */ /* read the page of disk inode */
retry: retry:
mp = read_metapage(ipimap, pageno << sbi->l2nbperpage, PSIZE, 1); mp = read_metapage(ipimap, pageno << sbi->l2nbperpage, PSIZE, 1);
if (mp == 0) if (!mp)
return -EIO; return -EIO;
/* get the pointer to the disk inode */ /* get the pointer to the disk inode */

2
fs/jfs/jfs_logmgr.c
View file

@ -2345,7 +2345,7 @@ int jfsIOWait(void *arg)
do { do {
spin_lock_irq(&log_redrive_lock); spin_lock_irq(&log_redrive_lock);
while ((bp = log_redrive_list) != 0) { while ((bp = log_redrive_list)) {
log_redrive_list = bp->l_redrive_next; log_redrive_list = bp->l_redrive_next;
bp->l_redrive_next = NULL; bp->l_redrive_next = NULL;
spin_unlock_irq(&log_redrive_lock); spin_unlock_irq(&log_redrive_lock);

2
fs/jfs/jfs_mount.c
View file

@ -147,7 +147,7 @@ int jfs_mount(struct super_block *sb)
*/ */
if ((sbi->mntflag & JFS_BAD_SAIT) == 0) { if ((sbi->mntflag & JFS_BAD_SAIT) == 0) {
ipaimap2 = diReadSpecial(sb, AGGREGATE_I, 1); ipaimap2 = diReadSpecial(sb, AGGREGATE_I, 1);
if (ipaimap2 == 0) { if (!ipaimap2) {
jfs_err("jfs_mount: Faild to read AGGREGATE_I"); jfs_err("jfs_mount: Faild to read AGGREGATE_I");
rc = -EIO; rc = -EIO;
goto errout35; goto errout35;

2
fs/jfs/namei.c
View file

@ -1103,7 +1103,7 @@ static int jfs_rename(struct inode *old_dir, struct dentry *old_dentry,
* Make sure dest inode number (if any) is what we think it is * Make sure dest inode number (if any) is what we think it is
*/ */
rc = dtSearch(new_dir, &new_dname, &ino, &btstack, JFS_LOOKUP); rc = dtSearch(new_dir, &new_dname, &ino, &btstack, JFS_LOOKUP);
if (rc == 0) { if (!rc) {
if ((new_ip == 0) || (ino != new_ip->i_ino)) { if ((new_ip == 0) || (ino != new_ip->i_ino)) {
rc = -ESTALE; rc = -ESTALE;
goto out3; goto out3;