adulau/aha
1
0
Fork 0
mirror of https://github.com/adulau/aha.git synced 2024-12-28 11:46:19 +00:00
Code Issues Projects Releases Packages Wiki Activity

dmaengine: kill tx_list

Browse source 
The tx_list attribute of struct dma_async_tx_descriptor is common to
most, but not all dma driver implementations.  None of the upper level
code (dmaengine/async_tx) uses it, so allow drivers to implement it
locally if they need it.  This saves sizeof(struct list_head) bytes for
drivers that do not manage descriptors with a linked list (e.g.: ioatdma
v2,3).

Signed-off-by: Dan Williams <dan.j.williams@intel.com>
This commit is contained in:
Dan Williams 2009-09-08 17:53:04 -07:00
parent 1979b186b8
commit 0803172778
2 changed files with 0 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
drivers/dma/dmaengine.c
View file

@ -933,7 +933,6 @@ void dma_async_tx_descriptor_init(struct dma_async_tx_descriptor *tx,
{ {
tx->chan = chan; tx->chan = chan;
spin_lock_init(&tx->lock); spin_lock_init(&tx->lock);
INIT_LIST_HEAD(&tx->tx_list);
} }
EXPORT_SYMBOL(dma_async_tx_descriptor_init); EXPORT_SYMBOL(dma_async_tx_descriptor_init);

3
include/linux/dmaengine.h
View file

@ -180,8 +180,6 @@ typedef void (*dma_async_tx_callback)(void *dma_async_param);
* @flags: flags to augment operation preparation, control completion, and * @flags: flags to augment operation preparation, control completion, and
* communicate status * communicate status
* @phys: physical address of the descriptor * @phys: physical address of the descriptor
* @tx_list: driver common field for operations that require multiple
* descriptors
* @chan: target channel for this operation * @chan: target channel for this operation
* @tx_submit: set the prepared descriptor(s) to be executed by the engine * @tx_submit: set the prepared descriptor(s) to be executed by the engine
* @callback: routine to call after this operation is complete * @callback: routine to call after this operation is complete
@ -195,7 +193,6 @@ struct dma_async_tx_descriptor {
dma_cookie_t cookie; dma_cookie_t cookie;
enum dma_ctrl_flags flags; /* not a 'long' to pack with cookie */ enum dma_ctrl_flags flags; /* not a 'long' to pack with cookie */
dma_addr_t phys; dma_addr_t phys;
struct list_head tx_list;
struct dma_chan *chan; struct dma_chan *chan;
dma_cookie_t (*tx_submit)(struct dma_async_tx_descriptor *tx); dma_cookie_t (*tx_submit)(struct dma_async_tx_descriptor *tx);
dma_async_tx_callback callback; dma_async_tx_callback callback;