sched: Convert rq->lock to raw_spinlock

Convert locks which cannot be sleeping locks in preempt-rt to
raw_spinlocks.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Peter Zijlstra <peterz@infradead.org>
Acked-by: Ingo Molnar <mingo@elte.hu>
This commit is contained in:
Thomas Gleixner 2009-11-17 14:28:38 +01:00
parent a26724591e
commit 05fa785cf8
5 changed files with 106 additions and 103 deletions

View file

@ -525,7 +525,7 @@ static struct root_domain def_root_domain;
*/ */
struct rq { struct rq {
/* runqueue lock: */ /* runqueue lock: */
spinlock_t lock; raw_spinlock_t lock;
/* /*
* nr_running and cpu_load should be in the same cacheline because * nr_running and cpu_load should be in the same cacheline because
@ -685,7 +685,7 @@ inline void update_rq_clock(struct rq *rq)
*/ */
int runqueue_is_locked(int cpu) int runqueue_is_locked(int cpu)
{ {
return spin_is_locked(&cpu_rq(cpu)->lock); return raw_spin_is_locked(&cpu_rq(cpu)->lock);
} }
/* /*
@ -884,7 +884,7 @@ static inline void finish_lock_switch(struct rq *rq, struct task_struct *prev)
{ {
#ifdef CONFIG_DEBUG_SPINLOCK #ifdef CONFIG_DEBUG_SPINLOCK
/* this is a valid case when another task releases the spinlock */ /* this is a valid case when another task releases the spinlock */
rq->lock.rlock.owner = current; rq->lock.owner = current;
#endif #endif
/* /*
* If we are tracking spinlock dependencies then we have to * If we are tracking spinlock dependencies then we have to
@ -893,7 +893,7 @@ static inline void finish_lock_switch(struct rq *rq, struct task_struct *prev)
*/ */
spin_acquire(&rq->lock.dep_map, 0, 0, _THIS_IP_); spin_acquire(&rq->lock.dep_map, 0, 0, _THIS_IP_);
spin_unlock_irq(&rq->lock); raw_spin_unlock_irq(&rq->lock);
} }
#else /* __ARCH_WANT_UNLOCKED_CTXSW */ #else /* __ARCH_WANT_UNLOCKED_CTXSW */
@ -917,9 +917,9 @@ static inline void prepare_lock_switch(struct rq *rq, struct task_struct *next)
next->oncpu = 1; next->oncpu = 1;
#endif #endif
#ifdef __ARCH_WANT_INTERRUPTS_ON_CTXSW #ifdef __ARCH_WANT_INTERRUPTS_ON_CTXSW
spin_unlock_irq(&rq->lock); raw_spin_unlock_irq(&rq->lock);
#else #else
spin_unlock(&rq->lock); raw_spin_unlock(&rq->lock);
#endif #endif
} }
@ -949,10 +949,10 @@ static inline struct rq *__task_rq_lock(struct task_struct *p)
{ {
for (;;) { for (;;) {
struct rq *rq = task_rq(p); struct rq *rq = task_rq(p);
spin_lock(&rq->lock); raw_spin_lock(&rq->lock);
if (likely(rq == task_rq(p))) if (likely(rq == task_rq(p)))
return rq; return rq;
spin_unlock(&rq->lock); raw_spin_unlock(&rq->lock);
} }
} }
@ -969,10 +969,10 @@ static struct rq *task_rq_lock(struct task_struct *p, unsigned long *flags)
for (;;) { for (;;) {
local_irq_save(*flags); local_irq_save(*flags);
rq = task_rq(p); rq = task_rq(p);
spin_lock(&rq->lock); raw_spin_lock(&rq->lock);
if (likely(rq == task_rq(p))) if (likely(rq == task_rq(p)))
return rq; return rq;
spin_unlock_irqrestore(&rq->lock, *flags); raw_spin_unlock_irqrestore(&rq->lock, *flags);
} }
} }
@ -981,19 +981,19 @@ void task_rq_unlock_wait(struct task_struct *p)
struct rq *rq = task_rq(p); struct rq *rq = task_rq(p);
smp_mb(); /* spin-unlock-wait is not a full memory barrier */ smp_mb(); /* spin-unlock-wait is not a full memory barrier */
spin_unlock_wait(&rq->lock); raw_spin_unlock_wait(&rq->lock);
} }
static void __task_rq_unlock(struct rq *rq) static void __task_rq_unlock(struct rq *rq)
__releases(rq->lock) __releases(rq->lock)
{ {
spin_unlock(&rq->lock); raw_spin_unlock(&rq->lock);
} }
static inline void task_rq_unlock(struct rq *rq, unsigned long *flags) static inline void task_rq_unlock(struct rq *rq, unsigned long *flags)
__releases(rq->lock) __releases(rq->lock)
{ {
spin_unlock_irqrestore(&rq->lock, *flags); raw_spin_unlock_irqrestore(&rq->lock, *flags);
} }
/* /*
@ -1006,7 +1006,7 @@ static struct rq *this_rq_lock(void)
local_irq_disable(); local_irq_disable();
rq = this_rq(); rq = this_rq();
spin_lock(&rq->lock); raw_spin_lock(&rq->lock);
return rq; return rq;
} }
@ -1053,10 +1053,10 @@ static enum hrtimer_restart hrtick(struct hrtimer *timer)
WARN_ON_ONCE(cpu_of(rq) != smp_processor_id()); WARN_ON_ONCE(cpu_of(rq) != smp_processor_id());
spin_lock(&rq->lock); raw_spin_lock(&rq->lock);
update_rq_clock(rq); update_rq_clock(rq);
rq->curr->sched_class->task_tick(rq, rq->curr, 1); rq->curr->sched_class->task_tick(rq, rq->curr, 1);
spin_unlock(&rq->lock); raw_spin_unlock(&rq->lock);
return HRTIMER_NORESTART; return HRTIMER_NORESTART;
} }
@ -1069,10 +1069,10 @@ static void __hrtick_start(void *arg)
{ {
struct rq *rq = arg; struct rq *rq = arg;
spin_lock(&rq->lock); raw_spin_lock(&rq->lock);
hrtimer_restart(&rq->hrtick_timer); hrtimer_restart(&rq->hrtick_timer);
rq->hrtick_csd_pending = 0; rq->hrtick_csd_pending = 0;
spin_unlock(&rq->lock); raw_spin_unlock(&rq->lock);
} }
/* /*
@ -1179,7 +1179,7 @@ static void resched_task(struct task_struct *p)
{ {
int cpu; int cpu;
assert_spin_locked(&task_rq(p)->lock); assert_raw_spin_locked(&task_rq(p)->lock);
if (test_tsk_need_resched(p)) if (test_tsk_need_resched(p))
return; return;
@ -1201,10 +1201,10 @@ static void resched_cpu(int cpu)
struct rq *rq = cpu_rq(cpu); struct rq *rq = cpu_rq(cpu);
unsigned long flags; unsigned long flags;
if (!spin_trylock_irqsave(&rq->lock, flags)) if (!raw_spin_trylock_irqsave(&rq->lock, flags))
return; return;
resched_task(cpu_curr(cpu)); resched_task(cpu_curr(cpu));
spin_unlock_irqrestore(&rq->lock, flags); raw_spin_unlock_irqrestore(&rq->lock, flags);
} }
#ifdef CONFIG_NO_HZ #ifdef CONFIG_NO_HZ
@ -1273,7 +1273,7 @@ static void sched_rt_avg_update(struct rq *rq, u64 rt_delta)
#else /* !CONFIG_SMP */ #else /* !CONFIG_SMP */
static void resched_task(struct task_struct *p) static void resched_task(struct task_struct *p)
{ {
assert_spin_locked(&task_rq(p)->lock); assert_raw_spin_locked(&task_rq(p)->lock);
set_tsk_need_resched(p); set_tsk_need_resched(p);
} }
@ -1600,11 +1600,11 @@ static void update_group_shares_cpu(struct task_group *tg, int cpu,
struct rq *rq = cpu_rq(cpu); struct rq *rq = cpu_rq(cpu);
unsigned long flags; unsigned long flags;
spin_lock_irqsave(&rq->lock, flags); raw_spin_lock_irqsave(&rq->lock, flags);
tg->cfs_rq[cpu]->rq_weight = boost ? 0 : rq_weight; tg->cfs_rq[cpu]->rq_weight = boost ? 0 : rq_weight;
tg->cfs_rq[cpu]->shares = boost ? 0 : shares; tg->cfs_rq[cpu]->shares = boost ? 0 : shares;
__set_se_shares(tg->se[cpu], shares); __set_se_shares(tg->se[cpu], shares);
spin_unlock_irqrestore(&rq->lock, flags); raw_spin_unlock_irqrestore(&rq->lock, flags);
} }
} }
@ -1706,9 +1706,9 @@ static void update_shares_locked(struct rq *rq, struct sched_domain *sd)
if (root_task_group_empty()) if (root_task_group_empty())
return; return;
spin_unlock(&rq->lock); raw_spin_unlock(&rq->lock);
update_shares(sd); update_shares(sd);
spin_lock(&rq->lock); raw_spin_lock(&rq->lock);
} }
static void update_h_load(long cpu) static void update_h_load(long cpu)
@ -1748,7 +1748,7 @@ static inline int _double_lock_balance(struct rq *this_rq, struct rq *busiest)
__acquires(busiest->lock) __acquires(busiest->lock)
__acquires(this_rq->lock) __acquires(this_rq->lock)
{ {
spin_unlock(&this_rq->lock); raw_spin_unlock(&this_rq->lock);
double_rq_lock(this_rq, busiest); double_rq_lock(this_rq, busiest);
return 1; return 1;
@ -1769,14 +1769,16 @@ static int _double_lock_balance(struct rq *this_rq, struct rq *busiest)
{ {
int ret = 0; int ret = 0;
if (unlikely(!spin_trylock(&busiest->lock))) { if (unlikely(!raw_spin_trylock(&busiest->lock))) {
if (busiest < this_rq) { if (busiest < this_rq) {
spin_unlock(&this_rq->lock); raw_spin_unlock(&this_rq->lock);
spin_lock(&busiest->lock); raw_spin_lock(&busiest->lock);
spin_lock_nested(&this_rq->lock, SINGLE_DEPTH_NESTING); raw_spin_lock_nested(&this_rq->lock,
SINGLE_DEPTH_NESTING);
ret = 1; ret = 1;
} else } else
spin_lock_nested(&busiest->lock, SINGLE_DEPTH_NESTING); raw_spin_lock_nested(&busiest->lock,
SINGLE_DEPTH_NESTING);
} }
return ret; return ret;
} }
@ -1790,7 +1792,7 @@ static int double_lock_balance(struct rq *this_rq, struct rq *busiest)
{ {
if (unlikely(!irqs_disabled())) { if (unlikely(!irqs_disabled())) {
/* printk() doesn't work good under rq->lock */ /* printk() doesn't work good under rq->lock */
spin_unlock(&this_rq->lock); raw_spin_unlock(&this_rq->lock);
BUG_ON(1); BUG_ON(1);
} }
@ -1800,7 +1802,7 @@ static int double_lock_balance(struct rq *this_rq, struct rq *busiest)
static inline void double_unlock_balance(struct rq *this_rq, struct rq *busiest) static inline void double_unlock_balance(struct rq *this_rq, struct rq *busiest)
__releases(busiest->lock) __releases(busiest->lock)
{ {
spin_unlock(&busiest->lock); raw_spin_unlock(&busiest->lock);
lock_set_subclass(&this_rq->lock.dep_map, 0, _RET_IP_); lock_set_subclass(&this_rq->lock.dep_map, 0, _RET_IP_);
} }
#endif #endif
@ -2023,13 +2025,13 @@ void kthread_bind(struct task_struct *p, unsigned int cpu)
return; return;
} }
spin_lock_irqsave(&rq->lock, flags); raw_spin_lock_irqsave(&rq->lock, flags);
update_rq_clock(rq); update_rq_clock(rq);
set_task_cpu(p, cpu); set_task_cpu(p, cpu);
p->cpus_allowed = cpumask_of_cpu(cpu); p->cpus_allowed = cpumask_of_cpu(cpu);
p->rt.nr_cpus_allowed = 1; p->rt.nr_cpus_allowed = 1;
p->flags |= PF_THREAD_BOUND; p->flags |= PF_THREAD_BOUND;
spin_unlock_irqrestore(&rq->lock, flags); raw_spin_unlock_irqrestore(&rq->lock, flags);
} }
EXPORT_SYMBOL(kthread_bind); EXPORT_SYMBOL(kthread_bind);
@ -2781,10 +2783,10 @@ static inline void post_schedule(struct rq *rq)
if (rq->post_schedule) { if (rq->post_schedule) {
unsigned long flags; unsigned long flags;
spin_lock_irqsave(&rq->lock, flags); raw_spin_lock_irqsave(&rq->lock, flags);
if (rq->curr->sched_class->post_schedule) if (rq->curr->sched_class->post_schedule)
rq->curr->sched_class->post_schedule(rq); rq->curr->sched_class->post_schedule(rq);
spin_unlock_irqrestore(&rq->lock, flags); raw_spin_unlock_irqrestore(&rq->lock, flags);
rq->post_schedule = 0; rq->post_schedule = 0;
} }
@ -3066,15 +3068,15 @@ static void double_rq_lock(struct rq *rq1, struct rq *rq2)
{ {
BUG_ON(!irqs_disabled()); BUG_ON(!irqs_disabled());
if (rq1 == rq2) { if (rq1 == rq2) {
spin_lock(&rq1->lock); raw_spin_lock(&rq1->lock);
__acquire(rq2->lock); /* Fake it out ;) */ __acquire(rq2->lock); /* Fake it out ;) */
} else { } else {
if (rq1 < rq2) { if (rq1 < rq2) {
spin_lock(&rq1->lock); raw_spin_lock(&rq1->lock);
spin_lock_nested(&rq2->lock, SINGLE_DEPTH_NESTING); raw_spin_lock_nested(&rq2->lock, SINGLE_DEPTH_NESTING);
} else { } else {
spin_lock(&rq2->lock); raw_spin_lock(&rq2->lock);
spin_lock_nested(&rq1->lock, SINGLE_DEPTH_NESTING); raw_spin_lock_nested(&rq1->lock, SINGLE_DEPTH_NESTING);
} }
} }
update_rq_clock(rq1); update_rq_clock(rq1);
@ -3091,9 +3093,9 @@ static void double_rq_unlock(struct rq *rq1, struct rq *rq2)
__releases(rq1->lock) __releases(rq1->lock)
__releases(rq2->lock) __releases(rq2->lock)
{ {
spin_unlock(&rq1->lock); raw_spin_unlock(&rq1->lock);
if (rq1 != rq2) if (rq1 != rq2)
spin_unlock(&rq2->lock); raw_spin_unlock(&rq2->lock);
else else
__release(rq2->lock); __release(rq2->lock);
} }
@ -4186,14 +4188,15 @@ redo:
if (unlikely(sd->nr_balance_failed > sd->cache_nice_tries+2)) { if (unlikely(sd->nr_balance_failed > sd->cache_nice_tries+2)) {
spin_lock_irqsave(&busiest->lock, flags); raw_spin_lock_irqsave(&busiest->lock, flags);
/* don't kick the migration_thread, if the curr /* don't kick the migration_thread, if the curr
* task on busiest cpu can't be moved to this_cpu * task on busiest cpu can't be moved to this_cpu
*/ */
if (!cpumask_test_cpu(this_cpu, if (!cpumask_test_cpu(this_cpu,
&busiest->curr->cpus_allowed)) { &busiest->curr->cpus_allowed)) {
spin_unlock_irqrestore(&busiest->lock, flags); raw_spin_unlock_irqrestore(&busiest->lock,
flags);
all_pinned = 1; all_pinned = 1;
goto out_one_pinned; goto out_one_pinned;
} }
@ -4203,7 +4206,7 @@ redo:
busiest->push_cpu = this_cpu; busiest->push_cpu = this_cpu;
active_balance = 1; active_balance = 1;
} }
spin_unlock_irqrestore(&busiest->lock, flags); raw_spin_unlock_irqrestore(&busiest->lock, flags);
if (active_balance) if (active_balance)
wake_up_process(busiest->migration_thread); wake_up_process(busiest->migration_thread);
@ -4385,10 +4388,10 @@ redo:
/* /*
* Should not call ttwu while holding a rq->lock * Should not call ttwu while holding a rq->lock
*/ */
spin_unlock(&this_rq->lock); raw_spin_unlock(&this_rq->lock);
if (active_balance) if (active_balance)
wake_up_process(busiest->migration_thread); wake_up_process(busiest->migration_thread);
spin_lock(&this_rq->lock); raw_spin_lock(&this_rq->lock);
} else } else
sd->nr_balance_failed = 0; sd->nr_balance_failed = 0;
@ -5257,11 +5260,11 @@ void scheduler_tick(void)
sched_clock_tick(); sched_clock_tick();
spin_lock(&rq->lock); raw_spin_lock(&rq->lock);
update_rq_clock(rq); update_rq_clock(rq);
update_cpu_load(rq); update_cpu_load(rq);
curr->sched_class->task_tick(rq, curr, 0); curr->sched_class->task_tick(rq, curr, 0);
spin_unlock(&rq->lock); raw_spin_unlock(&rq->lock);
perf_event_task_tick(curr, cpu); perf_event_task_tick(curr, cpu);
@ -5455,7 +5458,7 @@ need_resched_nonpreemptible:
if (sched_feat(HRTICK)) if (sched_feat(HRTICK))
hrtick_clear(rq); hrtick_clear(rq);
spin_lock_irq(&rq->lock); raw_spin_lock_irq(&rq->lock);
update_rq_clock(rq); update_rq_clock(rq);
clear_tsk_need_resched(prev); clear_tsk_need_resched(prev);
@ -5491,7 +5494,7 @@ need_resched_nonpreemptible:
cpu = smp_processor_id(); cpu = smp_processor_id();
rq = cpu_rq(cpu); rq = cpu_rq(cpu);
} else } else
spin_unlock_irq(&rq->lock); raw_spin_unlock_irq(&rq->lock);
post_schedule(rq); post_schedule(rq);
@ -6980,7 +6983,7 @@ void __cpuinit init_idle(struct task_struct *idle, int cpu)
struct rq *rq = cpu_rq(cpu); struct rq *rq = cpu_rq(cpu);
unsigned long flags; unsigned long flags;
spin_lock_irqsave(&rq->lock, flags); raw_spin_lock_irqsave(&rq->lock, flags);
__sched_fork(idle); __sched_fork(idle);
idle->se.exec_start = sched_clock(); idle->se.exec_start = sched_clock();
@ -6992,7 +6995,7 @@ void __cpuinit init_idle(struct task_struct *idle, int cpu)
#if defined(CONFIG_SMP) && defined(__ARCH_WANT_UNLOCKED_CTXSW) #if defined(CONFIG_SMP) && defined(__ARCH_WANT_UNLOCKED_CTXSW)
idle->oncpu = 1; idle->oncpu = 1;
#endif #endif
spin_unlock_irqrestore(&rq->lock, flags); raw_spin_unlock_irqrestore(&rq->lock, flags);
/* Set the preempt count _outside_ the spinlocks! */ /* Set the preempt count _outside_ the spinlocks! */
#if defined(CONFIG_PREEMPT) #if defined(CONFIG_PREEMPT)
@ -7209,10 +7212,10 @@ static int migration_thread(void *data)
struct migration_req *req; struct migration_req *req;
struct list_head *head; struct list_head *head;
spin_lock_irq(&rq->lock); raw_spin_lock_irq(&rq->lock);
if (cpu_is_offline(cpu)) { if (cpu_is_offline(cpu)) {
spin_unlock_irq(&rq->lock); raw_spin_unlock_irq(&rq->lock);
break; break;
} }
@ -7224,7 +7227,7 @@ static int migration_thread(void *data)
head = &rq->migration_queue; head = &rq->migration_queue;
if (list_empty(head)) { if (list_empty(head)) {
spin_unlock_irq(&rq->lock); raw_spin_unlock_irq(&rq->lock);
schedule(); schedule();
set_current_state(TASK_INTERRUPTIBLE); set_current_state(TASK_INTERRUPTIBLE);
continue; continue;
@ -7233,14 +7236,14 @@ static int migration_thread(void *data)
list_del_init(head->next); list_del_init(head->next);
if (req->task != NULL) { if (req->task != NULL) {
spin_unlock(&rq->lock); raw_spin_unlock(&rq->lock);
__migrate_task(req->task, cpu, req->dest_cpu); __migrate_task(req->task, cpu, req->dest_cpu);
} else if (likely(cpu == (badcpu = smp_processor_id()))) { } else if (likely(cpu == (badcpu = smp_processor_id()))) {
req->dest_cpu = RCU_MIGRATION_GOT_QS; req->dest_cpu = RCU_MIGRATION_GOT_QS;
spin_unlock(&rq->lock); raw_spin_unlock(&rq->lock);
} else { } else {
req->dest_cpu = RCU_MIGRATION_MUST_SYNC; req->dest_cpu = RCU_MIGRATION_MUST_SYNC;
spin_unlock(&rq->lock); raw_spin_unlock(&rq->lock);
WARN_ONCE(1, "migration_thread() on CPU %d, expected %d\n", badcpu, cpu); WARN_ONCE(1, "migration_thread() on CPU %d, expected %d\n", badcpu, cpu);
} }
local_irq_enable(); local_irq_enable();
@ -7363,14 +7366,14 @@ void sched_idle_next(void)
* Strictly not necessary since rest of the CPUs are stopped by now * Strictly not necessary since rest of the CPUs are stopped by now
* and interrupts disabled on the current cpu. * and interrupts disabled on the current cpu.
*/ */
spin_lock_irqsave(&rq->lock, flags); raw_spin_lock_irqsave(&rq->lock, flags);
__setscheduler(rq, p, SCHED_FIFO, MAX_RT_PRIO-1); __setscheduler(rq, p, SCHED_FIFO, MAX_RT_PRIO-1);
update_rq_clock(rq); update_rq_clock(rq);
activate_task(rq, p, 0); activate_task(rq, p, 0);
spin_unlock_irqrestore(&rq->lock, flags); raw_spin_unlock_irqrestore(&rq->lock, flags);
} }
/* /*
@ -7406,9 +7409,9 @@ static void migrate_dead(unsigned int dead_cpu, struct task_struct *p)
* that's OK. No task can be added to this CPU, so iteration is * that's OK. No task can be added to this CPU, so iteration is
* fine. * fine.
*/ */
spin_unlock_irq(&rq->lock); raw_spin_unlock_irq(&rq->lock);
move_task_off_dead_cpu(dead_cpu, p); move_task_off_dead_cpu(dead_cpu, p);
spin_lock_irq(&rq->lock); raw_spin_lock_irq(&rq->lock);
put_task_struct(p); put_task_struct(p);
} }
@ -7674,13 +7677,13 @@ migration_call(struct notifier_block *nfb, unsigned long action, void *hcpu)
/* Update our root-domain */ /* Update our root-domain */
rq = cpu_rq(cpu); rq = cpu_rq(cpu);
spin_lock_irqsave(&rq->lock, flags); raw_spin_lock_irqsave(&rq->lock, flags);
if (rq->rd) { if (rq->rd) {
BUG_ON(!cpumask_test_cpu(cpu, rq->rd->span)); BUG_ON(!cpumask_test_cpu(cpu, rq->rd->span));
set_rq_online(rq); set_rq_online(rq);
} }
spin_unlock_irqrestore(&rq->lock, flags); raw_spin_unlock_irqrestore(&rq->lock, flags);
break; break;
#ifdef CONFIG_HOTPLUG_CPU #ifdef CONFIG_HOTPLUG_CPU
@ -7705,13 +7708,13 @@ migration_call(struct notifier_block *nfb, unsigned long action, void *hcpu)
put_task_struct(rq->migration_thread); put_task_struct(rq->migration_thread);
rq->migration_thread = NULL; rq->migration_thread = NULL;
/* Idle task back to normal (off runqueue, low prio) */ /* Idle task back to normal (off runqueue, low prio) */
spin_lock_irq(&rq->lock); raw_spin_lock_irq(&rq->lock);
update_rq_clock(rq); update_rq_clock(rq);
deactivate_task(rq, rq->idle, 0); deactivate_task(rq, rq->idle, 0);
__setscheduler(rq, rq->idle, SCHED_NORMAL, 0); __setscheduler(rq, rq->idle, SCHED_NORMAL, 0);
rq->idle->sched_class = &idle_sched_class; rq->idle->sched_class = &idle_sched_class;
migrate_dead_tasks(cpu); migrate_dead_tasks(cpu);
spin_unlock_irq(&rq->lock); raw_spin_unlock_irq(&rq->lock);
cpuset_unlock(); cpuset_unlock();
migrate_nr_uninterruptible(rq); migrate_nr_uninterruptible(rq);
BUG_ON(rq->nr_running != 0); BUG_ON(rq->nr_running != 0);
@ -7721,30 +7724,30 @@ migration_call(struct notifier_block *nfb, unsigned long action, void *hcpu)
* they didn't take sched_hotcpu_mutex. Just wake up * they didn't take sched_hotcpu_mutex. Just wake up
* the requestors. * the requestors.
*/ */
spin_lock_irq(&rq->lock); raw_spin_lock_irq(&rq->lock);
while (!list_empty(&rq->migration_queue)) { while (!list_empty(&rq->migration_queue)) {
struct migration_req *req; struct migration_req *req;
req = list_entry(rq->migration_queue.next, req = list_entry(rq->migration_queue.next,
struct migration_req, list); struct migration_req, list);
list_del_init(&req->list); list_del_init(&req->list);
spin_unlock_irq(&rq->lock); raw_spin_unlock_irq(&rq->lock);
complete(&req->done); complete(&req->done);
spin_lock_irq(&rq->lock); raw_spin_lock_irq(&rq->lock);
} }
spin_unlock_irq(&rq->lock); raw_spin_unlock_irq(&rq->lock);
break; break;
case CPU_DYING: case CPU_DYING:
case CPU_DYING_FROZEN: case CPU_DYING_FROZEN:
/* Update our root-domain */ /* Update our root-domain */
rq = cpu_rq(cpu); rq = cpu_rq(cpu);
spin_lock_irqsave(&rq->lock, flags); raw_spin_lock_irqsave(&rq->lock, flags);
if (rq->rd) { if (rq->rd) {
BUG_ON(!cpumask_test_cpu(cpu, rq->rd->span)); BUG_ON(!cpumask_test_cpu(cpu, rq->rd->span));
set_rq_offline(rq); set_rq_offline(rq);
} }
spin_unlock_irqrestore(&rq->lock, flags); raw_spin_unlock_irqrestore(&rq->lock, flags);
break; break;
#endif #endif
} }
@ -7974,7 +7977,7 @@ static void rq_attach_root(struct rq *rq, struct root_domain *rd)
struct root_domain *old_rd = NULL; struct root_domain *old_rd = NULL;
unsigned long flags; unsigned long flags;
spin_lock_irqsave(&rq->lock, flags); raw_spin_lock_irqsave(&rq->lock, flags);
if (rq->rd) { if (rq->rd) {
old_rd = rq->rd; old_rd = rq->rd;
@ -8000,7 +8003,7 @@ static void rq_attach_root(struct rq *rq, struct root_domain *rd)
if (cpumask_test_cpu(rq->cpu, cpu_active_mask)) if (cpumask_test_cpu(rq->cpu, cpu_active_mask))
set_rq_online(rq); set_rq_online(rq);
spin_unlock_irqrestore(&rq->lock, flags); raw_spin_unlock_irqrestore(&rq->lock, flags);
if (old_rd) if (old_rd)
free_rootdomain(old_rd); free_rootdomain(old_rd);
@ -9357,7 +9360,7 @@ static void init_rt_rq(struct rt_rq *rt_rq, struct rq *rq)
#ifdef CONFIG_SMP #ifdef CONFIG_SMP
rt_rq->rt_nr_migratory = 0; rt_rq->rt_nr_migratory = 0;
rt_rq->overloaded = 0; rt_rq->overloaded = 0;
plist_head_init(&rt_rq->pushable_tasks, &rq->lock); plist_head_init_raw(&rt_rq->pushable_tasks, &rq->lock);
#endif #endif
rt_rq->rt_time = 0; rt_rq->rt_time = 0;
@ -9523,7 +9526,7 @@ void __init sched_init(void)
struct rq *rq; struct rq *rq;
rq = cpu_rq(i); rq = cpu_rq(i);
spin_lock_init(&rq->lock); raw_spin_lock_init(&rq->lock);
rq->nr_running = 0; rq->nr_running = 0;
rq->calc_load_active = 0; rq->calc_load_active = 0;
rq->calc_load_update = jiffies + LOAD_FREQ; rq->calc_load_update = jiffies + LOAD_FREQ;
@ -10115,9 +10118,9 @@ static void set_se_shares(struct sched_entity *se, unsigned long shares)
struct rq *rq = cfs_rq->rq; struct rq *rq = cfs_rq->rq;
unsigned long flags; unsigned long flags;
spin_lock_irqsave(&rq->lock, flags); raw_spin_lock_irqsave(&rq->lock, flags);
__set_se_shares(se, shares); __set_se_shares(se, shares);
spin_unlock_irqrestore(&rq->lock, flags); raw_spin_unlock_irqrestore(&rq->lock, flags);
} }
static DEFINE_MUTEX(shares_mutex); static DEFINE_MUTEX(shares_mutex);
@ -10717,9 +10720,9 @@ static u64 cpuacct_cpuusage_read(struct cpuacct *ca, int cpu)
/* /*
* Take rq->lock to make 64-bit read safe on 32-bit platforms. * Take rq->lock to make 64-bit read safe on 32-bit platforms.
*/ */
spin_lock_irq(&cpu_rq(cpu)->lock); raw_spin_lock_irq(&cpu_rq(cpu)->lock);
data = *cpuusage; data = *cpuusage;
spin_unlock_irq(&cpu_rq(cpu)->lock); raw_spin_unlock_irq(&cpu_rq(cpu)->lock);
#else #else
data = *cpuusage; data = *cpuusage;
#endif #endif
@ -10735,9 +10738,9 @@ static void cpuacct_cpuusage_write(struct cpuacct *ca, int cpu, u64 val)
/* /*
* Take rq->lock to make 64-bit write safe on 32-bit platforms. * Take rq->lock to make 64-bit write safe on 32-bit platforms.
*/ */
spin_lock_irq(&cpu_rq(cpu)->lock); raw_spin_lock_irq(&cpu_rq(cpu)->lock);
*cpuusage = val; *cpuusage = val;
spin_unlock_irq(&cpu_rq(cpu)->lock); raw_spin_unlock_irq(&cpu_rq(cpu)->lock);
#else #else
*cpuusage = val; *cpuusage = val;
#endif #endif
@ -10971,9 +10974,9 @@ void synchronize_sched_expedited(void)
init_completion(&req->done); init_completion(&req->done);
req->task = NULL; req->task = NULL;
req->dest_cpu = RCU_MIGRATION_NEED_QS; req->dest_cpu = RCU_MIGRATION_NEED_QS;
spin_lock_irqsave(&rq->lock, flags); raw_spin_lock_irqsave(&rq->lock, flags);
list_add(&req->list, &rq->migration_queue); list_add(&req->list, &rq->migration_queue);
spin_unlock_irqrestore(&rq->lock, flags); raw_spin_unlock_irqrestore(&rq->lock, flags);
wake_up_process(rq->migration_thread); wake_up_process(rq->migration_thread);
} }
for_each_online_cpu(cpu) { for_each_online_cpu(cpu) {
@ -10981,11 +10984,11 @@ void synchronize_sched_expedited(void)
req = &per_cpu(rcu_migration_req, cpu); req = &per_cpu(rcu_migration_req, cpu);
rq = cpu_rq(cpu); rq = cpu_rq(cpu);
wait_for_completion(&req->done); wait_for_completion(&req->done);
spin_lock_irqsave(&rq->lock, flags); raw_spin_lock_irqsave(&rq->lock, flags);
if (unlikely(req->dest_cpu == RCU_MIGRATION_MUST_SYNC)) if (unlikely(req->dest_cpu == RCU_MIGRATION_MUST_SYNC))
need_full_sync = 1; need_full_sync = 1;
req->dest_cpu = RCU_MIGRATION_IDLE; req->dest_cpu = RCU_MIGRATION_IDLE;
spin_unlock_irqrestore(&rq->lock, flags); raw_spin_unlock_irqrestore(&rq->lock, flags);
} }
rcu_expedited_state = RCU_EXPEDITED_STATE_IDLE; rcu_expedited_state = RCU_EXPEDITED_STATE_IDLE;
synchronize_sched_expedited_count++; synchronize_sched_expedited_count++;

View file

@ -184,7 +184,7 @@ void print_cfs_rq(struct seq_file *m, int cpu, struct cfs_rq *cfs_rq)
SEQ_printf(m, " .%-30s: %Ld.%06ld\n", "exec_clock", SEQ_printf(m, " .%-30s: %Ld.%06ld\n", "exec_clock",
SPLIT_NS(cfs_rq->exec_clock)); SPLIT_NS(cfs_rq->exec_clock));
spin_lock_irqsave(&rq->lock, flags); raw_spin_lock_irqsave(&rq->lock, flags);
if (cfs_rq->rb_leftmost) if (cfs_rq->rb_leftmost)
MIN_vruntime = (__pick_next_entity(cfs_rq))->vruntime; MIN_vruntime = (__pick_next_entity(cfs_rq))->vruntime;
last = __pick_last_entity(cfs_rq); last = __pick_last_entity(cfs_rq);
@ -192,7 +192,7 @@ void print_cfs_rq(struct seq_file *m, int cpu, struct cfs_rq *cfs_rq)
max_vruntime = last->vruntime; max_vruntime = last->vruntime;
min_vruntime = cfs_rq->min_vruntime; min_vruntime = cfs_rq->min_vruntime;
rq0_min_vruntime = cpu_rq(0)->cfs.min_vruntime; rq0_min_vruntime = cpu_rq(0)->cfs.min_vruntime;
spin_unlock_irqrestore(&rq->lock, flags); raw_spin_unlock_irqrestore(&rq->lock, flags);
SEQ_printf(m, " .%-30s: %Ld.%06ld\n", "MIN_vruntime", SEQ_printf(m, " .%-30s: %Ld.%06ld\n", "MIN_vruntime",
SPLIT_NS(MIN_vruntime)); SPLIT_NS(MIN_vruntime));
SEQ_printf(m, " .%-30s: %Ld.%06ld\n", "min_vruntime", SEQ_printf(m, " .%-30s: %Ld.%06ld\n", "min_vruntime",

View file

@ -1955,7 +1955,7 @@ static void task_fork_fair(struct task_struct *p)
struct rq *rq = this_rq(); struct rq *rq = this_rq();
unsigned long flags; unsigned long flags;
spin_lock_irqsave(&rq->lock, flags); raw_spin_lock_irqsave(&rq->lock, flags);
if (unlikely(task_cpu(p) != this_cpu)) if (unlikely(task_cpu(p) != this_cpu))
__set_task_cpu(p, this_cpu); __set_task_cpu(p, this_cpu);
@ -1975,7 +1975,7 @@ static void task_fork_fair(struct task_struct *p)
resched_task(rq->curr); resched_task(rq->curr);
} }
spin_unlock_irqrestore(&rq->lock, flags); raw_spin_unlock_irqrestore(&rq->lock, flags);
} }
/* /*

View file

@ -34,10 +34,10 @@ static struct task_struct *pick_next_task_idle(struct rq *rq)
static void static void
dequeue_task_idle(struct rq *rq, struct task_struct *p, int sleep) dequeue_task_idle(struct rq *rq, struct task_struct *p, int sleep)
{ {
spin_unlock_irq(&rq->lock); raw_spin_unlock_irq(&rq->lock);
printk(KERN_ERR "bad: scheduling from the idle thread!\n"); printk(KERN_ERR "bad: scheduling from the idle thread!\n");
dump_stack(); dump_stack();
spin_lock_irq(&rq->lock); raw_spin_lock_irq(&rq->lock);
} }
static void put_prev_task_idle(struct rq *rq, struct task_struct *prev) static void put_prev_task_idle(struct rq *rq, struct task_struct *prev)

View file

@ -454,9 +454,9 @@ static void disable_runtime(struct rq *rq)
{ {
unsigned long flags; unsigned long flags;
spin_lock_irqsave(&rq->lock, flags); raw_spin_lock_irqsave(&rq->lock, flags);
__disable_runtime(rq); __disable_runtime(rq);
spin_unlock_irqrestore(&rq->lock, flags); raw_spin_unlock_irqrestore(&rq->lock, flags);
} }
static void __enable_runtime(struct rq *rq) static void __enable_runtime(struct rq *rq)
@ -486,9 +486,9 @@ static void enable_runtime(struct rq *rq)
{ {
unsigned long flags; unsigned long flags;
spin_lock_irqsave(&rq->lock, flags); raw_spin_lock_irqsave(&rq->lock, flags);
__enable_runtime(rq); __enable_runtime(rq);
spin_unlock_irqrestore(&rq->lock, flags); raw_spin_unlock_irqrestore(&rq->lock, flags);
} }
static int balance_runtime(struct rt_rq *rt_rq) static int balance_runtime(struct rt_rq *rt_rq)
@ -524,7 +524,7 @@ static int do_sched_rt_period_timer(struct rt_bandwidth *rt_b, int overrun)
struct rt_rq *rt_rq = sched_rt_period_rt_rq(rt_b, i); struct rt_rq *rt_rq = sched_rt_period_rt_rq(rt_b, i);
struct rq *rq = rq_of_rt_rq(rt_rq); struct rq *rq = rq_of_rt_rq(rt_rq);
spin_lock(&rq->lock); raw_spin_lock(&rq->lock);
if (rt_rq->rt_time) { if (rt_rq->rt_time) {
u64 runtime; u64 runtime;
@ -545,7 +545,7 @@ static int do_sched_rt_period_timer(struct rt_bandwidth *rt_b, int overrun)
if (enqueue) if (enqueue)
sched_rt_rq_enqueue(rt_rq); sched_rt_rq_enqueue(rt_rq);
spin_unlock(&rq->lock); raw_spin_unlock(&rq->lock);
} }
return idle; return idle;
@ -1246,7 +1246,7 @@ static struct rq *find_lock_lowest_rq(struct task_struct *task, struct rq *rq)
task_running(rq, task) || task_running(rq, task) ||
!task->se.on_rq)) { !task->se.on_rq)) {
spin_unlock(&lowest_rq->lock); raw_spin_unlock(&lowest_rq->lock);
lowest_rq = NULL; lowest_rq = NULL;
break; break;
} }