adulau/aha
1
0
Fork 0
mirror of https://github.com/adulau/aha.git synced 2024-12-28 03:36:19 +00:00
Code Issues Projects Releases Packages Wiki Activity

kgdb: allow for cpu switch when single stepping

Browse source 
The kgdb core should not assume that a single step operation of a
kernel thread will complete on the same CPU.  The single step flag is
set at the "thread" level and it is possible in a multi cpu system
that a kernel thread can get scheduled on another cpu the next time it
is run.

As a further safety net in case a slave cpu is hung, the debug master
cpu will try 100 times before giving up and assuming control of the
slave cpus is no longer possible.  It is more useful to be able to get
some information out of kgdb instead of spinning forever.

Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
This commit is contained in:
Jason Wessel 2009-12-11 08:43:17 -06:00
parent cf6f196d11
commit 028e7b1759
1 changed files with 15 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
kernel/kgdb.c
View file

@ -129,6 +129,7 @@ struct task_struct *kgdb_usethread;
struct task_struct *kgdb_contthread; struct task_struct *kgdb_contthread;
int kgdb_single_step; int kgdb_single_step;
pid_t kgdb_sstep_pid;
/* Our I/O buffers. */ /* Our I/O buffers. */
static char remcom_in_buffer[BUFMAX]; static char remcom_in_buffer[BUFMAX];
@ -1400,6 +1401,7 @@ kgdb_handle_exception(int evector, int signo, int ecode, struct pt_regs *regs)
struct kgdb_state kgdb_var; struct kgdb_state kgdb_var;
struct kgdb_state *ks = &kgdb_var; struct kgdb_state *ks = &kgdb_var;
unsigned long flags; unsigned long flags;
int sstep_tries = 100;
int error = 0; int error = 0;
int i, cpu; int i, cpu;
@ -1430,13 +1432,14 @@ acquirelock:
cpu_relax(); cpu_relax();
/* /*
* Do not start the debugger connection on this CPU if the last * For single stepping, try to only enter on the processor
* instance of the exception handler wanted to come into the * that was single stepping. To gaurd against a deadlock, the
* debugger on a different CPU via a single step * kernel will only try for the value of sstep_tries before
* giving up and continuing on.
*/ */
if (atomic_read(&kgdb_cpu_doing_single_step) != -1 && if (atomic_read(&kgdb_cpu_doing_single_step) != -1 &&
atomic_read(&kgdb_cpu_doing_single_step) != cpu) { (kgdb_info[cpu].task &&
kgdb_info[cpu].task->pid != kgdb_sstep_pid) && --sstep_tries) {
atomic_set(&kgdb_active, -1); atomic_set(&kgdb_active, -1);
touch_softlockup_watchdog(); touch_softlockup_watchdog();
clocksource_touch_watchdog(); clocksource_touch_watchdog();
@ -1529,6 +1532,13 @@ acquirelock:
} }
kgdb_restore: kgdb_restore:
if (atomic_read(&kgdb_cpu_doing_single_step) != -1) {
int sstep_cpu = atomic_read(&kgdb_cpu_doing_single_step);
if (kgdb_info[sstep_cpu].task)
kgdb_sstep_pid = kgdb_info[sstep_cpu].task->pid;
else
kgdb_sstep_pid = 0;
}
/* Free kgdb_active */ /* Free kgdb_active */
atomic_set(&kgdb_active, -1); atomic_set(&kgdb_active, -1);
touch_softlockup_watchdog(); touch_softlockup_watchdog();