2008-12-09 23:10:17 +00:00
|
|
|
/*
|
|
|
|
* Copyright(c) 2007 - 2008 Intel Corporation. All rights reserved.
|
|
|
|
*
|
|
|
|
* This program is free software; you can redistribute it and/or modify it
|
|
|
|
* under the terms and conditions of the GNU General Public License,
|
|
|
|
* version 2, as published by the Free Software Foundation.
|
|
|
|
*
|
|
|
|
* This program is distributed in the hope it will be useful, but WITHOUT
|
|
|
|
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
|
|
|
|
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
|
|
|
|
* more details.
|
|
|
|
*
|
|
|
|
* You should have received a copy of the GNU General Public License along with
|
|
|
|
* this program; if not, write to the Free Software Foundation, Inc.,
|
|
|
|
* 51 Franklin St - Fifth Floor, Boston, MA 02110-1301 USA.
|
|
|
|
*
|
|
|
|
* Maintained at www.Open-FCoE.org
|
|
|
|
*/
|
|
|
|
|
|
|
|
/*
|
|
|
|
* RPORT GENERAL INFO
|
|
|
|
*
|
|
|
|
* This file contains all processing regarding fc_rports. It contains the
|
|
|
|
* rport state machine and does all rport interaction with the transport class.
|
|
|
|
* There should be no other places in libfc that interact directly with the
|
|
|
|
* transport class in regards to adding and deleting rports.
|
|
|
|
*
|
|
|
|
* fc_rport's represent N_Port's within the fabric.
|
|
|
|
*/
|
|
|
|
|
|
|
|
/*
|
|
|
|
* RPORT LOCKING
|
|
|
|
*
|
|
|
|
* The rport should never hold the rport mutex and then attempt to acquire
|
|
|
|
* either the lport or disc mutexes. The rport's mutex is considered lesser
|
|
|
|
* than both the lport's mutex and the disc mutex. Refer to fc_lport.c for
|
|
|
|
* more comments on the heirarchy.
|
|
|
|
*
|
|
|
|
* The locking strategy is similar to the lport's strategy. The lock protects
|
|
|
|
* the rport's states and is held and released by the entry points to the rport
|
|
|
|
* block. All _enter_* functions correspond to rport states and expect the rport
|
|
|
|
* mutex to be locked before calling them. This means that rports only handle
|
|
|
|
* one request or response at a time, since they're not critical for the I/O
|
|
|
|
* path this potential over-use of the mutex is acceptable.
|
|
|
|
*/
|
|
|
|
|
|
|
|
#include <linux/kernel.h>
|
|
|
|
#include <linux/spinlock.h>
|
|
|
|
#include <linux/interrupt.h>
|
|
|
|
#include <linux/rcupdate.h>
|
|
|
|
#include <linux/timer.h>
|
|
|
|
#include <linux/workqueue.h>
|
|
|
|
#include <asm/unaligned.h>
|
|
|
|
|
|
|
|
#include <scsi/libfc.h>
|
|
|
|
#include <scsi/fc_encode.h>
|
|
|
|
|
2009-11-03 19:45:58 +00:00
|
|
|
#include "fc_libfc.h"
|
|
|
|
|
2008-12-09 23:10:17 +00:00
|
|
|
struct workqueue_struct *rport_event_queue;
|
|
|
|
|
2009-08-25 21:00:50 +00:00
|
|
|
static void fc_rport_enter_plogi(struct fc_rport_priv *);
|
|
|
|
static void fc_rport_enter_prli(struct fc_rport_priv *);
|
|
|
|
static void fc_rport_enter_rtv(struct fc_rport_priv *);
|
|
|
|
static void fc_rport_enter_ready(struct fc_rport_priv *);
|
|
|
|
static void fc_rport_enter_logo(struct fc_rport_priv *);
|
2009-08-25 21:03:47 +00:00
|
|
|
static void fc_rport_enter_adisc(struct fc_rport_priv *);
|
2008-12-09 23:10:17 +00:00
|
|
|
|
2009-08-25 21:03:26 +00:00
|
|
|
static void fc_rport_recv_plogi_req(struct fc_lport *,
|
2008-12-09 23:10:17 +00:00
|
|
|
struct fc_seq *, struct fc_frame *);
|
2009-08-25 21:00:50 +00:00
|
|
|
static void fc_rport_recv_prli_req(struct fc_rport_priv *,
|
2008-12-09 23:10:17 +00:00
|
|
|
struct fc_seq *, struct fc_frame *);
|
2009-08-25 21:00:50 +00:00
|
|
|
static void fc_rport_recv_prlo_req(struct fc_rport_priv *,
|
2008-12-09 23:10:17 +00:00
|
|
|
struct fc_seq *, struct fc_frame *);
|
2009-08-25 21:03:31 +00:00
|
|
|
static void fc_rport_recv_logo_req(struct fc_lport *,
|
2008-12-09 23:10:17 +00:00
|
|
|
struct fc_seq *, struct fc_frame *);
|
|
|
|
static void fc_rport_timeout(struct work_struct *);
|
2009-08-25 21:00:50 +00:00
|
|
|
static void fc_rport_error(struct fc_rport_priv *, struct fc_frame *);
|
|
|
|
static void fc_rport_error_retry(struct fc_rport_priv *, struct fc_frame *);
|
2008-12-09 23:10:17 +00:00
|
|
|
static void fc_rport_work(struct work_struct *);
|
|
|
|
|
|
|
|
static const char *fc_rport_state_names[] = {
|
|
|
|
[RPORT_ST_INIT] = "Init",
|
|
|
|
[RPORT_ST_PLOGI] = "PLOGI",
|
|
|
|
[RPORT_ST_PRLI] = "PRLI",
|
|
|
|
[RPORT_ST_RTV] = "RTV",
|
|
|
|
[RPORT_ST_READY] = "Ready",
|
|
|
|
[RPORT_ST_LOGO] = "LOGO",
|
2009-08-25 21:03:47 +00:00
|
|
|
[RPORT_ST_ADISC] = "ADISC",
|
2009-07-30 00:04:43 +00:00
|
|
|
[RPORT_ST_DELETE] = "Delete",
|
[SCSI] libfc: fix free of fc_rport_priv with timer pending
Timer crashes were caused by freeing a struct fc_rport_priv
with a timer pending, causing the timer facility list to be
corrupted. This was during FC uplink flap tests with a lot
of targets.
After discovery, we were doing an PLOGI on an rdata that was
in DELETE state but not yet removed from the lookup list.
This moved the rdata from DELETE state to PLOGI state.
If the PLOGI exchange allocation failed and needed to be
retried, the timer scheduling could race with the free
being done by fc_rport_work().
When fc_rport_login() is called on a rport in DELETE state,
move it to a new state RESTART. In fc_rport_work, when
handling a LOGO, STOPPED or FAILED event, look for restart
state. In the RESTART case, don't take the rdata off the
list and after the transport remote port is deleted and
exchanges are reset, re-login to the remote port.
Note that the new RESTART state also corrects a problem we
had when re-discovering a port that had moved to DELETE state.
In that case, a new rdata was created, but the old rdata
would do an exchange manager reset affecting the FC_ID
for both the new rdata and old rdata. With the new state,
the new port isn't logged into until after any old exchanges
are reset.
Signed-off-by: Joe Eykholt <jeykholt@cisco.com>
Signed-off-by: Robert Love <robert.w.love@intel.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
2009-10-21 23:28:30 +00:00
|
|
|
[RPORT_ST_RESTART] = "Restart",
|
2008-12-09 23:10:17 +00:00
|
|
|
};
|
|
|
|
|
2009-08-25 21:02:06 +00:00
|
|
|
/**
|
2009-11-03 19:47:39 +00:00
|
|
|
* fc_rport_lookup() - Lookup a remote port by port_id
|
|
|
|
* @lport: The local port to lookup the remote port on
|
|
|
|
* @port_id: The remote port ID to look up
|
2009-08-25 21:02:06 +00:00
|
|
|
*/
|
|
|
|
static struct fc_rport_priv *fc_rport_lookup(const struct fc_lport *lport,
|
|
|
|
u32 port_id)
|
|
|
|
{
|
|
|
|
struct fc_rport_priv *rdata;
|
|
|
|
|
|
|
|
list_for_each_entry(rdata, &lport->disc.rports, peers)
|
[SCSI] libfc: fix free of fc_rport_priv with timer pending
Timer crashes were caused by freeing a struct fc_rport_priv
with a timer pending, causing the timer facility list to be
corrupted. This was during FC uplink flap tests with a lot
of targets.
After discovery, we were doing an PLOGI on an rdata that was
in DELETE state but not yet removed from the lookup list.
This moved the rdata from DELETE state to PLOGI state.
If the PLOGI exchange allocation failed and needed to be
retried, the timer scheduling could race with the free
being done by fc_rport_work().
When fc_rport_login() is called on a rport in DELETE state,
move it to a new state RESTART. In fc_rport_work, when
handling a LOGO, STOPPED or FAILED event, look for restart
state. In the RESTART case, don't take the rdata off the
list and after the transport remote port is deleted and
exchanges are reset, re-login to the remote port.
Note that the new RESTART state also corrects a problem we
had when re-discovering a port that had moved to DELETE state.
In that case, a new rdata was created, but the old rdata
would do an exchange manager reset affecting the FC_ID
for both the new rdata and old rdata. With the new state,
the new port isn't logged into until after any old exchanges
are reset.
Signed-off-by: Joe Eykholt <jeykholt@cisco.com>
Signed-off-by: Robert Love <robert.w.love@intel.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
2009-10-21 23:28:30 +00:00
|
|
|
if (rdata->ids.port_id == port_id)
|
2009-08-25 21:02:06 +00:00
|
|
|
return rdata;
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
2009-08-25 21:01:18 +00:00
|
|
|
/**
|
2009-08-25 21:02:59 +00:00
|
|
|
* fc_rport_create() - Create a new remote port
|
2009-11-03 19:47:39 +00:00
|
|
|
* @lport: The local port this remote port will be associated with
|
|
|
|
* @ids: The identifiers for the new remote port
|
|
|
|
*
|
|
|
|
* The remote port will start in the INIT state.
|
2009-08-25 21:01:18 +00:00
|
|
|
*
|
2009-08-25 21:01:50 +00:00
|
|
|
* Locking note: must be called with the disc_mutex held.
|
2009-08-25 21:01:18 +00:00
|
|
|
*/
|
|
|
|
static struct fc_rport_priv *fc_rport_create(struct fc_lport *lport,
|
2009-08-25 21:02:59 +00:00
|
|
|
u32 port_id)
|
2008-12-09 23:10:17 +00:00
|
|
|
{
|
2009-08-25 21:00:34 +00:00
|
|
|
struct fc_rport_priv *rdata;
|
2008-12-09 23:10:17 +00:00
|
|
|
|
2009-08-25 21:02:59 +00:00
|
|
|
rdata = lport->tt.rport_lookup(lport, port_id);
|
2009-08-25 21:01:55 +00:00
|
|
|
if (rdata)
|
|
|
|
return rdata;
|
|
|
|
|
2009-08-25 21:01:18 +00:00
|
|
|
rdata = kzalloc(sizeof(*rdata), GFP_KERNEL);
|
|
|
|
if (!rdata)
|
2008-12-09 23:10:17 +00:00
|
|
|
return NULL;
|
|
|
|
|
2009-08-25 21:02:59 +00:00
|
|
|
rdata->ids.node_name = -1;
|
|
|
|
rdata->ids.port_name = -1;
|
|
|
|
rdata->ids.port_id = port_id;
|
|
|
|
rdata->ids.roles = FC_RPORT_ROLE_UNKNOWN;
|
|
|
|
|
2009-08-25 21:01:01 +00:00
|
|
|
kref_init(&rdata->kref);
|
2008-12-09 23:10:17 +00:00
|
|
|
mutex_init(&rdata->rp_mutex);
|
2009-08-25 21:00:39 +00:00
|
|
|
rdata->local_port = lport;
|
2008-12-09 23:10:17 +00:00
|
|
|
rdata->rp_state = RPORT_ST_INIT;
|
|
|
|
rdata->event = RPORT_EV_NONE;
|
|
|
|
rdata->flags = FC_RP_FLAGS_REC_SUPPORTED;
|
2009-08-25 21:00:39 +00:00
|
|
|
rdata->e_d_tov = lport->e_d_tov;
|
|
|
|
rdata->r_a_tov = lport->r_a_tov;
|
2009-08-25 21:01:01 +00:00
|
|
|
rdata->maxframe_size = FC_MIN_MAX_PAYLOAD;
|
2008-12-09 23:10:17 +00:00
|
|
|
INIT_DELAYED_WORK(&rdata->retry_work, fc_rport_timeout);
|
|
|
|
INIT_WORK(&rdata->event_work, fc_rport_work);
|
2009-08-25 21:02:59 +00:00
|
|
|
if (port_id != FC_FID_DIR_SERV)
|
2009-08-25 21:01:50 +00:00
|
|
|
list_add(&rdata->peers, &lport->disc.rports);
|
2009-08-25 21:00:50 +00:00
|
|
|
return rdata;
|
2008-12-09 23:10:17 +00:00
|
|
|
}
|
|
|
|
|
2009-08-25 21:01:01 +00:00
|
|
|
/**
|
2009-11-03 19:47:39 +00:00
|
|
|
* fc_rport_destroy() - Free a remote port after last reference is released
|
|
|
|
* @kref: The remote port's kref
|
2009-08-25 21:01:01 +00:00
|
|
|
*/
|
|
|
|
static void fc_rport_destroy(struct kref *kref)
|
|
|
|
{
|
|
|
|
struct fc_rport_priv *rdata;
|
|
|
|
|
|
|
|
rdata = container_of(kref, struct fc_rport_priv, kref);
|
2009-08-25 21:01:18 +00:00
|
|
|
kfree(rdata);
|
2009-08-25 21:01:01 +00:00
|
|
|
}
|
|
|
|
|
2008-12-09 23:10:17 +00:00
|
|
|
/**
|
2009-11-03 19:47:39 +00:00
|
|
|
* fc_rport_state() - Return a string identifying the remote port's state
|
|
|
|
* @rdata: The remote port
|
2008-12-09 23:10:17 +00:00
|
|
|
*/
|
2009-08-25 21:00:50 +00:00
|
|
|
static const char *fc_rport_state(struct fc_rport_priv *rdata)
|
2008-12-09 23:10:17 +00:00
|
|
|
{
|
|
|
|
const char *cp;
|
|
|
|
|
|
|
|
cp = fc_rport_state_names[rdata->rp_state];
|
|
|
|
if (!cp)
|
|
|
|
cp = "Unknown";
|
|
|
|
return cp;
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2009-11-03 19:47:39 +00:00
|
|
|
* fc_set_rport_loss_tmo() - Set the remote port loss timeout
|
|
|
|
* @rport: The remote port that gets a new timeout value
|
|
|
|
* @timeout: The new timeout value (in seconds)
|
2008-12-09 23:10:17 +00:00
|
|
|
*/
|
|
|
|
void fc_set_rport_loss_tmo(struct fc_rport *rport, u32 timeout)
|
|
|
|
{
|
|
|
|
if (timeout)
|
|
|
|
rport->dev_loss_tmo = timeout + 5;
|
|
|
|
else
|
|
|
|
rport->dev_loss_tmo = 30;
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL(fc_set_rport_loss_tmo);
|
|
|
|
|
|
|
|
/**
|
2009-11-03 19:47:39 +00:00
|
|
|
* fc_plogi_get_maxframe() - Get the maximum payload from the common service
|
|
|
|
* parameters in a FLOGI frame
|
|
|
|
* @flp: The FLOGI payload
|
|
|
|
* @maxval: The maximum frame size upper limit; this may be less than what
|
|
|
|
* is in the service parameters
|
2008-12-09 23:10:17 +00:00
|
|
|
*/
|
2009-02-27 18:55:50 +00:00
|
|
|
static unsigned int fc_plogi_get_maxframe(struct fc_els_flogi *flp,
|
|
|
|
unsigned int maxval)
|
2008-12-09 23:10:17 +00:00
|
|
|
{
|
|
|
|
unsigned int mfs;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Get max payload from the common service parameters and the
|
|
|
|
* class 3 receive data field size.
|
|
|
|
*/
|
|
|
|
mfs = ntohs(flp->fl_csp.sp_bb_data) & FC_SP_BB_DATA_MASK;
|
|
|
|
if (mfs >= FC_SP_MIN_MAX_PAYLOAD && mfs < maxval)
|
|
|
|
maxval = mfs;
|
|
|
|
mfs = ntohs(flp->fl_cssp[3 - 1].cp_rdfs);
|
|
|
|
if (mfs >= FC_SP_MIN_MAX_PAYLOAD && mfs < maxval)
|
|
|
|
maxval = mfs;
|
|
|
|
return maxval;
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2009-11-03 19:47:39 +00:00
|
|
|
* fc_rport_state_enter() - Change the state of a remote port
|
|
|
|
* @rdata: The remote port whose state should change
|
|
|
|
* @new: The new state
|
2008-12-09 23:10:17 +00:00
|
|
|
*
|
|
|
|
* Locking Note: Called with the rport lock held
|
|
|
|
*/
|
2009-08-25 21:00:50 +00:00
|
|
|
static void fc_rport_state_enter(struct fc_rport_priv *rdata,
|
2008-12-09 23:10:17 +00:00
|
|
|
enum fc_rport_state new)
|
|
|
|
{
|
|
|
|
if (rdata->rp_state != new)
|
|
|
|
rdata->retries = 0;
|
|
|
|
rdata->rp_state = new;
|
|
|
|
}
|
|
|
|
|
2009-11-03 19:47:39 +00:00
|
|
|
/**
|
|
|
|
* fc_rport_work() - Handler for remote port events in the rport_event_queue
|
|
|
|
* @work: Handle to the remote port being dequeued
|
|
|
|
*/
|
2008-12-09 23:10:17 +00:00
|
|
|
static void fc_rport_work(struct work_struct *work)
|
|
|
|
{
|
2009-02-27 18:54:41 +00:00
|
|
|
u32 port_id;
|
2009-08-25 21:00:34 +00:00
|
|
|
struct fc_rport_priv *rdata =
|
|
|
|
container_of(work, struct fc_rport_priv, event_work);
|
2009-11-03 19:47:39 +00:00
|
|
|
struct fc_rport_libfc_priv *rpriv;
|
2008-12-09 23:10:17 +00:00
|
|
|
enum fc_rport_event event;
|
|
|
|
struct fc_lport *lport = rdata->local_port;
|
|
|
|
struct fc_rport_operations *rport_ops;
|
2009-08-25 21:01:06 +00:00
|
|
|
struct fc_rport_identifiers ids;
|
2009-08-25 21:01:01 +00:00
|
|
|
struct fc_rport *rport;
|
[SCSI] libfc: fix free of fc_rport_priv with timer pending
Timer crashes were caused by freeing a struct fc_rport_priv
with a timer pending, causing the timer facility list to be
corrupted. This was during FC uplink flap tests with a lot
of targets.
After discovery, we were doing an PLOGI on an rdata that was
in DELETE state but not yet removed from the lookup list.
This moved the rdata from DELETE state to PLOGI state.
If the PLOGI exchange allocation failed and needed to be
retried, the timer scheduling could race with the free
being done by fc_rport_work().
When fc_rport_login() is called on a rport in DELETE state,
move it to a new state RESTART. In fc_rport_work, when
handling a LOGO, STOPPED or FAILED event, look for restart
state. In the RESTART case, don't take the rdata off the
list and after the transport remote port is deleted and
exchanges are reset, re-login to the remote port.
Note that the new RESTART state also corrects a problem we
had when re-discovering a port that had moved to DELETE state.
In that case, a new rdata was created, but the old rdata
would do an exchange manager reset affecting the FC_ID
for both the new rdata and old rdata. With the new state,
the new port isn't logged into until after any old exchanges
are reset.
Signed-off-by: Joe Eykholt <jeykholt@cisco.com>
Signed-off-by: Robert Love <robert.w.love@intel.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
2009-10-21 23:28:30 +00:00
|
|
|
int restart = 0;
|
2008-12-09 23:10:17 +00:00
|
|
|
|
|
|
|
mutex_lock(&rdata->rp_mutex);
|
|
|
|
event = rdata->event;
|
|
|
|
rport_ops = rdata->ops;
|
2009-08-25 21:01:01 +00:00
|
|
|
rport = rdata->rport;
|
2008-12-09 23:10:17 +00:00
|
|
|
|
2009-08-25 21:01:18 +00:00
|
|
|
FC_RPORT_DBG(rdata, "work event %u\n", event);
|
|
|
|
|
2009-08-25 21:01:06 +00:00
|
|
|
switch (event) {
|
2009-08-25 21:01:12 +00:00
|
|
|
case RPORT_EV_READY:
|
2009-08-25 21:01:01 +00:00
|
|
|
ids = rdata->ids;
|
2009-07-30 00:04:49 +00:00
|
|
|
rdata->event = RPORT_EV_NONE;
|
2009-08-25 21:01:18 +00:00
|
|
|
kref_get(&rdata->kref);
|
2008-12-09 23:10:17 +00:00
|
|
|
mutex_unlock(&rdata->rp_mutex);
|
|
|
|
|
2009-08-25 21:01:18 +00:00
|
|
|
if (!rport)
|
|
|
|
rport = fc_remote_port_add(lport->host, 0, &ids);
|
|
|
|
if (!rport) {
|
|
|
|
FC_RPORT_DBG(rdata, "Failed to add the rport\n");
|
|
|
|
lport->tt.rport_logoff(rdata);
|
|
|
|
kref_put(&rdata->kref, lport->tt.rport_destroy);
|
|
|
|
return;
|
2008-12-09 23:10:17 +00:00
|
|
|
}
|
2009-08-25 21:01:18 +00:00
|
|
|
mutex_lock(&rdata->rp_mutex);
|
|
|
|
if (rdata->rport)
|
|
|
|
FC_RPORT_DBG(rdata, "rport already allocated\n");
|
|
|
|
rdata->rport = rport;
|
|
|
|
rport->maxframe_size = rdata->maxframe_size;
|
|
|
|
rport->supported_classes = rdata->supported_classes;
|
|
|
|
|
2009-11-03 19:47:39 +00:00
|
|
|
rpriv = rport->dd_data;
|
|
|
|
rpriv->local_port = lport;
|
|
|
|
rpriv->rp_state = rdata->rp_state;
|
|
|
|
rpriv->flags = rdata->flags;
|
|
|
|
rpriv->e_d_tov = rdata->e_d_tov;
|
|
|
|
rpriv->r_a_tov = rdata->r_a_tov;
|
2009-08-25 21:01:18 +00:00
|
|
|
mutex_unlock(&rdata->rp_mutex);
|
|
|
|
|
2009-08-25 21:02:01 +00:00
|
|
|
if (rport_ops && rport_ops->event_callback) {
|
2009-08-25 21:01:18 +00:00
|
|
|
FC_RPORT_DBG(rdata, "callback ev %d\n", event);
|
2009-08-25 21:00:50 +00:00
|
|
|
rport_ops->event_callback(lport, rdata, event);
|
2009-08-25 21:01:18 +00:00
|
|
|
}
|
|
|
|
kref_put(&rdata->kref, lport->tt.rport_destroy);
|
2009-08-25 21:01:06 +00:00
|
|
|
break;
|
|
|
|
|
|
|
|
case RPORT_EV_FAILED:
|
|
|
|
case RPORT_EV_LOGO:
|
|
|
|
case RPORT_EV_STOP:
|
2009-08-25 21:01:18 +00:00
|
|
|
port_id = rdata->ids.port_id;
|
2008-12-09 23:10:17 +00:00
|
|
|
mutex_unlock(&rdata->rp_mutex);
|
2009-08-25 21:01:18 +00:00
|
|
|
|
2009-08-25 21:01:50 +00:00
|
|
|
if (port_id != FC_FID_DIR_SERV) {
|
[SCSI] libfc: fix free of fc_rport_priv with timer pending
Timer crashes were caused by freeing a struct fc_rport_priv
with a timer pending, causing the timer facility list to be
corrupted. This was during FC uplink flap tests with a lot
of targets.
After discovery, we were doing an PLOGI on an rdata that was
in DELETE state but not yet removed from the lookup list.
This moved the rdata from DELETE state to PLOGI state.
If the PLOGI exchange allocation failed and needed to be
retried, the timer scheduling could race with the free
being done by fc_rport_work().
When fc_rport_login() is called on a rport in DELETE state,
move it to a new state RESTART. In fc_rport_work, when
handling a LOGO, STOPPED or FAILED event, look for restart
state. In the RESTART case, don't take the rdata off the
list and after the transport remote port is deleted and
exchanges are reset, re-login to the remote port.
Note that the new RESTART state also corrects a problem we
had when re-discovering a port that had moved to DELETE state.
In that case, a new rdata was created, but the old rdata
would do an exchange manager reset affecting the FC_ID
for both the new rdata and old rdata. With the new state,
the new port isn't logged into until after any old exchanges
are reset.
Signed-off-by: Joe Eykholt <jeykholt@cisco.com>
Signed-off-by: Robert Love <robert.w.love@intel.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
2009-10-21 23:28:30 +00:00
|
|
|
/*
|
|
|
|
* We must drop rp_mutex before taking disc_mutex.
|
|
|
|
* Re-evaluate state to allow for restart.
|
|
|
|
* A transition to RESTART state must only happen
|
|
|
|
* while disc_mutex is held and rdata is on the list.
|
|
|
|
*/
|
2009-08-25 21:01:50 +00:00
|
|
|
mutex_lock(&lport->disc.disc_mutex);
|
[SCSI] libfc: fix free of fc_rport_priv with timer pending
Timer crashes were caused by freeing a struct fc_rport_priv
with a timer pending, causing the timer facility list to be
corrupted. This was during FC uplink flap tests with a lot
of targets.
After discovery, we were doing an PLOGI on an rdata that was
in DELETE state but not yet removed from the lookup list.
This moved the rdata from DELETE state to PLOGI state.
If the PLOGI exchange allocation failed and needed to be
retried, the timer scheduling could race with the free
being done by fc_rport_work().
When fc_rport_login() is called on a rport in DELETE state,
move it to a new state RESTART. In fc_rport_work, when
handling a LOGO, STOPPED or FAILED event, look for restart
state. In the RESTART case, don't take the rdata off the
list and after the transport remote port is deleted and
exchanges are reset, re-login to the remote port.
Note that the new RESTART state also corrects a problem we
had when re-discovering a port that had moved to DELETE state.
In that case, a new rdata was created, but the old rdata
would do an exchange manager reset affecting the FC_ID
for both the new rdata and old rdata. With the new state,
the new port isn't logged into until after any old exchanges
are reset.
Signed-off-by: Joe Eykholt <jeykholt@cisco.com>
Signed-off-by: Robert Love <robert.w.love@intel.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
2009-10-21 23:28:30 +00:00
|
|
|
mutex_lock(&rdata->rp_mutex);
|
|
|
|
if (rdata->rp_state == RPORT_ST_RESTART)
|
|
|
|
restart = 1;
|
|
|
|
else
|
|
|
|
list_del(&rdata->peers);
|
[SCSI] libfc: remote port gets stuck in restart state without really restarting
We ran into a scenario where a remote port goes into RESTART state, but
never gets added to scsi transport. The running vmcore showed the following:
a) Port was in RESTART state
b) rdata->event was STOP
c) no work gets scheduled for the remote work to fc_rport_work
After this point, shut/no-shut of the remote port did not cause the port
to get re-discovered. The port would move betwen DELETE and RESTART states,
but the event would always be STOP, no work would get scheduled to
fc_rport_work and the port would not get added to scsi_transport.
The problem is that rdata->event is not set to NONE after a port is
restarted. After this point, no more work gets scheduled for the remote port
since new work is scheduled only if rdata->event is non-NONE. So, the event
and state keep changing, but fc_rport_work does not get scheduled to actually
handle the event.
Here's a transition of states that explains the above observation:
) Port is first in READY State, event is NONE
2) RSCN on shut, port goes to DELETED, event is stop
3) Before fc_rport_work runs, RSCN on no-shut, port goes to RESTART, event is
still STOP
4) fc_rport_work gets scheduled, removes the port from transport, sees state
as RESTART, begins the PLOGI state machine, event remains as STOP (event NOT
changed to NONE, this is the bug)
5) Plogi state machine completes, port state goes to READY, event goes to
READY, but no work is scheduled since event was STOP (non-NONE) before.
Fc_rport_work is not scheduled, port remains in READY state, but is not added
to transport.
Things are broken at this point. Libfc rport is ready, but no transport rport
created.
6) now a shut causes port state to change to DELETE, event to change to STOP,
no work gets scheduled
7) no-shut causes port state to change to RESTART, event remains at STOP,
no work gets scheduled
(6) and (7) now get repeated everytime we do shut/no-shut. No way to get out
of this state. Fcc reset does not help too.
Only way to get out is to load/unload module.
Fix is to set rdata->event to NONE while processing the STOP/LOGO/FAILED
events, inside the discovery and rport locks.
Signed-off-by: Abhijeet Joglekar <abjoglek@cisco.com>
Signed-off-by: Robert Love <robert.w.love@intel.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
2009-12-10 17:59:20 +00:00
|
|
|
rdata->event = RPORT_EV_NONE;
|
[SCSI] libfc: fix free of fc_rport_priv with timer pending
Timer crashes were caused by freeing a struct fc_rport_priv
with a timer pending, causing the timer facility list to be
corrupted. This was during FC uplink flap tests with a lot
of targets.
After discovery, we were doing an PLOGI on an rdata that was
in DELETE state but not yet removed from the lookup list.
This moved the rdata from DELETE state to PLOGI state.
If the PLOGI exchange allocation failed and needed to be
retried, the timer scheduling could race with the free
being done by fc_rport_work().
When fc_rport_login() is called on a rport in DELETE state,
move it to a new state RESTART. In fc_rport_work, when
handling a LOGO, STOPPED or FAILED event, look for restart
state. In the RESTART case, don't take the rdata off the
list and after the transport remote port is deleted and
exchanges are reset, re-login to the remote port.
Note that the new RESTART state also corrects a problem we
had when re-discovering a port that had moved to DELETE state.
In that case, a new rdata was created, but the old rdata
would do an exchange manager reset affecting the FC_ID
for both the new rdata and old rdata. With the new state,
the new port isn't logged into until after any old exchanges
are reset.
Signed-off-by: Joe Eykholt <jeykholt@cisco.com>
Signed-off-by: Robert Love <robert.w.love@intel.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
2009-10-21 23:28:30 +00:00
|
|
|
mutex_unlock(&rdata->rp_mutex);
|
2009-08-25 21:01:50 +00:00
|
|
|
mutex_unlock(&lport->disc.disc_mutex);
|
|
|
|
}
|
|
|
|
|
2009-08-25 21:02:01 +00:00
|
|
|
if (rport_ops && rport_ops->event_callback) {
|
2009-08-25 21:01:18 +00:00
|
|
|
FC_RPORT_DBG(rdata, "callback ev %d\n", event);
|
2009-08-25 21:00:50 +00:00
|
|
|
rport_ops->event_callback(lport, rdata, event);
|
2009-08-25 21:01:18 +00:00
|
|
|
}
|
2009-07-30 00:04:54 +00:00
|
|
|
cancel_delayed_work_sync(&rdata->retry_work);
|
2009-08-25 21:01:18 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Reset any outstanding exchanges before freeing rport.
|
|
|
|
*/
|
|
|
|
lport->tt.exch_mgr_reset(lport, 0, port_id);
|
|
|
|
lport->tt.exch_mgr_reset(lport, port_id, 0);
|
|
|
|
|
|
|
|
if (rport) {
|
2009-11-03 19:47:39 +00:00
|
|
|
rpriv = rport->dd_data;
|
|
|
|
rpriv->rp_state = RPORT_ST_DELETE;
|
2009-08-25 21:01:18 +00:00
|
|
|
mutex_lock(&rdata->rp_mutex);
|
|
|
|
rdata->rport = NULL;
|
|
|
|
mutex_unlock(&rdata->rp_mutex);
|
2008-12-09 23:10:17 +00:00
|
|
|
fc_remote_port_delete(rport);
|
2009-02-27 18:54:41 +00:00
|
|
|
}
|
[SCSI] libfc: fix free of fc_rport_priv with timer pending
Timer crashes were caused by freeing a struct fc_rport_priv
with a timer pending, causing the timer facility list to be
corrupted. This was during FC uplink flap tests with a lot
of targets.
After discovery, we were doing an PLOGI on an rdata that was
in DELETE state but not yet removed from the lookup list.
This moved the rdata from DELETE state to PLOGI state.
If the PLOGI exchange allocation failed and needed to be
retried, the timer scheduling could race with the free
being done by fc_rport_work().
When fc_rport_login() is called on a rport in DELETE state,
move it to a new state RESTART. In fc_rport_work, when
handling a LOGO, STOPPED or FAILED event, look for restart
state. In the RESTART case, don't take the rdata off the
list and after the transport remote port is deleted and
exchanges are reset, re-login to the remote port.
Note that the new RESTART state also corrects a problem we
had when re-discovering a port that had moved to DELETE state.
In that case, a new rdata was created, but the old rdata
would do an exchange manager reset affecting the FC_ID
for both the new rdata and old rdata. With the new state,
the new port isn't logged into until after any old exchanges
are reset.
Signed-off-by: Joe Eykholt <jeykholt@cisco.com>
Signed-off-by: Robert Love <robert.w.love@intel.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
2009-10-21 23:28:30 +00:00
|
|
|
if (restart) {
|
|
|
|
mutex_lock(&rdata->rp_mutex);
|
|
|
|
FC_RPORT_DBG(rdata, "work restart\n");
|
|
|
|
fc_rport_enter_plogi(rdata);
|
|
|
|
mutex_unlock(&rdata->rp_mutex);
|
|
|
|
} else
|
|
|
|
kref_put(&rdata->kref, lport->tt.rport_destroy);
|
2009-08-25 21:01:06 +00:00
|
|
|
break;
|
|
|
|
|
|
|
|
default:
|
2008-12-09 23:10:17 +00:00
|
|
|
mutex_unlock(&rdata->rp_mutex);
|
2009-08-25 21:01:06 +00:00
|
|
|
break;
|
|
|
|
}
|
2008-12-09 23:10:17 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2009-02-27 18:55:45 +00:00
|
|
|
* fc_rport_login() - Start the remote port login state machine
|
2009-11-03 19:47:39 +00:00
|
|
|
* @rdata: The remote port to be logged in to
|
2008-12-09 23:10:17 +00:00
|
|
|
*
|
|
|
|
* Locking Note: Called without the rport lock held. This
|
|
|
|
* function will hold the rport lock, call an _enter_*
|
|
|
|
* function and then unlock the rport.
|
2009-08-25 21:03:47 +00:00
|
|
|
*
|
|
|
|
* This indicates the intent to be logged into the remote port.
|
|
|
|
* If it appears we are already logged in, ADISC is used to verify
|
|
|
|
* the setup.
|
2008-12-09 23:10:17 +00:00
|
|
|
*/
|
2009-08-25 21:00:50 +00:00
|
|
|
int fc_rport_login(struct fc_rport_priv *rdata)
|
2008-12-09 23:10:17 +00:00
|
|
|
{
|
|
|
|
mutex_lock(&rdata->rp_mutex);
|
|
|
|
|
2009-08-25 21:03:47 +00:00
|
|
|
switch (rdata->rp_state) {
|
|
|
|
case RPORT_ST_READY:
|
|
|
|
FC_RPORT_DBG(rdata, "ADISC port\n");
|
|
|
|
fc_rport_enter_adisc(rdata);
|
|
|
|
break;
|
[SCSI] libfc: fix free of fc_rport_priv with timer pending
Timer crashes were caused by freeing a struct fc_rport_priv
with a timer pending, causing the timer facility list to be
corrupted. This was during FC uplink flap tests with a lot
of targets.
After discovery, we were doing an PLOGI on an rdata that was
in DELETE state but not yet removed from the lookup list.
This moved the rdata from DELETE state to PLOGI state.
If the PLOGI exchange allocation failed and needed to be
retried, the timer scheduling could race with the free
being done by fc_rport_work().
When fc_rport_login() is called on a rport in DELETE state,
move it to a new state RESTART. In fc_rport_work, when
handling a LOGO, STOPPED or FAILED event, look for restart
state. In the RESTART case, don't take the rdata off the
list and after the transport remote port is deleted and
exchanges are reset, re-login to the remote port.
Note that the new RESTART state also corrects a problem we
had when re-discovering a port that had moved to DELETE state.
In that case, a new rdata was created, but the old rdata
would do an exchange manager reset affecting the FC_ID
for both the new rdata and old rdata. With the new state,
the new port isn't logged into until after any old exchanges
are reset.
Signed-off-by: Joe Eykholt <jeykholt@cisco.com>
Signed-off-by: Robert Love <robert.w.love@intel.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
2009-10-21 23:28:30 +00:00
|
|
|
case RPORT_ST_RESTART:
|
|
|
|
break;
|
|
|
|
case RPORT_ST_DELETE:
|
|
|
|
FC_RPORT_DBG(rdata, "Restart deleted port\n");
|
|
|
|
fc_rport_state_enter(rdata, RPORT_ST_RESTART);
|
|
|
|
break;
|
2009-08-25 21:03:47 +00:00
|
|
|
default:
|
|
|
|
FC_RPORT_DBG(rdata, "Login to port\n");
|
|
|
|
fc_rport_enter_plogi(rdata);
|
|
|
|
break;
|
|
|
|
}
|
2008-12-09 23:10:17 +00:00
|
|
|
mutex_unlock(&rdata->rp_mutex);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2009-07-30 00:04:49 +00:00
|
|
|
/**
|
2009-11-03 19:47:39 +00:00
|
|
|
* fc_rport_enter_delete() - Schedule a remote port to be deleted
|
|
|
|
* @rdata: The remote port to be deleted
|
|
|
|
* @event: The event to report as the reason for deletion
|
2009-07-30 00:04:49 +00:00
|
|
|
*
|
|
|
|
* Locking Note: Called with the rport lock held.
|
|
|
|
*
|
|
|
|
* Allow state change into DELETE only once.
|
|
|
|
*
|
|
|
|
* Call queue_work only if there's no event already pending.
|
|
|
|
* Set the new event so that the old pending event will not occur.
|
|
|
|
* Since we have the mutex, even if fc_rport_work() is already started,
|
|
|
|
* it'll see the new event.
|
|
|
|
*/
|
2009-08-25 21:00:50 +00:00
|
|
|
static void fc_rport_enter_delete(struct fc_rport_priv *rdata,
|
2009-07-30 00:04:49 +00:00
|
|
|
enum fc_rport_event event)
|
|
|
|
{
|
|
|
|
if (rdata->rp_state == RPORT_ST_DELETE)
|
|
|
|
return;
|
|
|
|
|
2009-08-25 21:00:50 +00:00
|
|
|
FC_RPORT_DBG(rdata, "Delete port\n");
|
2009-07-30 00:04:49 +00:00
|
|
|
|
2009-08-25 21:00:50 +00:00
|
|
|
fc_rport_state_enter(rdata, RPORT_ST_DELETE);
|
2009-07-30 00:04:49 +00:00
|
|
|
|
|
|
|
if (rdata->event == RPORT_EV_NONE)
|
|
|
|
queue_work(rport_event_queue, &rdata->event_work);
|
|
|
|
rdata->event = event;
|
|
|
|
}
|
|
|
|
|
2008-12-09 23:10:17 +00:00
|
|
|
/**
|
2009-11-03 19:47:39 +00:00
|
|
|
* fc_rport_logoff() - Logoff and remove a remote port
|
|
|
|
* @rdata: The remote port to be logged off of
|
2008-12-09 23:10:17 +00:00
|
|
|
*
|
|
|
|
* Locking Note: Called without the rport lock held. This
|
|
|
|
* function will hold the rport lock, call an _enter_*
|
|
|
|
* function and then unlock the rport.
|
|
|
|
*/
|
2009-08-25 21:00:50 +00:00
|
|
|
int fc_rport_logoff(struct fc_rport_priv *rdata)
|
2008-12-09 23:10:17 +00:00
|
|
|
{
|
|
|
|
mutex_lock(&rdata->rp_mutex);
|
|
|
|
|
2009-08-25 21:00:50 +00:00
|
|
|
FC_RPORT_DBG(rdata, "Remove port\n");
|
2008-12-09 23:10:17 +00:00
|
|
|
|
2009-07-30 00:04:43 +00:00
|
|
|
if (rdata->rp_state == RPORT_ST_DELETE) {
|
2009-08-25 21:00:50 +00:00
|
|
|
FC_RPORT_DBG(rdata, "Port in Delete state, not removing\n");
|
[SCSI] libfc: Track rogue remote ports
Rogue ports are currently not tracked on any list. The only reference
to them is through any outstanding exchanges pending on the rogue ports.
If the module is removed while a retry is set on a rogue port
(say a Plogi retry for instance), this retry is not cancelled because there
is no reference to the rogue port in the discovery rports list. Thus the
local port can clean itself up, delete the exchange pool, and then the
rogue port timeout can fire and try to start up another exchange.
This patch tracks the rogue ports in a new list disc->rogue_rports. Creating
a new list instead of using the disc->rports list keeps remote port code
change to a minimum.
1) Whenever a rogue port is created, it is immediately added to the
disc->rogue_rports list.
2) When the rogues port goes to ready, it is removed from the rogue list
and the real remote port is added to the disc->rports list
3) The removal of the rogue from the disc->rogue_rports list is done in
the context of the fc_rport_work() workQ thread in discovery callback.
4) Real rports are removed from the disc->rports list like before. Lookup
is done only in the real rports list. This avoids making large changes
to the remote port code.
5) In fc_disc_stop_rports, the rogues list is traversed in addition to the
real list to stop the rogue ports and issue logoffs on them. This way, rogue
ports get cleaned up when the local port goes away.
6) rogue remote ports are not removed from the list right away, but
removed late in fc_rport_work() context, multiple threads can find the same
remote port in the list and call rport_logoff(). Rport_logoff() only
continues with the logoff if port is not in NONE state, thus preventing
multiple logoffs and multiple list deletions.
7) Since the rport is removed from the disc list at a later stage
(in the disc callback), incoming frames can find the rport even if
rport_logoff() has been called on the rport. When rport_logoff() is called,
the rport state is set to NONE, and we are trying to cancel all exchanges
and retries on that port. While in this state, if an incoming
Plogi/Prli/Logo or other frames match the rport, we should not reply
because the rport is in the NONE state. Just drop the frame, since the
rport will be deleted soon in the disc callback (fc_rport_work)
8) In fc_disc_single(), remove rport lookup and call to fc_disc_del_target.
fc_disc_single() is called from recv_rscn_req() where rport lookup
and rport_logoff is already done.
Signed-off-by: Abhijeet Joglekar <abjoglek@cisco.com>
Signed-off-by: Robert Love <robert.w.love@intel.com>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
2009-04-21 23:27:04 +00:00
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
[SCSI] libfc: fix free of fc_rport_priv with timer pending
Timer crashes were caused by freeing a struct fc_rport_priv
with a timer pending, causing the timer facility list to be
corrupted. This was during FC uplink flap tests with a lot
of targets.
After discovery, we were doing an PLOGI on an rdata that was
in DELETE state but not yet removed from the lookup list.
This moved the rdata from DELETE state to PLOGI state.
If the PLOGI exchange allocation failed and needed to be
retried, the timer scheduling could race with the free
being done by fc_rport_work().
When fc_rport_login() is called on a rport in DELETE state,
move it to a new state RESTART. In fc_rport_work, when
handling a LOGO, STOPPED or FAILED event, look for restart
state. In the RESTART case, don't take the rdata off the
list and after the transport remote port is deleted and
exchanges are reset, re-login to the remote port.
Note that the new RESTART state also corrects a problem we
had when re-discovering a port that had moved to DELETE state.
In that case, a new rdata was created, but the old rdata
would do an exchange manager reset affecting the FC_ID
for both the new rdata and old rdata. With the new state,
the new port isn't logged into until after any old exchanges
are reset.
Signed-off-by: Joe Eykholt <jeykholt@cisco.com>
Signed-off-by: Robert Love <robert.w.love@intel.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
2009-10-21 23:28:30 +00:00
|
|
|
if (rdata->rp_state == RPORT_ST_RESTART)
|
|
|
|
FC_RPORT_DBG(rdata, "Port in Restart state, deleting\n");
|
|
|
|
else
|
|
|
|
fc_rport_enter_logo(rdata);
|
2008-12-09 23:10:17 +00:00
|
|
|
|
|
|
|
/*
|
2009-07-30 00:04:43 +00:00
|
|
|
* Change the state to Delete so that we discard
|
2008-12-09 23:10:17 +00:00
|
|
|
* the response.
|
|
|
|
*/
|
2009-08-25 21:00:50 +00:00
|
|
|
fc_rport_enter_delete(rdata, RPORT_EV_STOP);
|
[SCSI] libfc: Track rogue remote ports
Rogue ports are currently not tracked on any list. The only reference
to them is through any outstanding exchanges pending on the rogue ports.
If the module is removed while a retry is set on a rogue port
(say a Plogi retry for instance), this retry is not cancelled because there
is no reference to the rogue port in the discovery rports list. Thus the
local port can clean itself up, delete the exchange pool, and then the
rogue port timeout can fire and try to start up another exchange.
This patch tracks the rogue ports in a new list disc->rogue_rports. Creating
a new list instead of using the disc->rports list keeps remote port code
change to a minimum.
1) Whenever a rogue port is created, it is immediately added to the
disc->rogue_rports list.
2) When the rogues port goes to ready, it is removed from the rogue list
and the real remote port is added to the disc->rports list
3) The removal of the rogue from the disc->rogue_rports list is done in
the context of the fc_rport_work() workQ thread in discovery callback.
4) Real rports are removed from the disc->rports list like before. Lookup
is done only in the real rports list. This avoids making large changes
to the remote port code.
5) In fc_disc_stop_rports, the rogues list is traversed in addition to the
real list to stop the rogue ports and issue logoffs on them. This way, rogue
ports get cleaned up when the local port goes away.
6) rogue remote ports are not removed from the list right away, but
removed late in fc_rport_work() context, multiple threads can find the same
remote port in the list and call rport_logoff(). Rport_logoff() only
continues with the logoff if port is not in NONE state, thus preventing
multiple logoffs and multiple list deletions.
7) Since the rport is removed from the disc list at a later stage
(in the disc callback), incoming frames can find the rport even if
rport_logoff() has been called on the rport. When rport_logoff() is called,
the rport state is set to NONE, and we are trying to cancel all exchanges
and retries on that port. While in this state, if an incoming
Plogi/Prli/Logo or other frames match the rport, we should not reply
because the rport is in the NONE state. Just drop the frame, since the
rport will be deleted soon in the disc callback (fc_rport_work)
8) In fc_disc_single(), remove rport lookup and call to fc_disc_del_target.
fc_disc_single() is called from recv_rscn_req() where rport lookup
and rport_logoff is already done.
Signed-off-by: Abhijeet Joglekar <abjoglek@cisco.com>
Signed-off-by: Robert Love <robert.w.love@intel.com>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
2009-04-21 23:27:04 +00:00
|
|
|
out:
|
[SCSI] libfc: fix free of fc_rport_priv with timer pending
Timer crashes were caused by freeing a struct fc_rport_priv
with a timer pending, causing the timer facility list to be
corrupted. This was during FC uplink flap tests with a lot
of targets.
After discovery, we were doing an PLOGI on an rdata that was
in DELETE state but not yet removed from the lookup list.
This moved the rdata from DELETE state to PLOGI state.
If the PLOGI exchange allocation failed and needed to be
retried, the timer scheduling could race with the free
being done by fc_rport_work().
When fc_rport_login() is called on a rport in DELETE state,
move it to a new state RESTART. In fc_rport_work, when
handling a LOGO, STOPPED or FAILED event, look for restart
state. In the RESTART case, don't take the rdata off the
list and after the transport remote port is deleted and
exchanges are reset, re-login to the remote port.
Note that the new RESTART state also corrects a problem we
had when re-discovering a port that had moved to DELETE state.
In that case, a new rdata was created, but the old rdata
would do an exchange manager reset affecting the FC_ID
for both the new rdata and old rdata. With the new state,
the new port isn't logged into until after any old exchanges
are reset.
Signed-off-by: Joe Eykholt <jeykholt@cisco.com>
Signed-off-by: Robert Love <robert.w.love@intel.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
2009-10-21 23:28:30 +00:00
|
|
|
mutex_unlock(&rdata->rp_mutex);
|
2008-12-09 23:10:17 +00:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2009-11-03 19:47:39 +00:00
|
|
|
* fc_rport_enter_ready() - Transition to the RPORT_ST_READY state
|
|
|
|
* @rdata: The remote port that is ready
|
2008-12-09 23:10:17 +00:00
|
|
|
*
|
|
|
|
* Locking Note: The rport lock is expected to be held before calling
|
|
|
|
* this routine.
|
|
|
|
*/
|
2009-08-25 21:00:50 +00:00
|
|
|
static void fc_rport_enter_ready(struct fc_rport_priv *rdata)
|
2008-12-09 23:10:17 +00:00
|
|
|
{
|
2009-08-25 21:00:50 +00:00
|
|
|
fc_rport_state_enter(rdata, RPORT_ST_READY);
|
2008-12-09 23:10:17 +00:00
|
|
|
|
2009-08-25 21:00:50 +00:00
|
|
|
FC_RPORT_DBG(rdata, "Port is Ready\n");
|
2008-12-09 23:10:17 +00:00
|
|
|
|
2009-07-30 00:04:49 +00:00
|
|
|
if (rdata->event == RPORT_EV_NONE)
|
|
|
|
queue_work(rport_event_queue, &rdata->event_work);
|
2009-08-25 21:01:12 +00:00
|
|
|
rdata->event = RPORT_EV_READY;
|
2008-12-09 23:10:17 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2009-11-03 19:47:39 +00:00
|
|
|
* fc_rport_timeout() - Handler for the retry_work timer
|
|
|
|
* @work: Handle to the remote port that has timed out
|
2008-12-09 23:10:17 +00:00
|
|
|
*
|
|
|
|
* Locking Note: Called without the rport lock held. This
|
|
|
|
* function will hold the rport lock, call an _enter_*
|
|
|
|
* function and then unlock the rport.
|
|
|
|
*/
|
|
|
|
static void fc_rport_timeout(struct work_struct *work)
|
|
|
|
{
|
2009-08-25 21:00:34 +00:00
|
|
|
struct fc_rport_priv *rdata =
|
|
|
|
container_of(work, struct fc_rport_priv, retry_work.work);
|
2008-12-09 23:10:17 +00:00
|
|
|
|
|
|
|
mutex_lock(&rdata->rp_mutex);
|
|
|
|
|
|
|
|
switch (rdata->rp_state) {
|
|
|
|
case RPORT_ST_PLOGI:
|
2009-08-25 21:00:50 +00:00
|
|
|
fc_rport_enter_plogi(rdata);
|
2008-12-09 23:10:17 +00:00
|
|
|
break;
|
|
|
|
case RPORT_ST_PRLI:
|
2009-08-25 21:00:50 +00:00
|
|
|
fc_rport_enter_prli(rdata);
|
2008-12-09 23:10:17 +00:00
|
|
|
break;
|
|
|
|
case RPORT_ST_RTV:
|
2009-08-25 21:00:50 +00:00
|
|
|
fc_rport_enter_rtv(rdata);
|
2008-12-09 23:10:17 +00:00
|
|
|
break;
|
|
|
|
case RPORT_ST_LOGO:
|
2009-08-25 21:00:50 +00:00
|
|
|
fc_rport_enter_logo(rdata);
|
2008-12-09 23:10:17 +00:00
|
|
|
break;
|
2009-08-25 21:03:47 +00:00
|
|
|
case RPORT_ST_ADISC:
|
|
|
|
fc_rport_enter_adisc(rdata);
|
|
|
|
break;
|
2008-12-09 23:10:17 +00:00
|
|
|
case RPORT_ST_READY:
|
|
|
|
case RPORT_ST_INIT:
|
2009-07-30 00:04:43 +00:00
|
|
|
case RPORT_ST_DELETE:
|
[SCSI] libfc: fix free of fc_rport_priv with timer pending
Timer crashes were caused by freeing a struct fc_rport_priv
with a timer pending, causing the timer facility list to be
corrupted. This was during FC uplink flap tests with a lot
of targets.
After discovery, we were doing an PLOGI on an rdata that was
in DELETE state but not yet removed from the lookup list.
This moved the rdata from DELETE state to PLOGI state.
If the PLOGI exchange allocation failed and needed to be
retried, the timer scheduling could race with the free
being done by fc_rport_work().
When fc_rport_login() is called on a rport in DELETE state,
move it to a new state RESTART. In fc_rport_work, when
handling a LOGO, STOPPED or FAILED event, look for restart
state. In the RESTART case, don't take the rdata off the
list and after the transport remote port is deleted and
exchanges are reset, re-login to the remote port.
Note that the new RESTART state also corrects a problem we
had when re-discovering a port that had moved to DELETE state.
In that case, a new rdata was created, but the old rdata
would do an exchange manager reset affecting the FC_ID
for both the new rdata and old rdata. With the new state,
the new port isn't logged into until after any old exchanges
are reset.
Signed-off-by: Joe Eykholt <jeykholt@cisco.com>
Signed-off-by: Robert Love <robert.w.love@intel.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
2009-10-21 23:28:30 +00:00
|
|
|
case RPORT_ST_RESTART:
|
2008-12-09 23:10:17 +00:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
mutex_unlock(&rdata->rp_mutex);
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2009-02-27 18:55:45 +00:00
|
|
|
* fc_rport_error() - Error handler, called once retries have been exhausted
|
2009-11-03 19:47:39 +00:00
|
|
|
* @rdata: The remote port the error is happened on
|
|
|
|
* @fp: The error code encapsulated in a frame pointer
|
2008-12-09 23:10:17 +00:00
|
|
|
*
|
|
|
|
* Locking Note: The rport lock is expected to be held before
|
|
|
|
* calling this routine
|
|
|
|
*/
|
2009-08-25 21:00:50 +00:00
|
|
|
static void fc_rport_error(struct fc_rport_priv *rdata, struct fc_frame *fp)
|
2008-12-09 23:10:17 +00:00
|
|
|
{
|
2009-08-25 21:00:50 +00:00
|
|
|
FC_RPORT_DBG(rdata, "Error %ld in state %s, retries %d\n",
|
2009-08-25 21:01:39 +00:00
|
|
|
IS_ERR(fp) ? -PTR_ERR(fp) : 0,
|
|
|
|
fc_rport_state(rdata), rdata->retries);
|
2008-12-09 23:10:17 +00:00
|
|
|
|
2009-02-27 18:55:02 +00:00
|
|
|
switch (rdata->rp_state) {
|
|
|
|
case RPORT_ST_PLOGI:
|
|
|
|
case RPORT_ST_LOGO:
|
2009-08-25 21:00:50 +00:00
|
|
|
fc_rport_enter_delete(rdata, RPORT_EV_FAILED);
|
2009-02-27 18:55:02 +00:00
|
|
|
break;
|
|
|
|
case RPORT_ST_RTV:
|
2009-08-25 21:00:50 +00:00
|
|
|
fc_rport_enter_ready(rdata);
|
2009-02-27 18:55:02 +00:00
|
|
|
break;
|
2009-08-25 21:03:47 +00:00
|
|
|
case RPORT_ST_PRLI:
|
|
|
|
case RPORT_ST_ADISC:
|
|
|
|
fc_rport_enter_logo(rdata);
|
|
|
|
break;
|
2009-07-30 00:04:43 +00:00
|
|
|
case RPORT_ST_DELETE:
|
[SCSI] libfc: fix free of fc_rport_priv with timer pending
Timer crashes were caused by freeing a struct fc_rport_priv
with a timer pending, causing the timer facility list to be
corrupted. This was during FC uplink flap tests with a lot
of targets.
After discovery, we were doing an PLOGI on an rdata that was
in DELETE state but not yet removed from the lookup list.
This moved the rdata from DELETE state to PLOGI state.
If the PLOGI exchange allocation failed and needed to be
retried, the timer scheduling could race with the free
being done by fc_rport_work().
When fc_rport_login() is called on a rport in DELETE state,
move it to a new state RESTART. In fc_rport_work, when
handling a LOGO, STOPPED or FAILED event, look for restart
state. In the RESTART case, don't take the rdata off the
list and after the transport remote port is deleted and
exchanges are reset, re-login to the remote port.
Note that the new RESTART state also corrects a problem we
had when re-discovering a port that had moved to DELETE state.
In that case, a new rdata was created, but the old rdata
would do an exchange manager reset affecting the FC_ID
for both the new rdata and old rdata. With the new state,
the new port isn't logged into until after any old exchanges
are reset.
Signed-off-by: Joe Eykholt <jeykholt@cisco.com>
Signed-off-by: Robert Love <robert.w.love@intel.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
2009-10-21 23:28:30 +00:00
|
|
|
case RPORT_ST_RESTART:
|
2009-02-27 18:55:02 +00:00
|
|
|
case RPORT_ST_READY:
|
|
|
|
case RPORT_ST_INIT:
|
|
|
|
break;
|
2008-12-09 23:10:17 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2009-02-27 18:55:02 +00:00
|
|
|
/**
|
2009-11-03 19:47:39 +00:00
|
|
|
* fc_rport_error_retry() - Handler for remote port state retries
|
|
|
|
* @rdata: The remote port whose state is to be retried
|
|
|
|
* @fp: The error code encapsulated in a frame pointer
|
2009-02-27 18:55:02 +00:00
|
|
|
*
|
|
|
|
* If the error was an exchange timeout retry immediately,
|
|
|
|
* otherwise wait for E_D_TOV.
|
|
|
|
*
|
|
|
|
* Locking Note: The rport lock is expected to be held before
|
|
|
|
* calling this routine
|
|
|
|
*/
|
2009-08-25 21:00:50 +00:00
|
|
|
static void fc_rport_error_retry(struct fc_rport_priv *rdata,
|
|
|
|
struct fc_frame *fp)
|
2009-02-27 18:55:02 +00:00
|
|
|
{
|
|
|
|
unsigned long delay = FC_DEF_E_D_TOV;
|
|
|
|
|
|
|
|
/* make sure this isn't an FC_EX_CLOSED error, never retry those */
|
|
|
|
if (PTR_ERR(fp) == -FC_EX_CLOSED)
|
2009-08-25 21:00:50 +00:00
|
|
|
return fc_rport_error(rdata, fp);
|
2009-02-27 18:55:02 +00:00
|
|
|
|
2009-05-01 17:01:26 +00:00
|
|
|
if (rdata->retries < rdata->local_port->max_rport_retry_count) {
|
2009-08-25 21:00:50 +00:00
|
|
|
FC_RPORT_DBG(rdata, "Error %ld in state %s, retrying\n",
|
|
|
|
PTR_ERR(fp), fc_rport_state(rdata));
|
2009-02-27 18:55:02 +00:00
|
|
|
rdata->retries++;
|
|
|
|
/* no additional delay on exchange timeouts */
|
|
|
|
if (PTR_ERR(fp) == -FC_EX_TIMEOUT)
|
|
|
|
delay = 0;
|
|
|
|
schedule_delayed_work(&rdata->retry_work, delay);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2009-08-25 21:00:50 +00:00
|
|
|
return fc_rport_error(rdata, fp);
|
2009-02-27 18:55:02 +00:00
|
|
|
}
|
|
|
|
|
2008-12-09 23:10:17 +00:00
|
|
|
/**
|
2009-11-03 19:47:39 +00:00
|
|
|
* fc_rport_plogi_recv_resp() - Handler for ELS PLOGI responses
|
|
|
|
* @sp: The sequence the PLOGI is on
|
|
|
|
* @fp: The PLOGI response frame
|
|
|
|
* @rdata_arg: The remote port that sent the PLOGI response
|
2008-12-09 23:10:17 +00:00
|
|
|
*
|
|
|
|
* Locking Note: This function will be called without the rport lock
|
|
|
|
* held, but it will lock, call an _enter_* function or fc_rport_error
|
|
|
|
* and then unlock the rport.
|
|
|
|
*/
|
|
|
|
static void fc_rport_plogi_resp(struct fc_seq *sp, struct fc_frame *fp,
|
2009-08-25 21:00:50 +00:00
|
|
|
void *rdata_arg)
|
2008-12-09 23:10:17 +00:00
|
|
|
{
|
2009-08-25 21:00:50 +00:00
|
|
|
struct fc_rport_priv *rdata = rdata_arg;
|
2008-12-09 23:10:17 +00:00
|
|
|
struct fc_lport *lport = rdata->local_port;
|
2009-04-21 23:27:41 +00:00
|
|
|
struct fc_els_flogi *plp = NULL;
|
2008-12-09 23:10:17 +00:00
|
|
|
unsigned int tov;
|
|
|
|
u16 csp_seq;
|
|
|
|
u16 cssp_seq;
|
|
|
|
u8 op;
|
|
|
|
|
|
|
|
mutex_lock(&rdata->rp_mutex);
|
|
|
|
|
2009-08-25 21:03:21 +00:00
|
|
|
FC_RPORT_DBG(rdata, "Received a PLOGI %s\n", fc_els_resp_type(fp));
|
2008-12-09 23:10:17 +00:00
|
|
|
|
|
|
|
if (rdata->rp_state != RPORT_ST_PLOGI) {
|
2009-08-25 21:00:50 +00:00
|
|
|
FC_RPORT_DBG(rdata, "Received a PLOGI response, but in state "
|
|
|
|
"%s\n", fc_rport_state(rdata));
|
2009-04-21 23:26:58 +00:00
|
|
|
if (IS_ERR(fp))
|
|
|
|
goto err;
|
2008-12-09 23:10:17 +00:00
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
2009-04-21 23:26:58 +00:00
|
|
|
if (IS_ERR(fp)) {
|
2009-08-25 21:00:50 +00:00
|
|
|
fc_rport_error_retry(rdata, fp);
|
2009-04-21 23:26:58 +00:00
|
|
|
goto err;
|
|
|
|
}
|
|
|
|
|
2008-12-09 23:10:17 +00:00
|
|
|
op = fc_frame_payload_op(fp);
|
|
|
|
if (op == ELS_LS_ACC &&
|
|
|
|
(plp = fc_frame_payload_get(fp, sizeof(*plp))) != NULL) {
|
2009-08-25 21:01:01 +00:00
|
|
|
rdata->ids.port_name = get_unaligned_be64(&plp->fl_wwpn);
|
|
|
|
rdata->ids.node_name = get_unaligned_be64(&plp->fl_wwnn);
|
2008-12-09 23:10:17 +00:00
|
|
|
|
|
|
|
tov = ntohl(plp->fl_csp.sp_e_d_tov);
|
|
|
|
if (ntohs(plp->fl_csp.sp_features) & FC_SP_FT_EDTR)
|
|
|
|
tov /= 1000;
|
|
|
|
if (tov > rdata->e_d_tov)
|
|
|
|
rdata->e_d_tov = tov;
|
|
|
|
csp_seq = ntohs(plp->fl_csp.sp_tot_seq);
|
|
|
|
cssp_seq = ntohs(plp->fl_cssp[3 - 1].cp_con_seq);
|
|
|
|
if (cssp_seq < csp_seq)
|
|
|
|
csp_seq = cssp_seq;
|
|
|
|
rdata->max_seq = csp_seq;
|
2009-08-25 21:01:01 +00:00
|
|
|
rdata->maxframe_size = fc_plogi_get_maxframe(plp, lport->mfs);
|
2009-08-25 21:03:26 +00:00
|
|
|
fc_rport_enter_prli(rdata);
|
2008-12-09 23:10:17 +00:00
|
|
|
} else
|
2009-08-25 21:00:50 +00:00
|
|
|
fc_rport_error_retry(rdata, fp);
|
2008-12-09 23:10:17 +00:00
|
|
|
|
|
|
|
out:
|
|
|
|
fc_frame_free(fp);
|
|
|
|
err:
|
|
|
|
mutex_unlock(&rdata->rp_mutex);
|
2009-08-25 21:01:01 +00:00
|
|
|
kref_put(&rdata->kref, rdata->local_port->tt.rport_destroy);
|
2008-12-09 23:10:17 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2009-11-03 19:47:39 +00:00
|
|
|
* fc_rport_enter_plogi() - Send Port Login (PLOGI) request
|
|
|
|
* @rdata: The remote port to send a PLOGI to
|
2008-12-09 23:10:17 +00:00
|
|
|
*
|
|
|
|
* Locking Note: The rport lock is expected to be held before calling
|
|
|
|
* this routine.
|
|
|
|
*/
|
2009-08-25 21:00:50 +00:00
|
|
|
static void fc_rport_enter_plogi(struct fc_rport_priv *rdata)
|
2008-12-09 23:10:17 +00:00
|
|
|
{
|
|
|
|
struct fc_lport *lport = rdata->local_port;
|
|
|
|
struct fc_frame *fp;
|
|
|
|
|
2009-08-25 21:00:50 +00:00
|
|
|
FC_RPORT_DBG(rdata, "Port entered PLOGI state from %s state\n",
|
|
|
|
fc_rport_state(rdata));
|
2008-12-09 23:10:17 +00:00
|
|
|
|
2009-08-25 21:00:50 +00:00
|
|
|
fc_rport_state_enter(rdata, RPORT_ST_PLOGI);
|
2008-12-09 23:10:17 +00:00
|
|
|
|
2009-08-25 21:01:01 +00:00
|
|
|
rdata->maxframe_size = FC_MIN_MAX_PAYLOAD;
|
2008-12-09 23:10:17 +00:00
|
|
|
fp = fc_frame_alloc(lport, sizeof(struct fc_els_flogi));
|
|
|
|
if (!fp) {
|
2009-08-25 21:00:50 +00:00
|
|
|
fc_rport_error_retry(rdata, fp);
|
2008-12-09 23:10:17 +00:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
rdata->e_d_tov = lport->e_d_tov;
|
|
|
|
|
2009-08-25 21:01:01 +00:00
|
|
|
if (!lport->tt.elsct_send(lport, rdata->ids.port_id, fp, ELS_PLOGI,
|
2009-11-03 19:50:21 +00:00
|
|
|
fc_rport_plogi_resp, rdata,
|
|
|
|
2 * lport->r_a_tov))
|
2009-10-21 23:28:09 +00:00
|
|
|
fc_rport_error_retry(rdata, NULL);
|
2008-12-09 23:10:17 +00:00
|
|
|
else
|
2009-08-25 21:01:01 +00:00
|
|
|
kref_get(&rdata->kref);
|
2008-12-09 23:10:17 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2009-02-27 18:55:45 +00:00
|
|
|
* fc_rport_prli_resp() - Process Login (PRLI) response handler
|
2009-11-03 19:47:39 +00:00
|
|
|
* @sp: The sequence the PRLI response was on
|
|
|
|
* @fp: The PRLI response frame
|
|
|
|
* @rdata_arg: The remote port that sent the PRLI response
|
2008-12-09 23:10:17 +00:00
|
|
|
*
|
|
|
|
* Locking Note: This function will be called without the rport lock
|
|
|
|
* held, but it will lock, call an _enter_* function or fc_rport_error
|
|
|
|
* and then unlock the rport.
|
|
|
|
*/
|
|
|
|
static void fc_rport_prli_resp(struct fc_seq *sp, struct fc_frame *fp,
|
2009-08-25 21:00:50 +00:00
|
|
|
void *rdata_arg)
|
2008-12-09 23:10:17 +00:00
|
|
|
{
|
2009-08-25 21:00:50 +00:00
|
|
|
struct fc_rport_priv *rdata = rdata_arg;
|
2008-12-09 23:10:17 +00:00
|
|
|
struct {
|
|
|
|
struct fc_els_prli prli;
|
|
|
|
struct fc_els_spp spp;
|
|
|
|
} *pp;
|
|
|
|
u32 roles = FC_RPORT_ROLE_UNKNOWN;
|
|
|
|
u32 fcp_parm = 0;
|
|
|
|
u8 op;
|
|
|
|
|
|
|
|
mutex_lock(&rdata->rp_mutex);
|
|
|
|
|
2009-08-25 21:03:21 +00:00
|
|
|
FC_RPORT_DBG(rdata, "Received a PRLI %s\n", fc_els_resp_type(fp));
|
2008-12-09 23:10:17 +00:00
|
|
|
|
|
|
|
if (rdata->rp_state != RPORT_ST_PRLI) {
|
2009-08-25 21:00:50 +00:00
|
|
|
FC_RPORT_DBG(rdata, "Received a PRLI response, but in state "
|
|
|
|
"%s\n", fc_rport_state(rdata));
|
2009-04-21 23:26:58 +00:00
|
|
|
if (IS_ERR(fp))
|
|
|
|
goto err;
|
2008-12-09 23:10:17 +00:00
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
2009-04-21 23:26:58 +00:00
|
|
|
if (IS_ERR(fp)) {
|
2009-08-25 21:00:50 +00:00
|
|
|
fc_rport_error_retry(rdata, fp);
|
2009-04-21 23:26:58 +00:00
|
|
|
goto err;
|
|
|
|
}
|
|
|
|
|
2009-08-25 21:03:04 +00:00
|
|
|
/* reinitialize remote port roles */
|
|
|
|
rdata->ids.roles = FC_RPORT_ROLE_UNKNOWN;
|
|
|
|
|
2008-12-09 23:10:17 +00:00
|
|
|
op = fc_frame_payload_op(fp);
|
|
|
|
if (op == ELS_LS_ACC) {
|
|
|
|
pp = fc_frame_payload_get(fp, sizeof(*pp));
|
|
|
|
if (pp && pp->prli.prli_spp_len >= sizeof(pp->spp)) {
|
|
|
|
fcp_parm = ntohl(pp->spp.spp_params);
|
|
|
|
if (fcp_parm & FCP_SPPF_RETRY)
|
|
|
|
rdata->flags |= FC_RP_FLAGS_RETRY;
|
|
|
|
}
|
|
|
|
|
2009-08-25 21:01:01 +00:00
|
|
|
rdata->supported_classes = FC_COS_CLASS3;
|
2008-12-09 23:10:17 +00:00
|
|
|
if (fcp_parm & FCP_SPPF_INIT_FCN)
|
|
|
|
roles |= FC_RPORT_ROLE_FCP_INITIATOR;
|
|
|
|
if (fcp_parm & FCP_SPPF_TARG_FCN)
|
|
|
|
roles |= FC_RPORT_ROLE_FCP_TARGET;
|
|
|
|
|
2009-08-25 21:01:01 +00:00
|
|
|
rdata->ids.roles = roles;
|
2009-08-25 21:00:50 +00:00
|
|
|
fc_rport_enter_rtv(rdata);
|
2008-12-09 23:10:17 +00:00
|
|
|
|
|
|
|
} else {
|
2009-08-25 21:00:50 +00:00
|
|
|
FC_RPORT_DBG(rdata, "Bad ELS response for PRLI command\n");
|
|
|
|
fc_rport_enter_delete(rdata, RPORT_EV_FAILED);
|
2008-12-09 23:10:17 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
out:
|
|
|
|
fc_frame_free(fp);
|
|
|
|
err:
|
|
|
|
mutex_unlock(&rdata->rp_mutex);
|
2009-08-25 21:01:01 +00:00
|
|
|
kref_put(&rdata->kref, rdata->local_port->tt.rport_destroy);
|
2008-12-09 23:10:17 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2009-11-03 19:47:39 +00:00
|
|
|
* fc_rport_logo_resp() - Handler for logout (LOGO) responses
|
|
|
|
* @sp: The sequence the LOGO was on
|
|
|
|
* @fp: The LOGO response frame
|
|
|
|
* @rdata_arg: The remote port that sent the LOGO response
|
2008-12-09 23:10:17 +00:00
|
|
|
*
|
|
|
|
* Locking Note: This function will be called without the rport lock
|
|
|
|
* held, but it will lock, call an _enter_* function or fc_rport_error
|
|
|
|
* and then unlock the rport.
|
|
|
|
*/
|
|
|
|
static void fc_rport_logo_resp(struct fc_seq *sp, struct fc_frame *fp,
|
2009-08-25 21:00:50 +00:00
|
|
|
void *rdata_arg)
|
2008-12-09 23:10:17 +00:00
|
|
|
{
|
2009-08-25 21:00:50 +00:00
|
|
|
struct fc_rport_priv *rdata = rdata_arg;
|
2008-12-09 23:10:17 +00:00
|
|
|
u8 op;
|
|
|
|
|
|
|
|
mutex_lock(&rdata->rp_mutex);
|
|
|
|
|
2009-08-25 21:03:21 +00:00
|
|
|
FC_RPORT_DBG(rdata, "Received a LOGO %s\n", fc_els_resp_type(fp));
|
2008-12-09 23:10:17 +00:00
|
|
|
|
|
|
|
if (rdata->rp_state != RPORT_ST_LOGO) {
|
2009-08-25 21:00:50 +00:00
|
|
|
FC_RPORT_DBG(rdata, "Received a LOGO response, but in state "
|
|
|
|
"%s\n", fc_rport_state(rdata));
|
2009-04-21 23:26:58 +00:00
|
|
|
if (IS_ERR(fp))
|
|
|
|
goto err;
|
2008-12-09 23:10:17 +00:00
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
2009-04-21 23:26:58 +00:00
|
|
|
if (IS_ERR(fp)) {
|
2009-08-25 21:00:50 +00:00
|
|
|
fc_rport_error_retry(rdata, fp);
|
2009-04-21 23:26:58 +00:00
|
|
|
goto err;
|
|
|
|
}
|
|
|
|
|
2008-12-09 23:10:17 +00:00
|
|
|
op = fc_frame_payload_op(fp);
|
2009-08-25 21:03:42 +00:00
|
|
|
if (op != ELS_LS_ACC)
|
|
|
|
FC_RPORT_DBG(rdata, "Bad ELS response op %x for LOGO command\n",
|
|
|
|
op);
|
|
|
|
fc_rport_enter_delete(rdata, RPORT_EV_LOGO);
|
2008-12-09 23:10:17 +00:00
|
|
|
|
|
|
|
out:
|
|
|
|
fc_frame_free(fp);
|
|
|
|
err:
|
|
|
|
mutex_unlock(&rdata->rp_mutex);
|
2009-08-25 21:01:01 +00:00
|
|
|
kref_put(&rdata->kref, rdata->local_port->tt.rport_destroy);
|
2008-12-09 23:10:17 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2009-11-03 19:47:39 +00:00
|
|
|
* fc_rport_enter_prli() - Send Process Login (PRLI) request
|
|
|
|
* @rdata: The remote port to send the PRLI request to
|
2008-12-09 23:10:17 +00:00
|
|
|
*
|
|
|
|
* Locking Note: The rport lock is expected to be held before calling
|
|
|
|
* this routine.
|
|
|
|
*/
|
2009-08-25 21:00:50 +00:00
|
|
|
static void fc_rport_enter_prli(struct fc_rport_priv *rdata)
|
2008-12-09 23:10:17 +00:00
|
|
|
{
|
|
|
|
struct fc_lport *lport = rdata->local_port;
|
|
|
|
struct {
|
|
|
|
struct fc_els_prli prli;
|
|
|
|
struct fc_els_spp spp;
|
|
|
|
} *pp;
|
|
|
|
struct fc_frame *fp;
|
|
|
|
|
2009-08-25 21:03:26 +00:00
|
|
|
/*
|
|
|
|
* If the rport is one of the well known addresses
|
|
|
|
* we skip PRLI and RTV and go straight to READY.
|
|
|
|
*/
|
|
|
|
if (rdata->ids.port_id >= FC_FID_DOM_MGR) {
|
|
|
|
fc_rport_enter_ready(rdata);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2009-08-25 21:00:50 +00:00
|
|
|
FC_RPORT_DBG(rdata, "Port entered PRLI state from %s state\n",
|
|
|
|
fc_rport_state(rdata));
|
2008-12-09 23:10:17 +00:00
|
|
|
|
2009-08-25 21:00:50 +00:00
|
|
|
fc_rport_state_enter(rdata, RPORT_ST_PRLI);
|
2008-12-09 23:10:17 +00:00
|
|
|
|
|
|
|
fp = fc_frame_alloc(lport, sizeof(*pp));
|
|
|
|
if (!fp) {
|
2009-08-25 21:00:50 +00:00
|
|
|
fc_rport_error_retry(rdata, fp);
|
2008-12-09 23:10:17 +00:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2009-08-25 21:01:01 +00:00
|
|
|
if (!lport->tt.elsct_send(lport, rdata->ids.port_id, fp, ELS_PRLI,
|
2009-11-03 19:50:21 +00:00
|
|
|
fc_rport_prli_resp, rdata,
|
|
|
|
2 * lport->r_a_tov))
|
2009-10-21 23:28:09 +00:00
|
|
|
fc_rport_error_retry(rdata, NULL);
|
2008-12-09 23:10:17 +00:00
|
|
|
else
|
2009-08-25 21:01:01 +00:00
|
|
|
kref_get(&rdata->kref);
|
2008-12-09 23:10:17 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2009-11-03 19:47:39 +00:00
|
|
|
* fc_rport_els_rtv_resp() - Handler for Request Timeout Value (RTV) responses
|
|
|
|
* @sp: The sequence the RTV was on
|
|
|
|
* @fp: The RTV response frame
|
|
|
|
* @rdata_arg: The remote port that sent the RTV response
|
2008-12-09 23:10:17 +00:00
|
|
|
*
|
|
|
|
* Many targets don't seem to support this.
|
|
|
|
*
|
|
|
|
* Locking Note: This function will be called without the rport lock
|
|
|
|
* held, but it will lock, call an _enter_* function or fc_rport_error
|
|
|
|
* and then unlock the rport.
|
|
|
|
*/
|
|
|
|
static void fc_rport_rtv_resp(struct fc_seq *sp, struct fc_frame *fp,
|
2009-08-25 21:00:50 +00:00
|
|
|
void *rdata_arg)
|
2008-12-09 23:10:17 +00:00
|
|
|
{
|
2009-08-25 21:00:50 +00:00
|
|
|
struct fc_rport_priv *rdata = rdata_arg;
|
2008-12-09 23:10:17 +00:00
|
|
|
u8 op;
|
|
|
|
|
|
|
|
mutex_lock(&rdata->rp_mutex);
|
|
|
|
|
2009-08-25 21:03:21 +00:00
|
|
|
FC_RPORT_DBG(rdata, "Received a RTV %s\n", fc_els_resp_type(fp));
|
2008-12-09 23:10:17 +00:00
|
|
|
|
|
|
|
if (rdata->rp_state != RPORT_ST_RTV) {
|
2009-08-25 21:00:50 +00:00
|
|
|
FC_RPORT_DBG(rdata, "Received a RTV response, but in state "
|
|
|
|
"%s\n", fc_rport_state(rdata));
|
2009-04-21 23:26:58 +00:00
|
|
|
if (IS_ERR(fp))
|
|
|
|
goto err;
|
2008-12-09 23:10:17 +00:00
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
2009-04-21 23:26:58 +00:00
|
|
|
if (IS_ERR(fp)) {
|
2009-08-25 21:00:50 +00:00
|
|
|
fc_rport_error(rdata, fp);
|
2009-04-21 23:26:58 +00:00
|
|
|
goto err;
|
|
|
|
}
|
|
|
|
|
2008-12-09 23:10:17 +00:00
|
|
|
op = fc_frame_payload_op(fp);
|
|
|
|
if (op == ELS_LS_ACC) {
|
|
|
|
struct fc_els_rtv_acc *rtv;
|
|
|
|
u32 toq;
|
|
|
|
u32 tov;
|
|
|
|
|
|
|
|
rtv = fc_frame_payload_get(fp, sizeof(*rtv));
|
|
|
|
if (rtv) {
|
|
|
|
toq = ntohl(rtv->rtv_toq);
|
|
|
|
tov = ntohl(rtv->rtv_r_a_tov);
|
|
|
|
if (tov == 0)
|
|
|
|
tov = 1;
|
|
|
|
rdata->r_a_tov = tov;
|
|
|
|
tov = ntohl(rtv->rtv_e_d_tov);
|
|
|
|
if (toq & FC_ELS_RTV_EDRES)
|
|
|
|
tov /= 1000000;
|
|
|
|
if (tov == 0)
|
|
|
|
tov = 1;
|
|
|
|
rdata->e_d_tov = tov;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2009-08-25 21:00:50 +00:00
|
|
|
fc_rport_enter_ready(rdata);
|
2008-12-09 23:10:17 +00:00
|
|
|
|
|
|
|
out:
|
|
|
|
fc_frame_free(fp);
|
|
|
|
err:
|
|
|
|
mutex_unlock(&rdata->rp_mutex);
|
2009-08-25 21:01:01 +00:00
|
|
|
kref_put(&rdata->kref, rdata->local_port->tt.rport_destroy);
|
2008-12-09 23:10:17 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2009-11-03 19:47:39 +00:00
|
|
|
* fc_rport_enter_rtv() - Send Request Timeout Value (RTV) request
|
|
|
|
* @rdata: The remote port to send the RTV request to
|
2008-12-09 23:10:17 +00:00
|
|
|
*
|
|
|
|
* Locking Note: The rport lock is expected to be held before calling
|
|
|
|
* this routine.
|
|
|
|
*/
|
2009-08-25 21:00:50 +00:00
|
|
|
static void fc_rport_enter_rtv(struct fc_rport_priv *rdata)
|
2008-12-09 23:10:17 +00:00
|
|
|
{
|
|
|
|
struct fc_frame *fp;
|
|
|
|
struct fc_lport *lport = rdata->local_port;
|
|
|
|
|
2009-08-25 21:00:50 +00:00
|
|
|
FC_RPORT_DBG(rdata, "Port entered RTV state from %s state\n",
|
|
|
|
fc_rport_state(rdata));
|
2008-12-09 23:10:17 +00:00
|
|
|
|
2009-08-25 21:00:50 +00:00
|
|
|
fc_rport_state_enter(rdata, RPORT_ST_RTV);
|
2008-12-09 23:10:17 +00:00
|
|
|
|
|
|
|
fp = fc_frame_alloc(lport, sizeof(struct fc_els_rtv));
|
|
|
|
if (!fp) {
|
2009-08-25 21:00:50 +00:00
|
|
|
fc_rport_error_retry(rdata, fp);
|
2008-12-09 23:10:17 +00:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2009-08-25 21:01:01 +00:00
|
|
|
if (!lport->tt.elsct_send(lport, rdata->ids.port_id, fp, ELS_RTV,
|
2009-11-03 19:50:21 +00:00
|
|
|
fc_rport_rtv_resp, rdata,
|
|
|
|
2 * lport->r_a_tov))
|
2009-10-21 23:28:09 +00:00
|
|
|
fc_rport_error_retry(rdata, NULL);
|
2008-12-09 23:10:17 +00:00
|
|
|
else
|
2009-08-25 21:01:01 +00:00
|
|
|
kref_get(&rdata->kref);
|
2008-12-09 23:10:17 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2009-11-03 19:47:39 +00:00
|
|
|
* fc_rport_enter_logo() - Send a logout (LOGO) request
|
|
|
|
* @rdata: The remote port to send the LOGO request to
|
2008-12-09 23:10:17 +00:00
|
|
|
*
|
|
|
|
* Locking Note: The rport lock is expected to be held before calling
|
|
|
|
* this routine.
|
|
|
|
*/
|
2009-08-25 21:00:50 +00:00
|
|
|
static void fc_rport_enter_logo(struct fc_rport_priv *rdata)
|
2008-12-09 23:10:17 +00:00
|
|
|
{
|
|
|
|
struct fc_lport *lport = rdata->local_port;
|
|
|
|
struct fc_frame *fp;
|
|
|
|
|
2009-08-25 21:00:50 +00:00
|
|
|
FC_RPORT_DBG(rdata, "Port entered LOGO state from %s state\n",
|
|
|
|
fc_rport_state(rdata));
|
2008-12-09 23:10:17 +00:00
|
|
|
|
2009-08-25 21:00:50 +00:00
|
|
|
fc_rport_state_enter(rdata, RPORT_ST_LOGO);
|
2008-12-09 23:10:17 +00:00
|
|
|
|
|
|
|
fp = fc_frame_alloc(lport, sizeof(struct fc_els_logo));
|
|
|
|
if (!fp) {
|
2009-08-25 21:00:50 +00:00
|
|
|
fc_rport_error_retry(rdata, fp);
|
2008-12-09 23:10:17 +00:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2009-08-25 21:01:01 +00:00
|
|
|
if (!lport->tt.elsct_send(lport, rdata->ids.port_id, fp, ELS_LOGO,
|
2009-11-03 19:50:21 +00:00
|
|
|
fc_rport_logo_resp, rdata,
|
|
|
|
2 * lport->r_a_tov))
|
2009-10-21 23:28:09 +00:00
|
|
|
fc_rport_error_retry(rdata, NULL);
|
2008-12-09 23:10:17 +00:00
|
|
|
else
|
2009-08-25 21:01:01 +00:00
|
|
|
kref_get(&rdata->kref);
|
2008-12-09 23:10:17 +00:00
|
|
|
}
|
|
|
|
|
2009-08-25 21:03:47 +00:00
|
|
|
/**
|
2009-11-03 19:47:39 +00:00
|
|
|
* fc_rport_els_adisc_resp() - Handler for Address Discovery (ADISC) responses
|
|
|
|
* @sp: The sequence the ADISC response was on
|
|
|
|
* @fp: The ADISC response frame
|
|
|
|
* @rdata_arg: The remote port that sent the ADISC response
|
2009-08-25 21:03:47 +00:00
|
|
|
*
|
|
|
|
* Locking Note: This function will be called without the rport lock
|
|
|
|
* held, but it will lock, call an _enter_* function or fc_rport_error
|
|
|
|
* and then unlock the rport.
|
|
|
|
*/
|
|
|
|
static void fc_rport_adisc_resp(struct fc_seq *sp, struct fc_frame *fp,
|
2009-11-03 19:47:39 +00:00
|
|
|
void *rdata_arg)
|
2009-08-25 21:03:47 +00:00
|
|
|
{
|
|
|
|
struct fc_rport_priv *rdata = rdata_arg;
|
|
|
|
struct fc_els_adisc *adisc;
|
|
|
|
u8 op;
|
|
|
|
|
|
|
|
mutex_lock(&rdata->rp_mutex);
|
|
|
|
|
|
|
|
FC_RPORT_DBG(rdata, "Received a ADISC response\n");
|
|
|
|
|
|
|
|
if (rdata->rp_state != RPORT_ST_ADISC) {
|
|
|
|
FC_RPORT_DBG(rdata, "Received a ADISC resp but in state %s\n",
|
|
|
|
fc_rport_state(rdata));
|
|
|
|
if (IS_ERR(fp))
|
|
|
|
goto err;
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (IS_ERR(fp)) {
|
|
|
|
fc_rport_error(rdata, fp);
|
|
|
|
goto err;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* If address verification failed. Consider us logged out of the rport.
|
|
|
|
* Since the rport is still in discovery, we want to be
|
|
|
|
* logged in, so go to PLOGI state. Otherwise, go back to READY.
|
|
|
|
*/
|
|
|
|
op = fc_frame_payload_op(fp);
|
|
|
|
adisc = fc_frame_payload_get(fp, sizeof(*adisc));
|
|
|
|
if (op != ELS_LS_ACC || !adisc ||
|
|
|
|
ntoh24(adisc->adisc_port_id) != rdata->ids.port_id ||
|
|
|
|
get_unaligned_be64(&adisc->adisc_wwpn) != rdata->ids.port_name ||
|
|
|
|
get_unaligned_be64(&adisc->adisc_wwnn) != rdata->ids.node_name) {
|
|
|
|
FC_RPORT_DBG(rdata, "ADISC error or mismatch\n");
|
|
|
|
fc_rport_enter_plogi(rdata);
|
|
|
|
} else {
|
|
|
|
FC_RPORT_DBG(rdata, "ADISC OK\n");
|
|
|
|
fc_rport_enter_ready(rdata);
|
|
|
|
}
|
|
|
|
out:
|
|
|
|
fc_frame_free(fp);
|
|
|
|
err:
|
|
|
|
mutex_unlock(&rdata->rp_mutex);
|
|
|
|
kref_put(&rdata->kref, rdata->local_port->tt.rport_destroy);
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2009-11-03 19:47:39 +00:00
|
|
|
* fc_rport_enter_adisc() - Send Address Discover (ADISC) request
|
|
|
|
* @rdata: The remote port to send the ADISC request to
|
2009-08-25 21:03:47 +00:00
|
|
|
*
|
|
|
|
* Locking Note: The rport lock is expected to be held before calling
|
|
|
|
* this routine.
|
|
|
|
*/
|
|
|
|
static void fc_rport_enter_adisc(struct fc_rport_priv *rdata)
|
|
|
|
{
|
|
|
|
struct fc_lport *lport = rdata->local_port;
|
|
|
|
struct fc_frame *fp;
|
|
|
|
|
|
|
|
FC_RPORT_DBG(rdata, "sending ADISC from %s state\n",
|
|
|
|
fc_rport_state(rdata));
|
|
|
|
|
|
|
|
fc_rport_state_enter(rdata, RPORT_ST_ADISC);
|
|
|
|
|
|
|
|
fp = fc_frame_alloc(lport, sizeof(struct fc_els_adisc));
|
|
|
|
if (!fp) {
|
|
|
|
fc_rport_error_retry(rdata, fp);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
if (!lport->tt.elsct_send(lport, rdata->ids.port_id, fp, ELS_ADISC,
|
2009-11-03 19:50:21 +00:00
|
|
|
fc_rport_adisc_resp, rdata,
|
|
|
|
2 * lport->r_a_tov))
|
2009-10-21 23:28:09 +00:00
|
|
|
fc_rport_error_retry(rdata, NULL);
|
2009-08-25 21:03:47 +00:00
|
|
|
else
|
|
|
|
kref_get(&rdata->kref);
|
|
|
|
}
|
|
|
|
|
2009-08-25 21:03:52 +00:00
|
|
|
/**
|
2009-11-03 19:47:39 +00:00
|
|
|
* fc_rport_recv_adisc_req() - Handler for Address Discovery (ADISC) requests
|
|
|
|
* @rdata: The remote port that sent the ADISC request
|
|
|
|
* @sp: The sequence the ADISC request was on
|
|
|
|
* @in_fp: The ADISC request frame
|
2009-08-25 21:03:52 +00:00
|
|
|
*
|
|
|
|
* Locking Note: Called with the lport and rport locks held.
|
|
|
|
*/
|
|
|
|
static void fc_rport_recv_adisc_req(struct fc_rport_priv *rdata,
|
|
|
|
struct fc_seq *sp, struct fc_frame *in_fp)
|
|
|
|
{
|
|
|
|
struct fc_lport *lport = rdata->local_port;
|
|
|
|
struct fc_frame *fp;
|
|
|
|
struct fc_exch *ep = fc_seq_exch(sp);
|
|
|
|
struct fc_els_adisc *adisc;
|
|
|
|
struct fc_seq_els_data rjt_data;
|
|
|
|
u32 f_ctl;
|
|
|
|
|
|
|
|
FC_RPORT_DBG(rdata, "Received ADISC request\n");
|
|
|
|
|
|
|
|
adisc = fc_frame_payload_get(in_fp, sizeof(*adisc));
|
|
|
|
if (!adisc) {
|
|
|
|
rjt_data.fp = NULL;
|
|
|
|
rjt_data.reason = ELS_RJT_PROT;
|
|
|
|
rjt_data.explan = ELS_EXPL_INV_LEN;
|
|
|
|
lport->tt.seq_els_rsp_send(sp, ELS_LS_RJT, &rjt_data);
|
|
|
|
goto drop;
|
|
|
|
}
|
|
|
|
|
|
|
|
fp = fc_frame_alloc(lport, sizeof(*adisc));
|
|
|
|
if (!fp)
|
|
|
|
goto drop;
|
|
|
|
fc_adisc_fill(lport, fp);
|
|
|
|
adisc = fc_frame_payload_get(fp, sizeof(*adisc));
|
|
|
|
adisc->adisc_cmd = ELS_LS_ACC;
|
|
|
|
sp = lport->tt.seq_start_next(sp);
|
|
|
|
f_ctl = FC_FC_EX_CTX | FC_FC_LAST_SEQ | FC_FC_END_SEQ | FC_FC_SEQ_INIT;
|
|
|
|
fc_fill_fc_hdr(fp, FC_RCTL_ELS_REP, ep->did, ep->sid,
|
|
|
|
FC_TYPE_ELS, f_ctl, 0);
|
|
|
|
lport->tt.seq_send(lport, sp, fp);
|
|
|
|
drop:
|
|
|
|
fc_frame_free(in_fp);
|
|
|
|
}
|
|
|
|
|
2009-11-20 22:55:24 +00:00
|
|
|
/**
|
|
|
|
* fc_rport_recv_rls_req() - Handle received Read Link Status request
|
|
|
|
* @rdata: The remote port that sent the RLS request
|
|
|
|
* @sp: The sequence that the RLS was on
|
|
|
|
* @rx_fp: The PRLI request frame
|
|
|
|
*
|
|
|
|
* Locking Note: The rport lock is expected to be held before calling
|
|
|
|
* this function.
|
|
|
|
*/
|
|
|
|
static void fc_rport_recv_rls_req(struct fc_rport_priv *rdata,
|
|
|
|
struct fc_seq *sp, struct fc_frame *rx_fp)
|
|
|
|
|
|
|
|
{
|
|
|
|
struct fc_lport *lport = rdata->local_port;
|
|
|
|
struct fc_frame *fp;
|
|
|
|
struct fc_exch *ep = fc_seq_exch(sp);
|
|
|
|
struct fc_els_rls *rls;
|
|
|
|
struct fc_els_rls_resp *rsp;
|
|
|
|
struct fc_els_lesb *lesb;
|
|
|
|
struct fc_seq_els_data rjt_data;
|
|
|
|
struct fc_host_statistics *hst;
|
|
|
|
u32 f_ctl;
|
|
|
|
|
|
|
|
FC_RPORT_DBG(rdata, "Received RLS request while in state %s\n",
|
|
|
|
fc_rport_state(rdata));
|
|
|
|
|
|
|
|
rls = fc_frame_payload_get(rx_fp, sizeof(*rls));
|
|
|
|
if (!rls) {
|
|
|
|
rjt_data.reason = ELS_RJT_PROT;
|
|
|
|
rjt_data.explan = ELS_EXPL_INV_LEN;
|
|
|
|
goto out_rjt;
|
|
|
|
}
|
|
|
|
|
|
|
|
fp = fc_frame_alloc(lport, sizeof(*rsp));
|
|
|
|
if (!fp) {
|
|
|
|
rjt_data.reason = ELS_RJT_UNAB;
|
|
|
|
rjt_data.explan = ELS_EXPL_INSUF_RES;
|
|
|
|
goto out_rjt;
|
|
|
|
}
|
|
|
|
|
|
|
|
rsp = fc_frame_payload_get(fp, sizeof(*rsp));
|
|
|
|
memset(rsp, 0, sizeof(*rsp));
|
|
|
|
rsp->rls_cmd = ELS_LS_ACC;
|
|
|
|
lesb = &rsp->rls_lesb;
|
|
|
|
if (lport->tt.get_lesb) {
|
|
|
|
/* get LESB from LLD if it supports it */
|
|
|
|
lport->tt.get_lesb(lport, lesb);
|
|
|
|
} else {
|
|
|
|
fc_get_host_stats(lport->host);
|
|
|
|
hst = &lport->host_stats;
|
|
|
|
lesb->lesb_link_fail = htonl(hst->link_failure_count);
|
|
|
|
lesb->lesb_sync_loss = htonl(hst->loss_of_sync_count);
|
|
|
|
lesb->lesb_sig_loss = htonl(hst->loss_of_signal_count);
|
|
|
|
lesb->lesb_prim_err = htonl(hst->prim_seq_protocol_err_count);
|
|
|
|
lesb->lesb_inv_word = htonl(hst->invalid_tx_word_count);
|
|
|
|
lesb->lesb_inv_crc = htonl(hst->invalid_crc_count);
|
|
|
|
}
|
|
|
|
|
|
|
|
sp = lport->tt.seq_start_next(sp);
|
|
|
|
f_ctl = FC_FC_EX_CTX | FC_FC_LAST_SEQ | FC_FC_END_SEQ;
|
|
|
|
fc_fill_fc_hdr(fp, FC_RCTL_ELS_REP, ep->did, ep->sid,
|
|
|
|
FC_TYPE_ELS, f_ctl, 0);
|
|
|
|
lport->tt.seq_send(lport, sp, fp);
|
|
|
|
goto out;
|
|
|
|
|
|
|
|
out_rjt:
|
|
|
|
rjt_data.fp = NULL;
|
|
|
|
lport->tt.seq_els_rsp_send(sp, ELS_LS_RJT, &rjt_data);
|
|
|
|
out:
|
|
|
|
fc_frame_free(rx_fp);
|
|
|
|
}
|
|
|
|
|
2008-12-09 23:10:17 +00:00
|
|
|
/**
|
2009-11-03 19:47:39 +00:00
|
|
|
* fc_rport_recv_els_req() - Handler for validated ELS requests
|
|
|
|
* @lport: The local port that received the ELS request
|
|
|
|
* @sp: The sequence that the ELS request was on
|
|
|
|
* @fp: The ELS request frame
|
2009-08-25 21:03:31 +00:00
|
|
|
*
|
|
|
|
* Handle incoming ELS requests that require port login.
|
|
|
|
* The ELS opcode has already been validated by the caller.
|
2008-12-09 23:10:17 +00:00
|
|
|
*
|
2009-08-25 21:03:10 +00:00
|
|
|
* Locking Note: Called with the lport lock held.
|
2008-12-09 23:10:17 +00:00
|
|
|
*/
|
2009-08-25 21:03:31 +00:00
|
|
|
static void fc_rport_recv_els_req(struct fc_lport *lport,
|
|
|
|
struct fc_seq *sp, struct fc_frame *fp)
|
2008-12-09 23:10:17 +00:00
|
|
|
{
|
2009-08-25 21:03:10 +00:00
|
|
|
struct fc_rport_priv *rdata;
|
2008-12-09 23:10:17 +00:00
|
|
|
struct fc_frame_header *fh;
|
|
|
|
struct fc_seq_els_data els_data;
|
|
|
|
|
|
|
|
els_data.fp = NULL;
|
2009-08-25 21:03:31 +00:00
|
|
|
els_data.reason = ELS_RJT_UNAB;
|
|
|
|
els_data.explan = ELS_EXPL_PLOGI_REQD;
|
2009-08-25 21:03:26 +00:00
|
|
|
|
2008-12-09 23:10:17 +00:00
|
|
|
fh = fc_frame_header_get(fp);
|
|
|
|
|
2009-08-25 21:03:15 +00:00
|
|
|
mutex_lock(&lport->disc.disc_mutex);
|
2009-08-25 21:03:31 +00:00
|
|
|
rdata = lport->tt.rport_lookup(lport, ntoh24(fh->fh_s_id));
|
2009-08-25 21:03:10 +00:00
|
|
|
if (!rdata) {
|
2009-08-25 21:03:15 +00:00
|
|
|
mutex_unlock(&lport->disc.disc_mutex);
|
2009-08-25 21:03:31 +00:00
|
|
|
goto reject;
|
2009-08-25 21:03:10 +00:00
|
|
|
}
|
|
|
|
mutex_lock(&rdata->rp_mutex);
|
2009-08-25 21:03:15 +00:00
|
|
|
mutex_unlock(&lport->disc.disc_mutex);
|
2009-08-25 21:03:10 +00:00
|
|
|
|
2009-08-25 21:03:31 +00:00
|
|
|
switch (rdata->rp_state) {
|
|
|
|
case RPORT_ST_PRLI:
|
|
|
|
case RPORT_ST_RTV:
|
|
|
|
case RPORT_ST_READY:
|
2009-08-25 21:03:47 +00:00
|
|
|
case RPORT_ST_ADISC:
|
2009-08-25 21:03:31 +00:00
|
|
|
break;
|
|
|
|
default:
|
|
|
|
mutex_unlock(&rdata->rp_mutex);
|
|
|
|
goto reject;
|
|
|
|
}
|
|
|
|
|
|
|
|
switch (fc_frame_payload_op(fp)) {
|
2009-08-25 21:03:10 +00:00
|
|
|
case ELS_PRLI:
|
|
|
|
fc_rport_recv_prli_req(rdata, sp, fp);
|
|
|
|
break;
|
|
|
|
case ELS_PRLO:
|
|
|
|
fc_rport_recv_prlo_req(rdata, sp, fp);
|
|
|
|
break;
|
2009-08-25 21:03:52 +00:00
|
|
|
case ELS_ADISC:
|
|
|
|
fc_rport_recv_adisc_req(rdata, sp, fp);
|
|
|
|
break;
|
2009-08-25 21:03:10 +00:00
|
|
|
case ELS_RRQ:
|
|
|
|
els_data.fp = fp;
|
|
|
|
lport->tt.seq_els_rsp_send(sp, ELS_RRQ, &els_data);
|
|
|
|
break;
|
|
|
|
case ELS_REC:
|
|
|
|
els_data.fp = fp;
|
|
|
|
lport->tt.seq_els_rsp_send(sp, ELS_REC, &els_data);
|
|
|
|
break;
|
2009-11-20 22:55:24 +00:00
|
|
|
case ELS_RLS:
|
|
|
|
fc_rport_recv_rls_req(rdata, sp, fp);
|
|
|
|
break;
|
2009-08-25 21:03:10 +00:00
|
|
|
default:
|
2009-08-25 21:03:31 +00:00
|
|
|
fc_frame_free(fp); /* can't happen */
|
2009-08-25 21:03:10 +00:00
|
|
|
break;
|
2008-12-09 23:10:17 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
mutex_unlock(&rdata->rp_mutex);
|
2009-08-25 21:03:31 +00:00
|
|
|
return;
|
|
|
|
|
|
|
|
reject:
|
|
|
|
lport->tt.seq_els_rsp_send(sp, ELS_LS_RJT, &els_data);
|
|
|
|
fc_frame_free(fp);
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2009-11-03 19:47:39 +00:00
|
|
|
* fc_rport_recv_req() - Handler for requests
|
|
|
|
* @sp: The sequence the request was on
|
|
|
|
* @fp: The request frame
|
|
|
|
* @lport: The local port that received the request
|
2009-08-25 21:03:31 +00:00
|
|
|
*
|
|
|
|
* Locking Note: Called with the lport lock held.
|
|
|
|
*/
|
|
|
|
void fc_rport_recv_req(struct fc_seq *sp, struct fc_frame *fp,
|
|
|
|
struct fc_lport *lport)
|
|
|
|
{
|
|
|
|
struct fc_seq_els_data els_data;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Handle PLOGI and LOGO requests separately, since they
|
|
|
|
* don't require prior login.
|
|
|
|
* Check for unsupported opcodes first and reject them.
|
|
|
|
* For some ops, it would be incorrect to reject with "PLOGI required".
|
|
|
|
*/
|
|
|
|
switch (fc_frame_payload_op(fp)) {
|
|
|
|
case ELS_PLOGI:
|
|
|
|
fc_rport_recv_plogi_req(lport, sp, fp);
|
|
|
|
break;
|
|
|
|
case ELS_LOGO:
|
|
|
|
fc_rport_recv_logo_req(lport, sp, fp);
|
|
|
|
break;
|
|
|
|
case ELS_PRLI:
|
|
|
|
case ELS_PRLO:
|
2009-08-25 21:03:52 +00:00
|
|
|
case ELS_ADISC:
|
2009-08-25 21:03:31 +00:00
|
|
|
case ELS_RRQ:
|
|
|
|
case ELS_REC:
|
2009-11-20 22:55:24 +00:00
|
|
|
case ELS_RLS:
|
2009-08-25 21:03:31 +00:00
|
|
|
fc_rport_recv_els_req(lport, sp, fp);
|
|
|
|
break;
|
|
|
|
default:
|
|
|
|
fc_frame_free(fp);
|
|
|
|
els_data.fp = NULL;
|
|
|
|
els_data.reason = ELS_RJT_UNSUP;
|
|
|
|
els_data.explan = ELS_EXPL_NONE;
|
|
|
|
lport->tt.seq_els_rsp_send(sp, ELS_LS_RJT, &els_data);
|
|
|
|
break;
|
|
|
|
}
|
2008-12-09 23:10:17 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2009-11-03 19:47:39 +00:00
|
|
|
* fc_rport_recv_plogi_req() - Handler for Port Login (PLOGI) requests
|
|
|
|
* @lport: The local port that received the PLOGI request
|
|
|
|
* @sp: The sequence that the PLOGI request was on
|
|
|
|
* @rx_fp: The PLOGI request frame
|
2008-12-09 23:10:17 +00:00
|
|
|
*
|
2009-08-25 21:03:26 +00:00
|
|
|
* Locking Note: The rport lock is held before calling this function.
|
2008-12-09 23:10:17 +00:00
|
|
|
*/
|
2009-08-25 21:03:26 +00:00
|
|
|
static void fc_rport_recv_plogi_req(struct fc_lport *lport,
|
2008-12-09 23:10:17 +00:00
|
|
|
struct fc_seq *sp, struct fc_frame *rx_fp)
|
|
|
|
{
|
2009-08-25 21:03:26 +00:00
|
|
|
struct fc_disc *disc;
|
|
|
|
struct fc_rport_priv *rdata;
|
2008-12-09 23:10:17 +00:00
|
|
|
struct fc_frame *fp = rx_fp;
|
|
|
|
struct fc_exch *ep;
|
|
|
|
struct fc_frame_header *fh;
|
|
|
|
struct fc_els_flogi *pl;
|
|
|
|
struct fc_seq_els_data rjt_data;
|
2009-08-25 21:03:26 +00:00
|
|
|
u32 sid, f_ctl;
|
2008-12-09 23:10:17 +00:00
|
|
|
|
2009-08-25 21:03:26 +00:00
|
|
|
rjt_data.fp = NULL;
|
2008-12-09 23:10:17 +00:00
|
|
|
fh = fc_frame_header_get(fp);
|
2009-08-25 21:03:26 +00:00
|
|
|
sid = ntoh24(fh->fh_s_id);
|
2008-12-09 23:10:17 +00:00
|
|
|
|
2009-08-25 21:03:26 +00:00
|
|
|
FC_RPORT_ID_DBG(lport, sid, "Received PLOGI request\n");
|
2008-12-09 23:10:17 +00:00
|
|
|
|
|
|
|
pl = fc_frame_payload_get(fp, sizeof(*pl));
|
|
|
|
if (!pl) {
|
2009-08-25 21:03:26 +00:00
|
|
|
FC_RPORT_ID_DBG(lport, sid, "Received PLOGI too short\n");
|
|
|
|
rjt_data.reason = ELS_RJT_PROT;
|
|
|
|
rjt_data.explan = ELS_EXPL_INV_LEN;
|
|
|
|
goto reject;
|
2008-12-09 23:10:17 +00:00
|
|
|
}
|
2009-08-25 21:03:26 +00:00
|
|
|
|
|
|
|
disc = &lport->disc;
|
|
|
|
mutex_lock(&disc->disc_mutex);
|
|
|
|
rdata = lport->tt.rport_create(lport, sid);
|
|
|
|
if (!rdata) {
|
|
|
|
mutex_unlock(&disc->disc_mutex);
|
|
|
|
rjt_data.reason = ELS_RJT_UNAB;
|
|
|
|
rjt_data.explan = ELS_EXPL_INSUF_RES;
|
|
|
|
goto reject;
|
|
|
|
}
|
|
|
|
|
|
|
|
mutex_lock(&rdata->rp_mutex);
|
|
|
|
mutex_unlock(&disc->disc_mutex);
|
|
|
|
|
|
|
|
rdata->ids.port_name = get_unaligned_be64(&pl->fl_wwpn);
|
|
|
|
rdata->ids.node_name = get_unaligned_be64(&pl->fl_wwnn);
|
2008-12-09 23:10:17 +00:00
|
|
|
|
|
|
|
/*
|
2009-08-25 21:03:26 +00:00
|
|
|
* If the rport was just created, possibly due to the incoming PLOGI,
|
2008-12-09 23:10:17 +00:00
|
|
|
* set the state appropriately and accept the PLOGI.
|
|
|
|
*
|
|
|
|
* If we had also sent a PLOGI, and if the received PLOGI is from a
|
|
|
|
* higher WWPN, we accept it, otherwise an LS_RJT is sent with reason
|
|
|
|
* "command already in progress".
|
|
|
|
*
|
|
|
|
* XXX TBD: If the session was ready before, the PLOGI should result in
|
|
|
|
* all outstanding exchanges being reset.
|
|
|
|
*/
|
|
|
|
switch (rdata->rp_state) {
|
|
|
|
case RPORT_ST_INIT:
|
2009-08-25 21:03:26 +00:00
|
|
|
FC_RPORT_DBG(rdata, "Received PLOGI in INIT state\n");
|
2008-12-09 23:10:17 +00:00
|
|
|
break;
|
|
|
|
case RPORT_ST_PLOGI:
|
2009-08-25 21:03:26 +00:00
|
|
|
FC_RPORT_DBG(rdata, "Received PLOGI in PLOGI state\n");
|
|
|
|
if (rdata->ids.port_name < lport->wwpn) {
|
|
|
|
mutex_unlock(&rdata->rp_mutex);
|
|
|
|
rjt_data.reason = ELS_RJT_INPROG;
|
|
|
|
rjt_data.explan = ELS_EXPL_NONE;
|
|
|
|
goto reject;
|
|
|
|
}
|
2008-12-09 23:10:17 +00:00
|
|
|
break;
|
|
|
|
case RPORT_ST_PRLI:
|
[SCSI] libfc: fix free of fc_rport_priv with timer pending
Timer crashes were caused by freeing a struct fc_rport_priv
with a timer pending, causing the timer facility list to be
corrupted. This was during FC uplink flap tests with a lot
of targets.
After discovery, we were doing an PLOGI on an rdata that was
in DELETE state but not yet removed from the lookup list.
This moved the rdata from DELETE state to PLOGI state.
If the PLOGI exchange allocation failed and needed to be
retried, the timer scheduling could race with the free
being done by fc_rport_work().
When fc_rport_login() is called on a rport in DELETE state,
move it to a new state RESTART. In fc_rport_work, when
handling a LOGO, STOPPED or FAILED event, look for restart
state. In the RESTART case, don't take the rdata off the
list and after the transport remote port is deleted and
exchanges are reset, re-login to the remote port.
Note that the new RESTART state also corrects a problem we
had when re-discovering a port that had moved to DELETE state.
In that case, a new rdata was created, but the old rdata
would do an exchange manager reset affecting the FC_ID
for both the new rdata and old rdata. With the new state,
the new port isn't logged into until after any old exchanges
are reset.
Signed-off-by: Joe Eykholt <jeykholt@cisco.com>
Signed-off-by: Robert Love <robert.w.love@intel.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
2009-10-21 23:28:30 +00:00
|
|
|
case RPORT_ST_RTV:
|
2008-12-09 23:10:17 +00:00
|
|
|
case RPORT_ST_READY:
|
2009-08-25 21:03:47 +00:00
|
|
|
case RPORT_ST_ADISC:
|
|
|
|
FC_RPORT_DBG(rdata, "Received PLOGI in logged-in state %d "
|
|
|
|
"- ignored for now\n", rdata->rp_state);
|
|
|
|
/* XXX TBD - should reset */
|
2008-12-09 23:10:17 +00:00
|
|
|
break;
|
2009-07-30 00:04:43 +00:00
|
|
|
case RPORT_ST_DELETE:
|
[SCSI] libfc: fix free of fc_rport_priv with timer pending
Timer crashes were caused by freeing a struct fc_rport_priv
with a timer pending, causing the timer facility list to be
corrupted. This was during FC uplink flap tests with a lot
of targets.
After discovery, we were doing an PLOGI on an rdata that was
in DELETE state but not yet removed from the lookup list.
This moved the rdata from DELETE state to PLOGI state.
If the PLOGI exchange allocation failed and needed to be
retried, the timer scheduling could race with the free
being done by fc_rport_work().
When fc_rport_login() is called on a rport in DELETE state,
move it to a new state RESTART. In fc_rport_work, when
handling a LOGO, STOPPED or FAILED event, look for restart
state. In the RESTART case, don't take the rdata off the
list and after the transport remote port is deleted and
exchanges are reset, re-login to the remote port.
Note that the new RESTART state also corrects a problem we
had when re-discovering a port that had moved to DELETE state.
In that case, a new rdata was created, but the old rdata
would do an exchange manager reset affecting the FC_ID
for both the new rdata and old rdata. With the new state,
the new port isn't logged into until after any old exchanges
are reset.
Signed-off-by: Joe Eykholt <jeykholt@cisco.com>
Signed-off-by: Robert Love <robert.w.love@intel.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
2009-10-21 23:28:30 +00:00
|
|
|
case RPORT_ST_LOGO:
|
|
|
|
case RPORT_ST_RESTART:
|
|
|
|
FC_RPORT_DBG(rdata, "Received PLOGI in state %s - send busy\n",
|
|
|
|
fc_rport_state(rdata));
|
|
|
|
mutex_unlock(&rdata->rp_mutex);
|
|
|
|
rjt_data.reason = ELS_RJT_BUSY;
|
|
|
|
rjt_data.explan = ELS_EXPL_NONE;
|
|
|
|
goto reject;
|
2008-12-09 23:10:17 +00:00
|
|
|
}
|
|
|
|
|
2009-08-25 21:03:26 +00:00
|
|
|
/*
|
|
|
|
* Get session payload size from incoming PLOGI.
|
|
|
|
*/
|
|
|
|
rdata->maxframe_size = fc_plogi_get_maxframe(pl, lport->mfs);
|
|
|
|
fc_frame_free(rx_fp);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Send LS_ACC. If this fails, the originator should retry.
|
|
|
|
*/
|
|
|
|
sp = lport->tt.seq_start_next(sp);
|
|
|
|
if (!sp)
|
|
|
|
goto out;
|
|
|
|
fp = fc_frame_alloc(lport, sizeof(*pl));
|
|
|
|
if (!fp)
|
|
|
|
goto out;
|
|
|
|
|
|
|
|
fc_plogi_fill(lport, fp, ELS_LS_ACC);
|
|
|
|
f_ctl = FC_FC_EX_CTX | FC_FC_LAST_SEQ | FC_FC_END_SEQ | FC_FC_SEQ_INIT;
|
|
|
|
ep = fc_seq_exch(sp);
|
|
|
|
fc_fill_fc_hdr(fp, FC_RCTL_ELS_REP, ep->did, ep->sid,
|
|
|
|
FC_TYPE_ELS, f_ctl, 0);
|
|
|
|
lport->tt.seq_send(lport, sp, fp);
|
|
|
|
fc_rport_enter_prli(rdata);
|
|
|
|
out:
|
|
|
|
mutex_unlock(&rdata->rp_mutex);
|
|
|
|
return;
|
|
|
|
|
|
|
|
reject:
|
|
|
|
lport->tt.seq_els_rsp_send(sp, ELS_LS_RJT, &rjt_data);
|
|
|
|
fc_frame_free(fp);
|
2008-12-09 23:10:17 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2009-11-03 19:47:39 +00:00
|
|
|
* fc_rport_recv_prli_req() - Handler for process login (PRLI) requests
|
|
|
|
* @rdata: The remote port that sent the PRLI request
|
|
|
|
* @sp: The sequence that the PRLI was on
|
|
|
|
* @rx_fp: The PRLI request frame
|
2008-12-09 23:10:17 +00:00
|
|
|
*
|
|
|
|
* Locking Note: The rport lock is exected to be held before calling
|
|
|
|
* this function.
|
|
|
|
*/
|
2009-08-25 21:00:50 +00:00
|
|
|
static void fc_rport_recv_prli_req(struct fc_rport_priv *rdata,
|
2008-12-09 23:10:17 +00:00
|
|
|
struct fc_seq *sp, struct fc_frame *rx_fp)
|
|
|
|
{
|
|
|
|
struct fc_lport *lport = rdata->local_port;
|
|
|
|
struct fc_exch *ep;
|
|
|
|
struct fc_frame *fp;
|
|
|
|
struct fc_frame_header *fh;
|
|
|
|
struct {
|
|
|
|
struct fc_els_prli prli;
|
|
|
|
struct fc_els_spp spp;
|
|
|
|
} *pp;
|
|
|
|
struct fc_els_spp *rspp; /* request service param page */
|
|
|
|
struct fc_els_spp *spp; /* response spp */
|
|
|
|
unsigned int len;
|
|
|
|
unsigned int plen;
|
|
|
|
enum fc_els_rjt_reason reason = ELS_RJT_UNAB;
|
|
|
|
enum fc_els_rjt_explan explan = ELS_EXPL_NONE;
|
|
|
|
enum fc_els_spp_resp resp;
|
|
|
|
struct fc_seq_els_data rjt_data;
|
|
|
|
u32 f_ctl;
|
|
|
|
u32 fcp_parm;
|
|
|
|
u32 roles = FC_RPORT_ROLE_UNKNOWN;
|
|
|
|
rjt_data.fp = NULL;
|
|
|
|
|
|
|
|
fh = fc_frame_header_get(rx_fp);
|
|
|
|
|
2009-08-25 21:00:50 +00:00
|
|
|
FC_RPORT_DBG(rdata, "Received PRLI request while in state %s\n",
|
|
|
|
fc_rport_state(rdata));
|
2008-12-09 23:10:17 +00:00
|
|
|
|
|
|
|
switch (rdata->rp_state) {
|
|
|
|
case RPORT_ST_PRLI:
|
2009-08-25 21:03:26 +00:00
|
|
|
case RPORT_ST_RTV:
|
2008-12-09 23:10:17 +00:00
|
|
|
case RPORT_ST_READY:
|
2009-08-25 21:03:47 +00:00
|
|
|
case RPORT_ST_ADISC:
|
2008-12-09 23:10:17 +00:00
|
|
|
reason = ELS_RJT_NONE;
|
|
|
|
break;
|
|
|
|
default:
|
[SCSI] libfc: Track rogue remote ports
Rogue ports are currently not tracked on any list. The only reference
to them is through any outstanding exchanges pending on the rogue ports.
If the module is removed while a retry is set on a rogue port
(say a Plogi retry for instance), this retry is not cancelled because there
is no reference to the rogue port in the discovery rports list. Thus the
local port can clean itself up, delete the exchange pool, and then the
rogue port timeout can fire and try to start up another exchange.
This patch tracks the rogue ports in a new list disc->rogue_rports. Creating
a new list instead of using the disc->rports list keeps remote port code
change to a minimum.
1) Whenever a rogue port is created, it is immediately added to the
disc->rogue_rports list.
2) When the rogues port goes to ready, it is removed from the rogue list
and the real remote port is added to the disc->rports list
3) The removal of the rogue from the disc->rogue_rports list is done in
the context of the fc_rport_work() workQ thread in discovery callback.
4) Real rports are removed from the disc->rports list like before. Lookup
is done only in the real rports list. This avoids making large changes
to the remote port code.
5) In fc_disc_stop_rports, the rogues list is traversed in addition to the
real list to stop the rogue ports and issue logoffs on them. This way, rogue
ports get cleaned up when the local port goes away.
6) rogue remote ports are not removed from the list right away, but
removed late in fc_rport_work() context, multiple threads can find the same
remote port in the list and call rport_logoff(). Rport_logoff() only
continues with the logoff if port is not in NONE state, thus preventing
multiple logoffs and multiple list deletions.
7) Since the rport is removed from the disc list at a later stage
(in the disc callback), incoming frames can find the rport even if
rport_logoff() has been called on the rport. When rport_logoff() is called,
the rport state is set to NONE, and we are trying to cancel all exchanges
and retries on that port. While in this state, if an incoming
Plogi/Prli/Logo or other frames match the rport, we should not reply
because the rport is in the NONE state. Just drop the frame, since the
rport will be deleted soon in the disc callback (fc_rport_work)
8) In fc_disc_single(), remove rport lookup and call to fc_disc_del_target.
fc_disc_single() is called from recv_rscn_req() where rport lookup
and rport_logoff is already done.
Signed-off-by: Abhijeet Joglekar <abjoglek@cisco.com>
Signed-off-by: Robert Love <robert.w.love@intel.com>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
2009-04-21 23:27:04 +00:00
|
|
|
fc_frame_free(rx_fp);
|
|
|
|
return;
|
2008-12-09 23:10:17 +00:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
len = fr_len(rx_fp) - sizeof(*fh);
|
|
|
|
pp = fc_frame_payload_get(rx_fp, sizeof(*pp));
|
|
|
|
if (pp == NULL) {
|
|
|
|
reason = ELS_RJT_PROT;
|
|
|
|
explan = ELS_EXPL_INV_LEN;
|
|
|
|
} else {
|
|
|
|
plen = ntohs(pp->prli.prli_len);
|
|
|
|
if ((plen % 4) != 0 || plen > len) {
|
|
|
|
reason = ELS_RJT_PROT;
|
|
|
|
explan = ELS_EXPL_INV_LEN;
|
|
|
|
} else if (plen < len) {
|
|
|
|
len = plen;
|
|
|
|
}
|
|
|
|
plen = pp->prli.prli_spp_len;
|
|
|
|
if ((plen % 4) != 0 || plen < sizeof(*spp) ||
|
|
|
|
plen > len || len < sizeof(*pp)) {
|
|
|
|
reason = ELS_RJT_PROT;
|
|
|
|
explan = ELS_EXPL_INV_LEN;
|
|
|
|
}
|
|
|
|
rspp = &pp->spp;
|
|
|
|
}
|
|
|
|
if (reason != ELS_RJT_NONE ||
|
|
|
|
(fp = fc_frame_alloc(lport, len)) == NULL) {
|
|
|
|
rjt_data.reason = reason;
|
|
|
|
rjt_data.explan = explan;
|
|
|
|
lport->tt.seq_els_rsp_send(sp, ELS_LS_RJT, &rjt_data);
|
|
|
|
} else {
|
|
|
|
sp = lport->tt.seq_start_next(sp);
|
|
|
|
WARN_ON(!sp);
|
|
|
|
pp = fc_frame_payload_get(fp, len);
|
|
|
|
WARN_ON(!pp);
|
|
|
|
memset(pp, 0, len);
|
|
|
|
pp->prli.prli_cmd = ELS_LS_ACC;
|
|
|
|
pp->prli.prli_spp_len = plen;
|
|
|
|
pp->prli.prli_len = htons(len);
|
|
|
|
len -= sizeof(struct fc_els_prli);
|
|
|
|
|
2009-08-25 21:03:04 +00:00
|
|
|
/* reinitialize remote port roles */
|
|
|
|
rdata->ids.roles = FC_RPORT_ROLE_UNKNOWN;
|
|
|
|
|
2008-12-09 23:10:17 +00:00
|
|
|
/*
|
|
|
|
* Go through all the service parameter pages and build
|
|
|
|
* response. If plen indicates longer SPP than standard,
|
|
|
|
* use that. The entire response has been pre-cleared above.
|
|
|
|
*/
|
|
|
|
spp = &pp->spp;
|
|
|
|
while (len >= plen) {
|
|
|
|
spp->spp_type = rspp->spp_type;
|
|
|
|
spp->spp_type_ext = rspp->spp_type_ext;
|
|
|
|
spp->spp_flags = rspp->spp_flags & FC_SPP_EST_IMG_PAIR;
|
|
|
|
resp = FC_SPP_RESP_ACK;
|
|
|
|
if (rspp->spp_flags & FC_SPP_RPA_VAL)
|
|
|
|
resp = FC_SPP_RESP_NO_PA;
|
|
|
|
switch (rspp->spp_type) {
|
|
|
|
case 0: /* common to all FC-4 types */
|
|
|
|
break;
|
|
|
|
case FC_TYPE_FCP:
|
|
|
|
fcp_parm = ntohl(rspp->spp_params);
|
2009-10-21 23:26:45 +00:00
|
|
|
if (fcp_parm & FCP_SPPF_RETRY)
|
2008-12-09 23:10:17 +00:00
|
|
|
rdata->flags |= FC_RP_FLAGS_RETRY;
|
2009-08-25 21:01:01 +00:00
|
|
|
rdata->supported_classes = FC_COS_CLASS3;
|
2008-12-09 23:10:17 +00:00
|
|
|
if (fcp_parm & FCP_SPPF_INIT_FCN)
|
|
|
|
roles |= FC_RPORT_ROLE_FCP_INITIATOR;
|
|
|
|
if (fcp_parm & FCP_SPPF_TARG_FCN)
|
|
|
|
roles |= FC_RPORT_ROLE_FCP_TARGET;
|
2009-08-25 21:01:01 +00:00
|
|
|
rdata->ids.roles = roles;
|
2008-12-09 23:10:17 +00:00
|
|
|
|
|
|
|
spp->spp_params =
|
|
|
|
htonl(lport->service_params);
|
|
|
|
break;
|
|
|
|
default:
|
|
|
|
resp = FC_SPP_RESP_INVL;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
spp->spp_flags |= resp;
|
|
|
|
len -= plen;
|
|
|
|
rspp = (struct fc_els_spp *)((char *)rspp + plen);
|
|
|
|
spp = (struct fc_els_spp *)((char *)spp + plen);
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Send LS_ACC. If this fails, the originator should retry.
|
|
|
|
*/
|
|
|
|
f_ctl = FC_FC_EX_CTX | FC_FC_LAST_SEQ;
|
|
|
|
f_ctl |= FC_FC_END_SEQ | FC_FC_SEQ_INIT;
|
|
|
|
ep = fc_seq_exch(sp);
|
|
|
|
fc_fill_fc_hdr(fp, FC_RCTL_ELS_REP, ep->did, ep->sid,
|
|
|
|
FC_TYPE_ELS, f_ctl, 0);
|
|
|
|
lport->tt.seq_send(lport, sp, fp);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Get lock and re-check state.
|
|
|
|
*/
|
|
|
|
switch (rdata->rp_state) {
|
|
|
|
case RPORT_ST_PRLI:
|
2009-08-25 21:00:50 +00:00
|
|
|
fc_rport_enter_ready(rdata);
|
2008-12-09 23:10:17 +00:00
|
|
|
break;
|
|
|
|
case RPORT_ST_READY:
|
2009-08-25 21:03:47 +00:00
|
|
|
case RPORT_ST_ADISC:
|
2008-12-09 23:10:17 +00:00
|
|
|
break;
|
|
|
|
default:
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
fc_frame_free(rx_fp);
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2009-11-03 19:47:39 +00:00
|
|
|
* fc_rport_recv_prlo_req() - Handler for process logout (PRLO) requests
|
|
|
|
* @rdata: The remote port that sent the PRLO request
|
|
|
|
* @sp: The sequence that the PRLO was on
|
|
|
|
* @fp: The PRLO request frame
|
2008-12-09 23:10:17 +00:00
|
|
|
*
|
|
|
|
* Locking Note: The rport lock is exected to be held before calling
|
|
|
|
* this function.
|
|
|
|
*/
|
2009-08-25 21:00:50 +00:00
|
|
|
static void fc_rport_recv_prlo_req(struct fc_rport_priv *rdata,
|
|
|
|
struct fc_seq *sp,
|
2008-12-09 23:10:17 +00:00
|
|
|
struct fc_frame *fp)
|
|
|
|
{
|
|
|
|
struct fc_lport *lport = rdata->local_port;
|
|
|
|
|
|
|
|
struct fc_frame_header *fh;
|
|
|
|
struct fc_seq_els_data rjt_data;
|
|
|
|
|
|
|
|
fh = fc_frame_header_get(fp);
|
|
|
|
|
2009-08-25 21:00:50 +00:00
|
|
|
FC_RPORT_DBG(rdata, "Received PRLO request while in state %s\n",
|
|
|
|
fc_rport_state(rdata));
|
2008-12-09 23:10:17 +00:00
|
|
|
|
|
|
|
rjt_data.fp = NULL;
|
|
|
|
rjt_data.reason = ELS_RJT_UNAB;
|
|
|
|
rjt_data.explan = ELS_EXPL_NONE;
|
|
|
|
lport->tt.seq_els_rsp_send(sp, ELS_LS_RJT, &rjt_data);
|
|
|
|
fc_frame_free(fp);
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2009-11-03 19:47:39 +00:00
|
|
|
* fc_rport_recv_logo_req() - Handler for logout (LOGO) requests
|
|
|
|
* @lport: The local port that received the LOGO request
|
|
|
|
* @sp: The sequence that the LOGO request was on
|
|
|
|
* @fp: The LOGO request frame
|
2008-12-09 23:10:17 +00:00
|
|
|
*
|
|
|
|
* Locking Note: The rport lock is exected to be held before calling
|
|
|
|
* this function.
|
|
|
|
*/
|
2009-08-25 21:03:31 +00:00
|
|
|
static void fc_rport_recv_logo_req(struct fc_lport *lport,
|
2009-08-25 21:00:50 +00:00
|
|
|
struct fc_seq *sp,
|
2008-12-09 23:10:17 +00:00
|
|
|
struct fc_frame *fp)
|
|
|
|
{
|
|
|
|
struct fc_frame_header *fh;
|
2009-08-25 21:03:31 +00:00
|
|
|
struct fc_rport_priv *rdata;
|
|
|
|
u32 sid;
|
2008-12-09 23:10:17 +00:00
|
|
|
|
2009-08-25 21:03:36 +00:00
|
|
|
lport->tt.seq_els_rsp_send(sp, ELS_LS_ACC, NULL);
|
|
|
|
|
2008-12-09 23:10:17 +00:00
|
|
|
fh = fc_frame_header_get(fp);
|
2009-08-25 21:03:31 +00:00
|
|
|
sid = ntoh24(fh->fh_s_id);
|
2008-12-09 23:10:17 +00:00
|
|
|
|
2009-08-25 21:03:31 +00:00
|
|
|
mutex_lock(&lport->disc.disc_mutex);
|
|
|
|
rdata = lport->tt.rport_lookup(lport, sid);
|
|
|
|
if (rdata) {
|
|
|
|
mutex_lock(&rdata->rp_mutex);
|
|
|
|
FC_RPORT_DBG(rdata, "Received LOGO request while in state %s\n",
|
|
|
|
fc_rport_state(rdata));
|
2009-08-25 21:03:36 +00:00
|
|
|
|
[SCSI] libfc: fix free of fc_rport_priv with timer pending
Timer crashes were caused by freeing a struct fc_rport_priv
with a timer pending, causing the timer facility list to be
corrupted. This was during FC uplink flap tests with a lot
of targets.
After discovery, we were doing an PLOGI on an rdata that was
in DELETE state but not yet removed from the lookup list.
This moved the rdata from DELETE state to PLOGI state.
If the PLOGI exchange allocation failed and needed to be
retried, the timer scheduling could race with the free
being done by fc_rport_work().
When fc_rport_login() is called on a rport in DELETE state,
move it to a new state RESTART. In fc_rport_work, when
handling a LOGO, STOPPED or FAILED event, look for restart
state. In the RESTART case, don't take the rdata off the
list and after the transport remote port is deleted and
exchanges are reset, re-login to the remote port.
Note that the new RESTART state also corrects a problem we
had when re-discovering a port that had moved to DELETE state.
In that case, a new rdata was created, but the old rdata
would do an exchange manager reset affecting the FC_ID
for both the new rdata and old rdata. With the new state,
the new port isn't logged into until after any old exchanges
are reset.
Signed-off-by: Joe Eykholt <jeykholt@cisco.com>
Signed-off-by: Robert Love <robert.w.love@intel.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
2009-10-21 23:28:30 +00:00
|
|
|
fc_rport_enter_delete(rdata, RPORT_EV_LOGO);
|
|
|
|
|
2009-08-25 21:03:36 +00:00
|
|
|
/*
|
[SCSI] libfc: fix free of fc_rport_priv with timer pending
Timer crashes were caused by freeing a struct fc_rport_priv
with a timer pending, causing the timer facility list to be
corrupted. This was during FC uplink flap tests with a lot
of targets.
After discovery, we were doing an PLOGI on an rdata that was
in DELETE state but not yet removed from the lookup list.
This moved the rdata from DELETE state to PLOGI state.
If the PLOGI exchange allocation failed and needed to be
retried, the timer scheduling could race with the free
being done by fc_rport_work().
When fc_rport_login() is called on a rport in DELETE state,
move it to a new state RESTART. In fc_rport_work, when
handling a LOGO, STOPPED or FAILED event, look for restart
state. In the RESTART case, don't take the rdata off the
list and after the transport remote port is deleted and
exchanges are reset, re-login to the remote port.
Note that the new RESTART state also corrects a problem we
had when re-discovering a port that had moved to DELETE state.
In that case, a new rdata was created, but the old rdata
would do an exchange manager reset affecting the FC_ID
for both the new rdata and old rdata. With the new state,
the new port isn't logged into until after any old exchanges
are reset.
Signed-off-by: Joe Eykholt <jeykholt@cisco.com>
Signed-off-by: Robert Love <robert.w.love@intel.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
2009-10-21 23:28:30 +00:00
|
|
|
* If the remote port was created due to discovery, set state
|
|
|
|
* to log back in. It may have seen a stale RSCN about us.
|
2009-08-25 21:03:36 +00:00
|
|
|
*/
|
[SCSI] libfc: fix free of fc_rport_priv with timer pending
Timer crashes were caused by freeing a struct fc_rport_priv
with a timer pending, causing the timer facility list to be
corrupted. This was during FC uplink flap tests with a lot
of targets.
After discovery, we were doing an PLOGI on an rdata that was
in DELETE state but not yet removed from the lookup list.
This moved the rdata from DELETE state to PLOGI state.
If the PLOGI exchange allocation failed and needed to be
retried, the timer scheduling could race with the free
being done by fc_rport_work().
When fc_rport_login() is called on a rport in DELETE state,
move it to a new state RESTART. In fc_rport_work, when
handling a LOGO, STOPPED or FAILED event, look for restart
state. In the RESTART case, don't take the rdata off the
list and after the transport remote port is deleted and
exchanges are reset, re-login to the remote port.
Note that the new RESTART state also corrects a problem we
had when re-discovering a port that had moved to DELETE state.
In that case, a new rdata was created, but the old rdata
would do an exchange manager reset affecting the FC_ID
for both the new rdata and old rdata. With the new state,
the new port isn't logged into until after any old exchanges
are reset.
Signed-off-by: Joe Eykholt <jeykholt@cisco.com>
Signed-off-by: Robert Love <robert.w.love@intel.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
2009-10-21 23:28:30 +00:00
|
|
|
if (rdata->disc_id)
|
|
|
|
fc_rport_state_enter(rdata, RPORT_ST_RESTART);
|
2009-08-25 21:03:31 +00:00
|
|
|
mutex_unlock(&rdata->rp_mutex);
|
|
|
|
} else
|
|
|
|
FC_RPORT_ID_DBG(lport, sid,
|
|
|
|
"Received LOGO from non-logged-in port\n");
|
|
|
|
mutex_unlock(&lport->disc.disc_mutex);
|
2008-12-09 23:10:17 +00:00
|
|
|
fc_frame_free(fp);
|
|
|
|
}
|
|
|
|
|
2009-11-03 19:47:39 +00:00
|
|
|
/**
|
|
|
|
* fc_rport_flush_queue() - Flush the rport_event_queue
|
|
|
|
*/
|
2008-12-09 23:10:17 +00:00
|
|
|
static void fc_rport_flush_queue(void)
|
|
|
|
{
|
|
|
|
flush_workqueue(rport_event_queue);
|
|
|
|
}
|
|
|
|
|
2009-11-03 19:47:39 +00:00
|
|
|
/**
|
|
|
|
* fc_rport_init() - Initialize the remote port layer for a local port
|
|
|
|
* @lport: The local port to initialize the remote port layer for
|
|
|
|
*/
|
2008-12-09 23:10:17 +00:00
|
|
|
int fc_rport_init(struct fc_lport *lport)
|
|
|
|
{
|
2009-08-25 21:02:06 +00:00
|
|
|
if (!lport->tt.rport_lookup)
|
|
|
|
lport->tt.rport_lookup = fc_rport_lookup;
|
|
|
|
|
2009-02-27 18:55:18 +00:00
|
|
|
if (!lport->tt.rport_create)
|
2009-08-25 21:01:18 +00:00
|
|
|
lport->tt.rport_create = fc_rport_create;
|
2009-02-27 18:55:18 +00:00
|
|
|
|
2008-12-09 23:10:17 +00:00
|
|
|
if (!lport->tt.rport_login)
|
|
|
|
lport->tt.rport_login = fc_rport_login;
|
|
|
|
|
|
|
|
if (!lport->tt.rport_logoff)
|
|
|
|
lport->tt.rport_logoff = fc_rport_logoff;
|
|
|
|
|
|
|
|
if (!lport->tt.rport_recv_req)
|
|
|
|
lport->tt.rport_recv_req = fc_rport_recv_req;
|
|
|
|
|
|
|
|
if (!lport->tt.rport_flush_queue)
|
|
|
|
lport->tt.rport_flush_queue = fc_rport_flush_queue;
|
|
|
|
|
2009-08-25 21:01:01 +00:00
|
|
|
if (!lport->tt.rport_destroy)
|
|
|
|
lport->tt.rport_destroy = fc_rport_destroy;
|
|
|
|
|
2008-12-09 23:10:17 +00:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL(fc_rport_init);
|
|
|
|
|
2009-11-03 19:47:39 +00:00
|
|
|
/**
|
|
|
|
* fc_setup_rport() - Initialize the rport_event_queue
|
|
|
|
*/
|
|
|
|
int fc_setup_rport()
|
2008-12-09 23:10:17 +00:00
|
|
|
{
|
|
|
|
rport_event_queue = create_singlethread_workqueue("fc_rport_eq");
|
|
|
|
if (!rport_event_queue)
|
|
|
|
return -ENOMEM;
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2009-11-03 19:47:39 +00:00
|
|
|
/**
|
|
|
|
* fc_destroy_rport() - Destroy the rport_event_queue
|
|
|
|
*/
|
|
|
|
void fc_destroy_rport()
|
2008-12-09 23:10:17 +00:00
|
|
|
{
|
|
|
|
destroy_workqueue(rport_event_queue);
|
|
|
|
}
|
|
|
|
|
2009-11-03 19:47:39 +00:00
|
|
|
/**
|
|
|
|
* fc_rport_terminate_io() - Stop all outstanding I/O on a remote port
|
|
|
|
* @rport: The remote port whose I/O should be terminated
|
|
|
|
*/
|
2008-12-09 23:10:17 +00:00
|
|
|
void fc_rport_terminate_io(struct fc_rport *rport)
|
|
|
|
{
|
2009-11-03 19:47:39 +00:00
|
|
|
struct fc_rport_libfc_priv *rpriv = rport->dd_data;
|
|
|
|
struct fc_lport *lport = rpriv->local_port;
|
2008-12-09 23:10:17 +00:00
|
|
|
|
2009-02-27 18:54:35 +00:00
|
|
|
lport->tt.exch_mgr_reset(lport, 0, rport->port_id);
|
|
|
|
lport->tt.exch_mgr_reset(lport, rport->port_id, 0);
|
2008-12-09 23:10:17 +00:00
|
|
|
}
|
|
|
|
EXPORT_SYMBOL(fc_rport_terminate_io);
|